Re: [vpp-dev] One question about fast path ipv4 inbound

2023-02-13 Thread Bronowski, PiotrX
Hi Guangming You are right, and it is part that I’ve overlooked. However, your change is only half of the fix – the other half that needs to be changed is mask calculation. BR, Piotr From: zhangguangm...@baicells.com Sent: Monday, February 13, 2023 4:40 AM To: Bronowski, PiotrX ; vpp-dev Sub

Re: [vpp-dev] One question about fast path ipv4 inbound

2023-02-12 Thread Guangming
Hi, Piotr The follow is example fixed code. ipsec_fp_get_policy_5tuple (ipsec_policy_t *policy, ipsec_fp_5tuple_t *tuple, bool inbound) { memset (tuple, 0, sizeof (*tuple)); tuple->is_ipv6 = policy->is_ipv6; if (tuple->is_ipv6) { tuple->ip6_laddr =

Re: [vpp-dev] One question about fast path ipv4 inbound

2023-02-12 Thread Guangming
icy into fpd table shoud use ipsec tunnel src and dst address not use traffic selector address . Guangming zhangguangm...@baicells.com From: Bronowski, PiotrX Date: 2023-02-13 05:13 To: zhang, Guangming; vpp-dev Subject: Re: [vpp-dev] One question about fast path ipv4 inbound Hi Guangming I am n

Re: [vpp-dev] One question about fast path ipv4 inbound

2023-02-12 Thread Bronowski, PiotrX
Hi Guangming I am not sure if I understand your question. There was a bug, in implementation of fast path for inbound traffic, where I've messed up translation of src and dst to the local and remote address, but it has been fixed with commit 1d9780a43fe54a55c7540f3528b8703ede0a5871 Author: Piot

[vpp-dev] One question about fast path ipv4 inbound

2023-02-11 Thread Guangming
Hi Piotr, I found you work on the ipsec policy mode optiimization, introduced a fast path about ipsec policy match . In the fast path ipv4 inbound , add item into hash, you used traffic selector src and dst address, but search item from hash you used esp packetr src and dst addres