'make install-dep' also installs the .git_commit_template.txt
Thanks,
-daw-
On 6/24/2020 4:57 AM, Ole Troan wrote:
Type: fix needs to be on a separate line. Take a look at other commit messages
for examples.
Or use the template in
.git_commit_template.txt
git config commit.template .git_comm
Its working now, Thanks.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16808): https://lists.fd.io/g/vpp-dev/message/16808
Mute This Topic: https://lists.fd.io/mt/75076228/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.i
> Type: fix needs to be on a separate line. Take a look at other commit
> messages for examples.
Or use the template in
.git_commit_template.txt
git config commit.template .git_commit_template.txt
Ole
>
>> On 24 Jun 2020, at 10:42, Chinmaya Aggarwal wrote:
>>
>> Still not working for me. I
Type: fix needs to be on a separate line. Take a look at other commit messages
for examples.
> On 24 Jun 2020, at 10:42, Chinmaya Aggarwal wrote:
>
> Still not working for me. I executed
> git commit -s --amend -m 'Type: fix sr: fix for SID index across segment
> lists within a sr policy'
>
Still not working for me. I executed
git commit -s --amend -m 'Type: fix sr: fix for SID index across segment lists
within a sr policy'
But still git log shows
commit a3c7df5131c9905a209cee017e80fdff6b5b2e6e (HEAD ->
review/chinmaya_agarwal/fix/vpp_topic_74477804)
Author: Chinmaya Agarwal
Date:
Hi,
just amend the commit message and add it by hand. Commit message must contain a
line like
Type: fix
or
Type: improvement
or whatever is applicable.
Regards,
Klement
> On 24 Jun 2020, at 10:31, Chinmaya Aggarwal wrote:
>
> After i commit my fix, i run the script ./extras/scripts/check
After i commit my fix, i run the script ./extras/scripts/check_commit_msg.sh
and it gives me error : -
root@ggnlabvm-hnsnfvsdn03:~/vpp# ./extras/scripts/check_commit_msg.sh
=== ERROR ===
Unknown commit type '' in commit message body.
Commit m
You need to use git-review version 1.28.0:
$ pip install git-review==1.28.0
Best Regards
Yulong Pei
From: vpp-dev@lists.fd.io On Behalf Of Chinmaya Aggarwal
Sent: Wednesday, June 24, 2020 12:55 PM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] Issue while pushing code for gerrit review
Hi,
I have
Hi,
I have raised an issue on VPP mailing list (
https://lists.fd.io/g/vpp-dev/topic/74894689 ). I have done the fix for this
issue and want to submit the fix for gerrit review. I followed the steps
described in
https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Cod
