Re: [vpp-dev] FEATURE.yaml

2020-01-07 Thread Ole Troan
Thanks Dave! Cheers Ole > On 7 Jan 2020, at 22:14, Dave Wallace wrote: > >  > Folks, > > This issue has now been resolved by [0] and the checkstyle & checkfeature > Makefile targets have been verified to be executing and rejecting invalid > FEATURE.yaml files [1] > > Thanks, > -daw- > >

Re: [vpp-dev] FEATURE.yaml

2020-01-07 Thread Dave Wallace
Folks, This issue has now been resolved by [0] and the checkstyle & checkfeature Makefile targets have been verified to be executing and rejecting invalid FEATURE.yaml files [1] Thanks, -daw- [0] https://gerrit.fd.io/r/c/ci-management/+/24226 [1] https://gerrit.fd.io/r/c/vpp/+/24227 On 1/7/

[vpp-dev] FEATURE.yaml

2020-01-07 Thread Ole Troan
Hi, As people add the feature description to their features (FEATURE.yaml), a few errors have crept in. The JSON schema / YAML definition is quite fickle. I added the YAML validator to the checkstyle target, but unfortunately that hasn't made it into the verify-checkstyle jenkins job (yet). Ple