Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Klement Sekera via lists.fd.io
ch things: >>> >>> if (a) >>> { >>> b = 13; >>> c = 12; >>> /* new code */ >>> if(d) { >>> e=this_is_new(); >>> } >>> /* end new code */ >>> } >>> >>> Thanks...

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Christian Hopps
t; From: Damjan Marion >> Sent: Saturday, April 18, 2020 5:51 AM >> To: Andrew Yourtchenko >> Cc: Dave Barach (dbarach) ; Zhang Yuwei >> ; vpp-dev@lists.fd.io >> Subject: Re: [vpp-dev] Checkstyle script not work in ubuntu >> >> >> And this is e

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Klement Sekera via lists.fd.io
{ > e=this_is_new(); > } > /* end new code */ > } > > Thanks... Dave > > From: Damjan Marion > Sent: Saturday, April 18, 2020 5:51 AM > To: Andrew Yourtchenko > Cc: Dave Barach (dbarach) ; Zhang Yuwei > ; vpp-dev@lists.fd.io >

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Dave Barach via lists.fd.io
Barach (dbarach) ; Zhang Yuwei ; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Checkstyle script not work in ubuntu And this is example of script, which just formats modified lines, instead of re-formating whole file, as we do today. With something like this, we can introduce new indent or even move

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Damjan Marion via lists.fd.io
gt;>> The script works fine. You have the wrong version of gnu indent installed. >>> This is the version you need: >>> >>> $ indent --version >>> GNU indent 2.2.11 >>> >>> From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> >&

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Damjan Marion via lists.fd.io
. >> This is the version you need: >> >> $ indent --version >> GNU indent 2.2.11 >> >> From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > <mailto:vpp-dev@lists.fd.io>> On Behalf Of Zhang Yuwei >> Sent: Saturday, April 11, 2020 1:04 AM >&

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-18 Thread Andrew Yourtchenko
vpp-dev@lists.fd.io > Subject: [vpp-dev] Checkstyle script not work in ubuntu > > Hi Guys, > I find checkstyle script doesn’t work normally in ubuntu > sometimes that I run make fixstyle in ubuntu and submit the code to gerrit > but still fail in checkstyle step. I need to

Re: [vpp-dev] Checkstyle script not work in ubuntu

2020-04-11 Thread Dave Barach via lists.fd.io
The script works fine. You have the wrong version of gnu indent installed. This is the version you need: $ indent --version GNU indent 2.2.11 From: vpp-dev@lists.fd.io On Behalf Of Zhang Yuwei Sent: Saturday, April 11, 2020 1:04 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] Checkstyle script

[vpp-dev] Checkstyle script not work in ubuntu

2020-04-10 Thread Zhang Yuwei
Hi Guys, I find checkstyle script doesn’t work normally in ubuntu sometimes that I run make fixstyle in ubuntu and submit the code to gerrit but still fail in checkstyle step. I need to move to centos to make it work, can anybody check this? Thanks a lot. Regards, Yuwei -=-=-=-=-=-=