Re: [vpp-dev] ACL Match in fa_node.c

2017-08-30 Thread Wang, Yipeng1
ts.fd.io; zhang...@yunshan.net.cn > Subject: Re: [vpp-dev] ACL Match in fa_node.c > > Hi Yipeng, > > yeah, this case should be handled as well - note that the ACL lookup hash is > 48x8, > while the session lookup hash is 40x8, and the fa_5tuple_t (being 48 bytes in > size

Re: [vpp-dev] ACL Match in fa_node.c

2017-08-29 Thread Andrew 👽 Yourtchenko
--- > >> From: "Andrew  Yourtchenko"> gmail.com<https://lists.fd.io/mailman/listinfo/vpp-dev>>; > >> Date: Tue, May 23, 2017 07:56 PM > >> To: "张攀"> yunshan.net.cn<https://lists.fd.io/mailman/listinfo/vpp-dev>>; > >>

Re: [vpp-dev] ACL Match in fa_node.c

2017-08-28 Thread Wang, Yipeng1
...@yunshan.net.cn Subject: Re: [vpp-dev] ACL Match in fa_node.c Hi Yipeng, It's already there - just have a look through hash_* files in the ACL plugin directory on the master or latest stable/1707 :-) There are several things more that can be taken care of (e.g. the determination of the "ACE no

Re: [vpp-dev] ACL Match in fa_node.c

2017-08-27 Thread Andrew Yourtchenko
: "Andrew  Yourtchenko"; > > Date: Tue, May 23, 2017 07:56 PM > > To: "张攀"; > > Cc: "vpp-dev"; > > Subject: Re: [vpp-dev] ACL Match in fa_node.c > > > > > > Hi! > > > > On 5/23/17, 张攀 wrote: > &g

Re: [vpp-dev] ACL Match in fa_node.c

2017-08-25 Thread Wang, Yipeng1
, 2017 07:56 PM > To: "张攀" yunshan.net.cn<https://lists.fd.io/mailman/listinfo/vpp-dev>>; > Cc: "vpp-dev" lists.fd.io<https://lists.fd.io/mailman/listinfo/vpp-dev>>; > Subject: Re: [vpp-dev] ACL Match in fa_node.c > > > Hi! > > On 5/23/17,

Re: [vpp-dev] ACL Match in fa_node.c

2017-05-25 Thread zhang...@yunshan.net.cn
hand-on experiences, looking forwared to collaborating with you :p Best Regards, Pan zhang...@yunshan.net.cn From: Andrew  Yourtchenko Date: 2017-05-24 02:48 To: 张攀 CC: vpp-dev Subject: Re: [vpp-dev] ACL Match in fa_node.c Hi Pan! On 5/23/17, 张攀 wrote: > Hi And

Re: [vpp-dev] ACL Match in fa_node.c

2017-05-23 Thread Andrew 👽 Yourtchenko
Hi Pan! On 5/23/17, 张攀 wrote: > Hi Andrew! > > > -- Original -- > From: "Andrew 👽 Yourtchenko"; > Date: Tue, May 23, 2017 07:56 PM > To: "张攀"; > Cc: "vpp-dev"; > Subject: Re: [vpp-dev] ACL Match in

Re: [vpp-dev] ACL Match in fa_node.c

2017-05-23 Thread 张攀
Hi Andrew! -- Original -- From: "Andrew 👽 Yourtchenko"; Date: Tue, May 23, 2017 07:56 PM To: "张攀"; Cc: "vpp-dev"; Subject: Re: [vpp-dev] ACL Match in fa_node.c Hi! On 5/23/17, 张攀 wrote: > Hi guys, > > >

Re: [vpp-dev] ACL Match in fa_node.c

2017-05-23 Thread Andrew 👽 Yourtchenko
Hi! On 5/23/17, 张攀 wrote: > Hi guys, > > > I looked into the source code of vpp/src/plugin/acl/fa_node.c, > in function full_acl_match_5tuple(), it seems that every ingress packet is > matching against each ACL rule stored in acl_main->acls in a for-loop > manner. This seems not fairly effective.

[vpp-dev] ACL Match in fa_node.c

2017-05-23 Thread 张攀
Hi guys, I looked into the source code of vpp/src/plugin/acl/fa_node.c, in function full_acl_match_5tuple(), it seems that every ingress packet is matching against each ACL rule stored in acl_main->acls in a for-loop manner. This seems not fairly effective. Besides, I notice that in vpp/src/p