Re: [vpp-dev] Discussion Topic: creating demo branches in git.fd.io/vpp

2017-11-15 Thread Ole Troan (otroan)
> The concern would be that without CI you have very limited visibility into > the impact of the patches pre-merge. The automation at fd.io does a *lot* > for you… Absolutely. For the hackathons CI was an order or two of magnitude too slow. And we would be doing the testing there and then. I d

Re: [vpp-dev] jvpp core future test failure (gerrit 8743)

2017-10-13 Thread Ole Troan (otroan)
s/map/dns if you were to cut and paste. #define vl_msg_name_crc_list #include #undef vl_msg_name_crc_list static void setup_message_id_table (api_main_t * am) { #define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id); foreach_vl_msg_name_crc_dns; #undef _ } Ole On 13 Oct 2017

Re: [vpp-dev] jvpp core future test failure (gerrit 8743)

2017-10-13 Thread Ole Troan (otroan)
Dear Dave, I wonder if you forgot to hookup the messages in the CRC dictionary? #define vl_msg_name_crc_list #include #undef vl_msg_name_crc_list static void setup_message_id_table (api_main_t * am) { #define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id); foreach_vl_msg_name_c

Re: [vpp-dev] Traceback Seen in invoke Python APIs with Parameters

2017-02-18 Thread Ole Troan (otroan)
Hi Hang, You have to use named arguments. Change in 17.01. Best regards, Ole > On 18 Feb 2017, at 19:13, Hang Shi wrote: > > Hi, > > I am trying to use VPP python APIs and seeing the tracebacks (see below) for > Python APIs with parameters, while Python APIs without parameters are fine.

Re: [vpp-dev] Fix for vpp-verify-master-ubuntu1604 build failures

2017-02-02 Thread Ole Troan (otroan)
Dave, On a rebased build I just hot the following... related? O. 08:08:01 + echo IS_CSIT_VPP_JOB= 08:08:01 IS_CSIT_VPP_JOB= 08:08:01 + git log --oneline 08:08:01 + grep 37682e1 08:08:01 + '[' x '!=' xTrue ']' 08:08:01 + echo 'Building using "make verify"' 08:08:01 Building using "make v

Re: [vpp-dev] Committer / Maintainer model.

2016-12-21 Thread Ole Troan (otroan)
Ray, > Well if they are a 'committer' then dispense with the extra bureaucracy and > give them commit rights? It's a matter of granularity really. I could certainly imagine myself only having control of vnet/map and not want to have responsibility or authority over anything else. When it co

Re: [vpp-dev] Committer / Maintainer model.

2016-12-21 Thread Ole Troan (otroan)
Ray, > I suspect the Maintainers versus Committers description was included for my > benefit :-) Most definitely not! :-) Agreeing on the right words to use for something is half the battle. > My 2c is that my experience of this model is that maintainers typically get > frustrated and disillu