Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Florin Coras
Thanks! Cheers, Florin > On Jan 15, 2021, at 4:49 PM, Ivan Shvedunov wrote: > > https://gerrit.fd.io/r/c/vpp/+/30791 > > On Sat, Jan 16, 2021 at 3:22 AM Florin Coras > wrote: > Hi Ivan, > > You’re right that the assert w

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Ivan Shvedunov
https://gerrit.fd.io/r/c/vpp/+/30791 On Sat, Jan 16, 2021 at 3:22 AM Florin Coras wrote: > Hi Ivan, > > You’re right that the assert wrongly assumes the connection must’ve been > established. I’m guessing you’re only sporadically hitting it because > typically the peer should not retransmit the

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Ivan Shvedunov
Hi, thanks, I’ll prepare the patch in a moment On Sat, 16 Jan 2021 at 03:22, Florin Coras wrote: > Hi Ivan, > > You’re right that the assert wrongly assumes the connection must’ve been > established. I’m guessing you’re only sporadically hitting it because > typically the peer should not retrans

Re: [vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Florin Coras
Hi Ivan, You’re right that the assert wrongly assumes the connection must’ve been established. I’m guessing you’re only sporadically hitting it because typically the peer should not retransmit the syn after our reset (but probably the packet is lost). Want to push a patch to remove it or shou

[vpp-dev] Assertion failure on half-open connection pending cleanup

2021-01-15 Thread Ivan Shvedunov
Hi, in our UPG project[1] I'm sometimes hitting the following assertion in tcp[46]-syn-sent when trying to use at least 1 worker thread: https://github.com/FDio/vpp/blob/35ef865678d82b5a6fd3936716de8afb2fd49e60/src/vnet/tcp/tcp_input.c#L1820-L1821 We're using the host stack in a rather non-standar

Re: [vpp-dev] how to allocate new buffer correctly

2021-01-15 Thread Damjan Marion via lists.fd.io
This looks right (except the wrong assumption that vlib_get_frame_to_node will give you empty frame). What happens between this code and error-drop node? Is interface TX also your custom code? — Damjan > On 15.01.2021., at 17:03, Stanislav Zaikin wrote: > > Hello, > > I'm trying to rein

[vpp-dev] how to allocate new buffer correctly

2021-01-15 Thread Stanislav Zaikin
Hello, I'm trying to reincarnate router plugin. But I stuck with a pretty simple thing, when I need to allocate a buffer to store a packet from a tap device, everything is going well. But when the next node decides to free this buffer I get a clib_error. Basically, code is pretty simple and strai