Re: [vpp-dev] VPP Device jobs randomly failing

2020-12-02 Thread Juraj Linkeš
It happens in CI on x86 as well (with the older PF driver), but I didn't reproduce it manually, since I did't want to touch x86 hardware in production (x86 is running voting jobs, aarch64 is running non-voting, so aarch64 is a bit safer to tinker with). Juraj From: vpp-dev@lists.fd.io On Beha

Re: [vpp-dev] vppcom and binary api #binapi #vapi #vppcom

2020-12-02 Thread Florin Coras
Hi Ravi, By default, vcl relies on the binary api to attach to the session layer in vpp. It is possible to initialize another binary api connection from your app, apart from the one transparently created by vcl, but it requires some careful non-default initialization of a series of data struct

[vpp-dev] vppcom and binary api #binapi #vapi #vppcom

2020-12-02 Thread RaviKiran Veldanda
Hi Team, We have our application which uses VPPCOM sessions to read and write some packets. We have one more requirement that Application uses Vpp-binary api and provide some information to our own plugin. When we try calling this binary apis without VPPCOM session started or running, the VPP Bi

Re: [vpp-dev] multicast traffic getting duplicated in lacp bond mode

2020-12-02 Thread steven luong via lists.fd.io
Bonding cares less whether the traffic is unicast or multicast. It just hashes the packet header and selects one of the members as the outgoing interface. The only bonding mode which it replicates packets across all members is when you create the bonding interface to do broadcast which you didn’

Re: [vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-02 Thread Mrityunjay Kumar
Guys, I am not sure , my input is helpful or not but the same issue was triggered to me and we concluded it in a different way. In your packet trace , it seems pkt is triggering to vpp node ip4-sv-reassembly-feature. I suggest first try to enable reassembly on the interface, *set interface reassem

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Andrew Yourtchenko
> On 2 Dec 2020, at 20:07, Paul Vinciguerra wrote: > >  > > >> On Wed, Dec 2, 2020 at 1:12 PM Andrew 👽 Yourtchenko >> wrote: >> s/Got doesn’t have/Git doesn’t have/ >> >> (iPhone autocorrect, sorry) >> >> --a >> On 2 Dec 2020, at 19:01, Andrew Yourtchenko via lists.fd.io wro

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
On Wed, Dec 2, 2020 at 1:12 PM Andrew 👽 Yourtchenko wrote: > s/Got doesn’t have/Git doesn’t have/ > > (iPhone autocorrect, sorry) > > --a > > On 2 Dec 2020, at 19:01, Andrew Yourtchenko via lists.fd.io gmail@lists.fd.io> wrote: > >  > > On 2 Dec 2020, at 18:21, Paul Vinciguerra > wrote: >

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Andrew Yourtchenko
s/Got doesn’t have/Git doesn’t have/ (iPhone autocorrect, sorry) --a > On 2 Dec 2020, at 19:01, Andrew Yourtchenko via lists.fd.io > wrote: > >  > >>> On 2 Dec 2020, at 18:21, Paul Vinciguerra >>> wrote: >>> >>  >> >> >>> On Wed, Dec 2, 2020 at 10:57 AM Andrew 👽 Yourtchenko >>> wrot

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Andrew Yourtchenko
> On 2 Dec 2020, at 18:21, Paul Vinciguerra wrote: > >  > > >> On Wed, Dec 2, 2020 at 10:57 AM Andrew 👽 Yourtchenko >> wrote: >> >> On 2 Dec 2020, at 16:42, Paul Vinciguerra wrote: >>>  >>> >>> On Wed, Dec 2, 2020 at 5:38 AM Andrew 👽 Yourtchenko wrote: >>

Re: [vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-02 Thread Klement Sekera via lists.fd.io
Hi Elias, so there are two ways of solving this: 1. don’t support such a static mapping (i.e. refuse to create it) 2. make it work for #2 your snat_hairpinning fix might be the right idea. If there is really no change then there is no point doing an extra lookup right? Would you mind pushing i

Re: [vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-02 Thread Elias Rudberg
Hi Klement, > > an existing static NAT mapping that maps that IP address on the > > inside to the same IP address on the outside. > what is the point of such static mapping? What is the use case here? We are using VPP for endpoint-independent NAT44. Then all traffic from outside is normally tran

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
On Wed, Dec 2, 2020 at 10:57 AM Andrew 👽 Yourtchenko wrote: > > > On 2 Dec 2020, at 16:42, Paul Vinciguerra > wrote: > >  > > > On Wed, Dec 2, 2020 at 5:38 AM Andrew 👽 Yourtchenko > wrote: > >> >> >> > On 2 Dec 2020, at 10:38, Klement Sekera via lists.fd.io > cisco@lists.fd.io> wrote: >> >

Re: [vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-02 Thread Klement Sekera via lists.fd.io
Hi Elias, what is the point of such static mapping? What is the use case here? Thanks, Klement > On 2 Dec 2020, at 16:39, Elias Rudberg wrote: > > One scenario when this happens is when a UDP (or TCP) packet is sent > from a client on the inside with a destination IP address that matches > an

Re: [vpp-dev] Vpp crashes with core dump vhost-user interface

2020-12-02 Thread Eyle Brinkhuis
Hi Ben, all, I’m sorry, I forgot about adding a backtrace. I have now posted it here: https://surfdrive.surf.nl/files/index.php/s/0SUKUNivkpg9Dnb I am not too familiar with the openstack integration, but now that 20.09 is out, can't you move to 20.09? At least in your lab to check whether you st

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Andrew Yourtchenko
> On 2 Dec 2020, at 16:42, Paul Vinciguerra wrote: > >  > > >> On Wed, Dec 2, 2020 at 5:38 AM Andrew 👽 Yourtchenko >> wrote: >> >> >> > On 2 Dec 2020, at 10:38, Klement Sekera via lists.fd.io >> > wrote: >> > >> > I like the idea. >> > >> > Regarding maintainer pain: >> > >> > Q:

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Damjan Marion via lists.fd.io
Yes, but still you need to submit patch with whitespace changes. Point is that that makes cherry-picking, back-porting PITA. — Damjan > On 02.12.2020., at 16:02, Paul Vinciguerra wrote: > > Hi Damjan. > > From their docs. > Migrating your code style without ruining git blame > A long-standin

Re: [vpp-dev] VPP Device jobs randomly failing

2020-12-02 Thread Damjan Marion via lists.fd.io
I doubt changing anything around vfio-pci will help. That module doesn’t participate in communication between PF and VF. Indeed, this looks like a PF driver bug. This is on AArch64, right? Are you able to repro on x86? — Damjan On 02.12.2020., at 14:44, Juraj Linkeš mailto:juraj.lin...@panth

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
On Wed, Dec 2, 2020 at 5:38 AM Andrew 👽 Yourtchenko wrote: > > > > On 2 Dec 2020, at 10:38, Klement Sekera via lists.fd.io cisco@lists.fd.io> wrote: > > > > I like the idea. > > > > Regarding maintainer pain: > > > > Q: are we now stuck forever with what we have because there will always >

[vpp-dev] VPP hanging and running out of memory due to infinite loop related to nat44-hairpinning

2020-12-02 Thread Elias Rudberg
Hello VPP experts, For our NAT44 usage of VPP we have encountered a problem with VPP running out of memory, which now, after much headache and many out-of- memory crashes over the past several months, has turned out to be caused by an infinite loop where VPP gets stuck repeating the three nodes ip

Re: [vpp-dev] Vpp crashes with core dump vhost-user interface

2020-12-02 Thread Benoit Ganne (bganne) via lists.fd.io
Hi Eyle, I am not too familiar with the openstack integration, but now that 20.09 is out, can't you move to 20.09? At least in your lab to check whether you still see this issue. Apart from that, we'd need to decipher the backtrace to be able to help. The best should be to share a coredump as e

Re: [vpp-dev] Vpp crashes with core dump vhost-user interface

2020-12-02 Thread steven luong via lists.fd.io
Please use gdb to provide a meaningful backtrace. Steven From: on behalf of Eyle Brinkhuis Date: Wednesday, December 2, 2020 at 5:59 AM To: "vpp-dev@lists.fd.io" Subject: [vpp-dev] Vpp crashes with core dump vhost-user interface Hi all, In our environment (vpp 20.05.1, ubuntu 18.04.5, networ

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
Copying the list this time ;) > Has to be 2.23 or greater. > > On Wed, Dec 2, 2020 at 4:15 AM Andrew 👽 Yourtchenko > wrote: > >> Can git in any version ignore the massive white space changes while >> cherry-picking / merging? >> If not - this sounds like a *massive* inconvenience to anyone not s

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
Hi Damjan. >From their docs. Migrating your code style without ruining git blame A long-standing argument against moving to automated code formatters like *Black* is that the migration will clutter up the output of git blame. This was a valid argument, but since Git version 2.23, Git natively sup

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
Hi Neale, The problem with that code in general is that the delayed binding with papi means that you have to manually ensure that you only reference it *after* papi has been initialized. The other alternative is to put them in a lambda or @property, so they are evaluated at the time of use instea

[vpp-dev] Vpp crashes with core dump vhost-user interface

2020-12-02 Thread Eyle Brinkhuis
Hi all, In our environment (vpp 20.05.1, ubuntu 18.04.5, networking-vpp 20.05.1, Openstack train) we are running into an issue. When we spawn a VM (regular ubuntu 1804.4) with 16 CPU cores and 8G memory and a VPP backed interface, our VPP instance dies: Dec 02 13:39:39 compute03-asd002a vpp[17

Re: [vpp-dev] VPP Device jobs randomly failing

2020-12-02 Thread Juraj Linkeš
Updating to the latest PF version (2.13.10) did not help. I'm seeing the same failures. We'll tank about other options in the CSIT calls, things like whether it makes sense to try newer firmware or vfio-pci versions. Juraj From: vpp-dev@lists.fd.io On Behalf Of Juraj Linkeš Sent: Wednesday, De

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Andrew Yourtchenko
> On 2 Dec 2020, at 10:38, Klement Sekera via lists.fd.io > wrote: > > I like the idea. > > Regarding maintainer pain: > > Q: are we now stuck forever with what we have because there will always be > somebody facing some difficulties adopting? To me it is always a question of cost/benefi

[vpp-dev] FOSDEM 2021 SDN Devroom CFP

2020-12-02 Thread Ray Kinsella
We are pleased to announce the Call for Participation for the FOSDEM 2021 Software Defined Networking devroom! FOSDEM is a free event for software developers to meet, share ideas and collaborate. - FOSDEM is free to attend. There is no registration. - FOSDEM website: http://www.fosdem.org/ - FOSDE

Re: [vpp-dev] VPP Device jobs randomly failing

2020-12-02 Thread Juraj Linkeš
I've looked into this a bit more and I'm seeing an error with avf in logs, but that actually doesn't impact VPP negatively: 2020/12/02 09:36:48:219 error avf:05:10.0: send_to_pf failed (timeout 1.269s) And a different log: 2020/12/02 09:36:47:176 error avf000

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Damjan Marion via lists.fd.io
I agree. Smarter "git blame” will not help with massive whitespace change. >From a perspective of non-python coder I really don’t like where this is going >on. Every time I tried to make simple change in tests ended up with dealing with un-readable python code and PEPs - whatever that means.

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Klement Sekera via lists.fd.io
I like the idea. Regarding maintainer pain: Q: are we now stuck forever with what we have because there will always be somebody facing some difficulties adopting? Thanks, Klement > On 2 Dec 2020, at 10:30, Andrew Yourtchenko wrote: > >> >> On 2 Dec 2020, at 10:27, Neale Ranns via lists.fd.

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Damjan Marion via lists.fd.io
> On 01.12.2020., at 23:55, Paul Vinciguerra wrote: > > The question is whether the community wants to upgrade their version of git > to ignore this change with git blame, in exchange for not having to manually > lint/fix their files. Can you please explain how new version of git helps here?

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Andrew Yourtchenko
> On 2 Dec 2020, at 10:27, Neale Ranns via lists.fd.io > wrote: > >  > > Hi Paul, > > Having to write code to conform to python linting is my number 1 annoyance > when writing tests. This is my usual hack: > e = VppEnum.vl_api_tunnel_encap_decap_flags_t > f = e.TUNNEL_API_ENCAP_DECAP_FLAG

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Neale Ranns via lists.fd.io
Hi Paul, Having to write code to conform to python linting is my number 1 annoyance when writing tests. This is my usual hack: e = VppEnum.vl_api_tunnel_encap_decap_flags_t f = e.TUNNEL_API_ENCAP_DECAP_FLAG_ENCAP_COPY_DSCP I support having an auto-linter. I have no knowledge about what’s av

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Andrew Yourtchenko
Can git in any version ignore the massive white space changes while cherry-picking / merging? If not - this sounds like a *massive* inconvenience to anyone not sitting on the head of master, which is a lot of folks. At least that is why it’s still on my WIP to deal with the C code indent... big