[vpp-dev] unable to see tcp connection syn packets in tcpdump

2020-07-15 Thread sadhanakesavan
hi team, if i use  here : https://wiki.fd.io/view/VPP/HostStack/LDP/iperf and a linux client , i cannot see tcp connection establishment. is this expected. should i necesarily use vpp client? client:- nc 10.10.1.2 5201 server:- sudo taskset --cpu-list 1 sh -c "LD_PRELOAD=$LDP_PATH VCL_CONFIG=$V

[vpp-dev] VPP 20.05.1 Maintenance Release is complete!

2020-07-15 Thread Andrew Yourtchenko
Dear all, The VPP maintenance release 20.05.1 is complete and artifacts are available in packagecloud fdio/release repository. Thanks a lot to Vanessa Valderrama and Dave Wallace for the help! --a Your friendly 20.05 release manager -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to

Re: [vpp-dev] Crash in ACL code while applying rulematch

2020-07-15 Thread Andrew Yourtchenko
Hi Satya, Yeah so I suspect since the updates were never MP-safe, they required the workers getting the barrier; so the condition I speculated about in my other mail won’t have occurred... (I am still puzzled by why you see no problem if updating for only one worker, so not sure if that theory

Re: [vpp-dev] Crash in ACL code while applying rulematch

2020-07-15 Thread Andrew Yourtchenko
That said, my theory is that you are in the loop of bihash searches in one worker (that eventually crashes), while deleting the ACLs from another one, and with larger amount of data the probability is higher that at the moment of the hash lookup the vector is still there, but at the moment of

Re: [vpp-dev] Crash in ACL code while applying rulematch

2020-07-15 Thread Satya Murthy
Hi Andrew, Thanks for the quick response. All the activity that we are performing with ACLs, like , add and delete of ACLs from multiple workers, we are doing by taking a lock. This will ensure that no two workers will be able to operate on ACLs at the same time. Is there any specific restrict

Re: [vpp-dev] Crash in ACL code while applying rulematch

2020-07-15 Thread Andrew Yourtchenko
“ One more thing is this crash is happening only when we add acl rules and lookup contexts from multiple workers.” - you should not be doing that from any workers, let alone multiple. The manipulations with ACLs and lookup contexts are considered to be control plane activity, thus should be per

[vpp-dev] Crash in ACL code while applying rulematch

2020-07-15 Thread Satya Murthy
Hi , We are seeing a crash when we are trying to do ACL rulematch within a lookup context. #0  0x7f7786498ca0 in multi_acl_match_get_applied_ace_index (am=0x7f77866caa00 , is_ip6=0, match=0x7f7791fff610) at src/plugins/acl/public_inlines.h:625 #1  0x7f7786498f27 in hash_multi_acl_match_

Re: [vpp-dev] VPP 20.05.1 tomorrow 15th July 2020

2020-07-15 Thread Chris Luke
To clarify, committers are the only ones who can approve and merge changes, to any of the maintained branches. Any contributor can propose changes to any open branch, and a cherry-pick is just a proposed change that happens to be a (rebased) copy of another change. Chris. -Original Message

Re: [vpp-dev] VPP 20.05.1 tomorrow 15th July 2020

2020-07-15 Thread Andrew Yourtchenko
Hi Elias, > On 15 Jul 2020, at 13:29, Elias Rudberg wrote: > > Hi Andrew, > > I don't know how to cherry-pick. I was under the impression that only > the trusted commiters were allowed to do that, maybe I misunderstood > that. One option is to have your local git on the target branch, and fro

Re: [vpp-dev] VPP 20.05.1 tomorrow 15th July 2020

2020-07-15 Thread Elias Rudberg
Hi Andrew, I don't know how to cherry-pick. I was under the impression that only the trusted commiters were allowed to do that, maybe I misunderstood that. What I know so far about the gerrit system is what I read here: https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_

Re: [vpp-dev] VPP 20.05.1 tomorrow 15th July 2020

2020-07-15 Thread Andrew Yourtchenko
> On 15 Jul 2020, at 12:47, Dave Barach (dbarach) wrote: > > This one is definitely safe, and worth including: > https://gerrit.fd.io/r/c/vpp/+/27281 Ok i will count your mail as a “+1” then - cherry picked it and will merge myself when JJB is happy What about 27280 ? I guess from the

Re: [vpp-dev] VPP 20.05.1 tomorrow 15th July 2020

2020-07-15 Thread Dave Barach via lists.fd.io
This one is definitely safe, and worth including: https://gerrit.fd.io/r/c/vpp/+/27281 -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Andrew Yourtchenko Sent: Wednesday, July 15, 2020 6:27 AM To: Elias Rudberg Cc: vpp-dev@lists.fd.io; dwallac...@gmail.com Subject: Re: [vpp-de

Re: [vpp-dev] VPP 20.05.1 tomorrow 15th July 2020

2020-07-15 Thread Andrew Yourtchenko
Hi Elias, sure, feel free to cherry-pick to stable/2005 branch and add me as a reviewer, then I can merge when JJB gives thumbs up. --a > On 15 Jul 2020, at 07:25, Elias Rudberg wrote: > > Hello Andrew, > > The following two fixes have been merged to the master branch, it would > be good to