Re: [vpp-dev] VPP C API application compilation issue on using S and W functions

Hi Ole, As suggested by you, we are trying vapi for our SRv6 use case, we were able to generate sr.api.json for sr.api using src/tools/vppapigen/generate_json.py. We then generated sr.api.vapi.h using src/vpp-api/vapi/vapi_c_gen.py. On going through sr.api.vapi.h, we found a function *vapi_set_

Re: [vpp-dev] name filter fix in 1908

Hi Christian, Ok so given it’s a fix, feel free to cherry-pick into 19.08 without the API version change, I will merge it. --a > On 30 Jun 2020, at 15:52, Ole Troan wrote: > > Hi Christian, > > Changing the patch is fine. > The only use of version apart from human indications is for the is

Re: [vpp-dev] name filter fix in 1908

Hi Christian, Changing the patch is fine. The only use of version apart from human indications is for the is api experimental or not by checkstyle-api Cheers Ole > On 30 Jun 2020, at 15:38, Christian Hopps wrote: > > I noticed that it was the "patch" version number that changed. Semver c

Re: [vpp-dev] name filter fix in 1908

I noticed that it was the "patch" version number that changed. Semver claims the patch number indicates backwards compatible changes -- not sure how VPP API is using the "patch" number though. So when I resolved the conflict locally after cherry picking I just changed 3.1.1 to 3.1.2 to keep the

Re: [vpp-dev] classify table, mask flow-label, version, and traffic-class NOT working #classify #vnet

Patch on the way, thanks for the report. From: vpp-dev@lists.fd.io On Behalf Of mauricio.solisjr via lists.fd.io Sent: Tuesday, June 30, 2020 7:53 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] classify table, mask flow-label, version, and traffic-class NOT working #classify #vnet Hi I've been

Re: [vpp-dev] name filter fix in 1908

Dear Chris, In looking at the patch, I have a question: the API version number changed despite the fact that the API itself was unchanged. Should we revert the API version number bump and then cherry-pick to 19.08? Looping in Ole for an opinion... Thanks... Dave -Original Message- F

[vpp-dev] classify table, mask flow-label, version, and traffic-class NOT working #classify #vnet

Hi I've been trying to add a classify table using the following CLI: classify table miss-next ip6-node ip6-lookup mask l3 ip6 flow-label I noticed that in src/vnet/classify/vnet_classify.c the following lines cause the function "uword unformat_ip6_mask(...)" to return earlier than expected and n

[vpp-dev] name filter fix in 1908

Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140 be pulled into stable/1908? It applies clean after adapting the version number change to be compatible with 1908 branch. Thanks, Chris. signature.asc Description: Message signed with OpenPGP -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all me