[vpp-dev] API downgrade: plugins - abf (ACL-based forwarding), gbp (Group Based Policy), l2e (LAN Emulation)

Hi all, Neale asked me to help with the API downgrade process for these three plug-ins, as he considers their API not ready to be considered production within the new process, so this is a notification to that effect. If you have any comments/concerns, feel free to comment on the respective gerri

Re: [vpp-dev] Issue while pushing code for gerrit review

'make install-dep' also installs the .git_commit_template.txt Thanks, -daw- On 6/24/2020 4:57 AM, Ole Troan wrote: Type: fix needs to be on a separate line. Take a look at other commit messages for examples. Or use the template in .git_commit_template.txt git config commit.template .git_comm

Re: [vpp-dev] test/requirements-3.txt snnoyance

Ah looks good to me :) “dependency != Boolean flag” :) I will let Damjan +2 if he is happy with it. --a > On 24 Jun 2020, at 11:37, Aloys Augustin (aloaugus) > wrote: > > Hi folks, > > Does https://gerrit.fd.io/r/c/vpp/+/27657 fix this? > > Best, > Aloÿs > >> On 24 Jun 2020, at 09:08, And

Re: [vpp-dev] Issue while pushing code for gerrit review

Its working now, Thanks. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16808): https://lists.fd.io/g/vpp-dev/message/16808 Mute This Topic: https://lists.fd.io/mt/75076228/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.i

Re: [vpp-dev] test/requirements-3.txt snnoyance

Hi folks, Does https://gerrit.fd.io/r/c/vpp/+/27657 fix this? Best, Aloÿs > On 24 Jun 2020, at 09:08, Andrew Yourtchenko wrote: > > I will take a look and report... > > --a > >> On 23 Jun 2020, at 18:27, Damjan Marion via lists.fd.io >> wrote: >> >>

Re: [vpp-dev] Issue while pushing code for gerrit review

> Type: fix needs to be on a separate line. Take a look at other commit > messages for examples. Or use the template in .git_commit_template.txt git config commit.template .git_commit_template.txt Ole > >> On 24 Jun 2020, at 10:42, Chinmaya Aggarwal wrote: >> >> Still not working for me. I

Re: [vpp-dev] Issue while pushing code for gerrit review

Type: fix needs to be on a separate line. Take a look at other commit messages for examples. > On 24 Jun 2020, at 10:42, Chinmaya Aggarwal wrote: > > Still not working for me. I executed > git commit -s --amend -m 'Type: fix sr: fix for SID index across segment > lists within a sr policy' >

Re: [vpp-dev] Issue while pushing code for gerrit review

Still not working for me. I executed git commit -s --amend -m 'Type: fix sr: fix for SID index across segment lists within a sr policy' But still git log shows commit a3c7df5131c9905a209cee017e80fdff6b5b2e6e (HEAD -> review/chinmaya_agarwal/fix/vpp_topic_74477804) Author: Chinmaya Agarwal Date:

Re: [vpp-dev] Issue while pushing code for gerrit review

Hi, just amend the commit message and add it by hand. Commit message must contain a line like Type: fix or Type: improvement or whatever is applicable. Regards, Klement > On 24 Jun 2020, at 10:31, Chinmaya Aggarwal wrote: > > After i commit my fix, i run the script ./extras/scripts/check

Re: [vpp-dev] Issue while pushing code for gerrit review

After i commit my fix, i run the script ./extras/scripts/check_commit_msg.sh and it gives me error : - root@ggnlabvm-hnsnfvsdn03:~/vpp# ./extras/scripts/check_commit_msg.sh === ERROR === Unknown commit type '' in commit message body. Commit m

Re: [vpp-dev] test/requirements-3.txt snnoyance

I will take a look and report... --a > On 23 Jun 2020, at 18:27, Damjan Marion via lists.fd.io > wrote: > > Folks, > > Every time I run “make test”, i need to deal with modifications in > test/requirements-3.txt > > Even worse, if I do “git checkout -f”, i cannot run “make test” anymore u