Re: [vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

Thanks, I have a look at the patch, I think the same action should take at state FIN_WAIT_1 and FIN_WAIT_2 . At 2019-06-29 00:53:15, "Florin Coras" wrote: Hi, Well, yes. VPP tcp won’t send out of order fins because it waits for all the data to be acked before sending the fin. Still, oth

Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

Thanks. At 2019-06-29 00:52:21, "Florin Coras" wrote: Here’s the patch [1]. Thanks, Florin [1] https://gerrit.fd.io/r/c/20404/ On Jun 28, 2019, at 7:54 AM, guangwei wrote: Yes, please fixed it, I'am just searching the code, no environment to verify it. At 2019-06-28 22:45:23

Re: [vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

Hi, Well, yes. VPP tcp won’t send out of order fins because it waits for all the data to be acked before sending the fin. Still, others may do it, so here’s a quick fix for that [1]. Thanks, Florin [1] https://gerrit.fd.io/r/c/20403/ > On Jun 28, 2019, at

Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

Here’s the patch [1]. Thanks, Florin [1] https://gerrit.fd.io/r/c/20404/ > On Jun 28, 2019, at 7:54 AM, guangwei wrote: > > Yes, please fixed it, I'am just searching the code, no environment to verify > it. > > > > At 2019-06-28 22:45:23, "Florin Coras"

Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

Yes, please fixed it, I'am just searching the code, no environment to verify it. At 2019-06-28 22:45:23, "Florin Coras" wrote: >Hi, > >That is correct. You want to provide the patch or should I do it? > >Thanks, >Florin > >> On Jun 28, 2019, at 6:10 AM, guangwei wrote: >> >> Now, I'am sear

Re: [vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

Hi, That is correct. You want to provide the patch or should I do it? Thanks, Florin > On Jun 28, 2019, at 6:10 AM, guangwei wrote: > > Now, I'am searching the TCP stack of VPP 19.04, and have a doubt, please look > following comment in line. > > tcp46_rcv_process_inline > { > ... >

[vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

I think the FIN is reported to session layer only when it's indeed all the data which allowed in SEQ window has received, but from code, when the packet flaged with FIN no matter whether it's a Out-Of-Order segment or not , no matter whether it's data all in the allowed window or not, the stack

Re: [vpp-dev] Checking for enabled feature

Seems like your code is OK, see also vnet_interface_features_show(...) in .../src/vnet/feature/feature.c. We could add per-interface, per-feature arc "feature X is enabled" bitmaps to speed up this sort of processing, but there has to be a compelling reason to do so. What problem are you try

Re: [vpp-dev] Checking for enabled feature

Hi Raj, There's no good way to do it, there's also no notification should the feature be disabled or enabled. Instead I'd suggest you 'listen' to the entity enabling/disabling the feature. Or maybe you can configure your feature to run before this one, then it's not important whether it's enabl

[vpp-dev] A question about TCP statck in version 19.04, when passive FIN coming in first, then APP close with TX fifo not empty, it seem can't have chance to send FIN out. #vnet

Now, I'am searching the TCP stack of VPP 19.04, and have a doubt, please look following comment in line. tcp46_rcv_process_inline { ... /* 5: check the ACK field  */ ... case TCP_STATE_CLOSE_WAIT: /* Do the same processing as for the ESTABLISHED state. */ if (tcp_rcv_ack (wrk, tc0, b0, tcp0, &err

[vpp-dev] Checking for enabled feature

Hello all, I am in need to find out whether a particular feature is enabled on an interface during run time. So if I understand correctly we have to get the corresponding 'feature arc index '. Then get the config index by using 'config_index_by_sw_if_index' then get the config_pool and then itera