Re: [vpp-dev] ip-rewrite bug?

2019-03-05 Thread Kingwel Xie
Thanks. Look forward to the fix… From: Dave Barach (dbarach) Sent: Tuesday, March 05, 2019 8:25 PM To: Kingwel Xie ; vpp-dev@lists.fd.io Subject: RE: ip-rewrite bug? Let’s try to fix the underlying code in vnet_rewrite_one_header, and friends. The code already checks for the magic rewrite lengt

Re: [vpp-dev] Build failure question

2019-03-05 Thread Thomas F Herbert
On 03/05/2019 09:40 AM, Damjan Marion wrote: On 5 Mar 2019, at 15:14, Thomas F Herbert > wrote: On 03/05/2019 02:37 AM, Damjan Marion wrote: On 4 Mar 2019, at 22:52, Thomas F Herbert > wrote: Damjan et. al. I get build failures

Re: [vpp-dev] Build failure question

2019-03-05 Thread Damjan Marion via Lists.Fd.Io
> On 5 Mar 2019, at 15:14, Thomas F Herbert wrote: > > > > > On 03/05/2019 02:37 AM, Damjan Marion wrote: >> >> >>> On 4 Mar 2019, at 22:52, Thomas F Herbert >> > wrote: >>> >>> Damjan et. al. >>> >>> I get build failures when builging from a tarball outside

Re: [vpp-dev] Build failure question

2019-03-05 Thread Thomas F Herbert
On 03/05/2019 02:37 AM, Damjan Marion wrote: On 4 Mar 2019, at 22:52, Thomas F Herbert > wrote: Damjan et. al. I get build failures when builging from a tarball  outside of git tree on 19.01 I documented this in https://jira.fd.io/browse/VPP-1577 This is not

[vpp-dev] NAT New Node Registration

2019-03-05 Thread emma sdi
Hi Dear VPP I need to perform out2in nat operation before input-acl, so I'm trying to register new node as below: - plugins/nat/nat.c: VNET_FEATURE_INIT (ip4_snat_out2in_input, static) = { .arc_name = "ip4-unicast", .node_name = "nat44-out2in-input", .runs_befor

Re: [vpp-dev] ip-rewrite bug?

2019-03-05 Thread Dave Barach via Lists.Fd.Io
Let’s try to fix the underlying code in vnet_rewrite_one_header, and friends. The code already checks for the magic rewrite length 14. Anyhow, the header-rewrite scheme hasn’t had a serious performance tuning pass in a long time. Since it’s used everywhere, shaving a couple of clock cycles from

[vpp-dev] ip-rewrite bug?

2019-03-05 Thread Kingwel Xie
Hi vpp-dev, I’m looking at the ip-rewrite node, and I think it might be a bug at: vnet_rewrite_one_header (adj0[0], ip0, sizeof (ethernet_header_t)); The adj-> rewrite_header.data_bytes might be 0 when it comes to tunnel interface, f.g., gtpu, ipsec. Thus, at least 8 bytes garbage are written t