RE: [PATCH vhost] virtio_ring: fix syncs DMA memory with different direction

2023-11-30 Thread Parav Pandit
3245,7 @@ void > virtqueue_dma_sync_single_range_for_device(struct virtqueue *_vq, > if (!vq->use_dma_api) > return; > > - dma_sync_single_range_for_device(dev, addr, offset, size, > - DMA_BIDIRECTIONAL); > + dma_sync_single_range_for_device(dev, addr, offset, size, dir); > } > EXPORT_SYMBOL_GPL(virtqueue_dma_sync_single_range_for_device); > > -- > 2.32.0.3.g01195cf9f > Reviewed-by: Parav Pandit

RE: [RFC] Revert "virtio_pci: Support surprise removal of virtio pci

2024-01-11 Thread Parav Pandit
> From: Li,Rongqing > Sent: Thursday, January 11, 2024 2:45 PM > > Revert "virtio_pci: Support surprise removal of virtio pci device" > > This reverts commit 43bb40c5b92659966bdf4bfe584fde0a3575a049. > > Marking the device as broken will cause the uncompleted IO request on > virtio-blk since

RE: [RFC] Revert "virtio_pci: Support surprise removal of virtio pci

2024-01-11 Thread Parav Pandit
> From: Li,Rongqing > Sent: Thursday, January 11, 2024 5:18 PM > > > > -Original Message----- > > From: Parav Pandit > > Sent: Thursday, January 11, 2024 6:18 PM > > To: Li,Rongqing ; m...@redhat.com; > > jasow...@redhat.com; xuanz...@linux.aliba

RE: [RFC] Revert "virtio_pci: Support surprise removal of virtio pci

2024-01-11 Thread Parav Pandit
> From: Li,Rongqing > Sent: Thursday, January 11, 2024 5:28 PM > > > > -Original Message----- > > From: Parav Pandit > > Sent: Thursday, January 11, 2024 7:55 PM > > To: Li,Rongqing ; m...@redhat.com; > > jasow...@redhat.com; xuanz...@linux.aliba

RE: [RFC] Revert "virtio_pci: Support surprise removal of virtio pci

2024-01-11 Thread Parav Pandit
> From: Li,Rongqing > Sent: Friday, January 12, 2024 7:59 AM > > > > > diff --git a/drivers/virtio/virtio_pci_common.c > > > b/drivers/virtio/virtio_pci_common.c > > > index 7a55939..d60fe99 100644 > > > --- a/drivers/virtio/virtio_pci_common.c > > > +++ b/drivers/virtio/virtio_pci_common.c >

RE: [PATCH] ifcvf/vDPA: ifcvf drives standard virtio pci devices

2024-05-13 Thread Parav Pandit
Hi Lingshan, > From: Zhu Lingshan > Sent: Tuesday, May 14, 2024 2:57 AM > To: jasow...@redhat.com; m...@redhat.com > Cc: virtualization@lists.linux.dev; Zhu Lingshan > Subject: [PATCH] ifcvf/vDPA: ifcvf drives standard virtio pci devices > > Most of ifcvf code work for standard virtio pci, exce

RE: [PATCH] ifcvf/vDPA: ifcvf drives standard virtio pci devices

2024-05-13 Thread Parav Pandit
> From: Zhu, Lingshan > Sent: Tuesday, May 14, 2024 6:58 AM > > On 5/13/2024 9:36 PM, Parav Pandit wrote: > > Hi Lingshan, > > > >> From: Zhu Lingshan > >> Sent: Tuesday, May 14, 2024 2:57 AM > >> To: jasow...@redhat.com; m...@redhat.com &g

RE: [PATCH virtio 0/8] virtio_pci_modern: allow parallel admin queue commands execution

2024-06-24 Thread Parav Pandit
> From: Jiri Pirko > Sent: Tuesday, June 25, 2024 12:08 PM > I'm working on a fallback where admin queue and cvq would share config > vector. Lets see. Cvq or avq resulting in performing more MMIO reads of the config space is not good. CVQ and AVQ sharing irq is good, but it should not share

RE: [PATCH virtio 0/8] virtio_pci_modern: allow parallel admin queue commands execution

2024-06-25 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, June 25, 2024 12:51 PM > > On Tue, Jun 25, 2024 at 10:11:26AM +0800, Heng Qi wrote: > > On Mon, 24 Jun 2024 11:16:45 -0400, "Michael S. Tsirkin" > wrote: > > > On Mon, Jun 24, 2024 at 04:51:37PM +0200, Jiri Pirko wrote: > > > > Mon, Jun 24, 2024 at 0

RE: [PATCH virtio 7/8] virtio_pci_modern: use completion instead of busy loop to wait on admin cmd result

2024-06-25 Thread Parav Pandit
> From: Jiri Pirko > Sent: Tuesday, June 25, 2024 4:37 PM [..] > >So if you are changing that to a completion, I think surprise removal > >needs to trigger a callback so the completion can be signalled. > > What exacly do you mean by "surprise removal"? PCI devices can be removed from the PC

RE: [PATCH virtio v2 10/13] virtio_pci_modern: create admin queue of queried size

2024-07-14 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Sunday, July 14, 2024 1:25 PM > > On Wed, Jul 10, 2024 at 08:35:58AM +0200, Jiri Pirko wrote: > > From: Jiri Pirko > > > > Don't limit the admin queue size to VIRTIO_AVQ_SGS_MAX and rather rely > > on the queried queue size. > > > > Signed-off-by: Jiri Pirko

RE: [PATCH vfio 0/7] Enhances the vfio-virtio driver to support live migration

2024-11-03 Thread Parav Pandit
> From: Alex Williamson > Sent: Friday, November 1, 2024 9:55 PM > > On Thu, 31 Oct 2024 15:04:51 +0000 > Parav Pandit wrote: > > > > From: Alex Williamson > > > Sent: Wednesday, October 30, 2024 1:58 AM > > > > > > On Mon

RE: [PATCH V3] vp_vdpa: fix id_table array not null terminated error

2024-11-05 Thread Parav Pandit
pa : add vdpa tool support in vp_vdpa") > Cc: sta...@vger.kernel.org > Suggested-by: Parav Pandit > Signed-off-by: Angus Chen > Signed-off-by: Xiaoguang Wang > --- > V3: > Use array assignment style for mdev_id. > V2: > Use kcalloc() api. > --- > drivers/vdpa/v

RE: [PATCH] vp_vdpa: fix id_table array not null terminated error

2024-10-30 Thread Parav Pandit
> From: Xiaoguang Wang > Sent: Thursday, October 31, 2024 9:35 AM > > Allocate one extra virtio_device_id as null terminator, otherwise > vdpa_mgmtdev_get_classes() may iterate multiple times and visit undefined > memory. > > Fixes: ffbda8e9df10 ("vdpa/vp_vdpa : add vdpa tool support in vp_vdp

RE: [PATCH V2] vp_vdpa: fix id_table array not null terminated error

2024-11-02 Thread Parav Pandit
pa : add vdpa tool support in vp_vdpa") > Cc: sta...@vger.kernel.org > Suggested-by: Parav Pandit > Signed-off-by: Angus Chen > Signed-off-by: Xiaoguang Wang > > --- > V2: > Use kcalloc() api. > --- > drivers/vdpa/virtio_pci/vp_vdpa.c | 6 +- > 1 file cha

RE: [PATCH vfio 0/7] Enhances the vfio-virtio driver to support live migration

2024-10-28 Thread Parav Pandit
> From: Alex Williamson > Sent: Monday, October 28, 2024 10:24 PM > > On Mon, 28 Oct 2024 13:23:54 -0300 > Jason Gunthorpe wrote: > > > On Mon, Oct 28, 2024 at 10:13:48AM -0600, Alex Williamson wrote: > > > > > If the virtio spec doesn't support partial contexts, what makes it > > > beneficia

RE: [PATCH v5 1/1] virtio-blk: Add description for blk_size field

2024-10-23 Thread Parav Pandit
s not an integer multiple of > +the device's \field{blk_size}, the device MAY set the \field{status} to > +VIRTIO_BLK_S_IOERR for both VIRTIO_BLK_T_IN and VIRTIO_BLK_T_OUT > requests. > + > The device MUST set the \field{status} byte to VIRTIO_BLK_S_UNSUPP for > discard, secure erase and write zeroes commands if any unknown flag is set. > Furthermore, the device MUST set the \field{status} byte to > -- > 2.18.1 Apart from other small edits: Reviewed-by: Parav Pandit

RE: [PATCH vfio 0/7] Enhances the vfio-virtio driver to support live migration

2024-10-31 Thread Parav Pandit
> From: Alex Williamson > Sent: Wednesday, October 30, 2024 1:58 AM > > On Mon, 28 Oct 2024 17:46:57 +0000 > Parav Pandit wrote: > > > > From: Alex Williamson > > > Sent: Monday, October 28, 2024 10:24 PM > > > > > > On Mon, 2

RE: [PATCH v5 1/1] virtio-blk: Add description for blk_size field

2024-10-23 Thread Parav Pandit
> From: Parav Pandit > Sent: Thursday, October 24, 2024 7:49 AM > To: Max Gurtovoy ; dverk...@chromium.org; > m...@redhat.com; virtualizat...@lists.linux-foundation.org; > mvara...@redhat.com; stefa...@redhat.com; virtio-...@lists.linux.dev > Cc: Oren Duer ; Nitzan Carmi ; Ben &

RE: [PATCH] Revert "virtio_pci: Support surprise removal of virtio pci device"

2025-04-09 Thread Parav Pandit
Hi Michael, > From: Michael S. Tsirkin > Sent: Wednesday, April 9, 2025 1:45 AM > > On Tue, Apr 08, 2025 at 05:59:08PM +0300, Parav Pandit wrote: > > This reverts commit 43bb40c5b926 ("virtio_pci: Support surprise removal of > virtio pci device"). > > >

[PATCH] Revert "virtio_pci: Support surprise removal of virtio pci device"

2025-04-08 Thread Parav Pandit
quot;virtio_pci: Support surprise removal of virtio pci device") Cc: sta...@vger.kernel.org Reported-by: lirongq...@baidu.com Closes: https://lore.kernel.org/virtualization/c45dd68698cd47238c55fb73ca9b4...@baidu.com/ Reviewed-by: Max Gurtovoy Signed-off-by: Parav Pandit --- drivers/virtio/vir

RE: [PATCH] Revert "virtio_pci: Support surprise removal of virtio pci device"

2025-04-15 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, April 9, 2025 9:32 PM > > On Wed, Apr 09, 2025 at 01:50:18PM +, Parav Pandit wrote: > > Hi Michael, > > > > > From: Michael S. Tsirkin > > > Sent: Wednesday, April 9, 2025 1:45 AM > > > &g

RE: [PATCH v1] virtio_blk: Fix disk deletion hang on device surprise removal

2025-05-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, May 21, 2025 1:48 PM > > On Wed, May 21, 2025 at 06:37:41AM +, Parav Pandit wrote: > > When the PCI device is surprise removed, requests may not complete the > > device as the VQ is marked as broken. Due to this, the

[PATCH v1] virtio_blk: Fix disk deletion hang on device surprise removal

2025-05-20 Thread Parav Pandit
pport surprise removal of virtio pci device") Cc: sta...@vger.kernel.org Reported-by: lirongq...@baidu.com Closes: https://lore.kernel.org/virtualization/c45dd68698cd47238c55fb73ca9b4...@baidu.com/ Reviewed-by: Max Gurtovoy Reviewed-by: Israel Rukshin Signed-off-by: Parav Pandit --- changel