[PATCH v1 1/2] virtio_fs: introduce virtio_fs_put_locked helper

2024-08-25 Thread Max Gurtovoy
taken when it should. Reviewed-by: Idan Zach Reviewed-by: Shai Malin Signed-off-by: Max Gurtovoy --- fs/fuse/virtio_fs.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index dd5260141615..43f7be1d7887 100644 --- a

[PATCH v1 2/2] virtio_fs: add sysfs entries for queue information

2024-08-25 Thread Max Gurtovoy
Virtio FS devices. Reviewed-by: Idan Zach Reviewed-by: Shai Malin Signed-off-by: Max Gurtovoy --- fs/fuse/virtio_fs.c | 147 +--- 1 file changed, 139 insertions(+), 8 deletions(-) diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 43f7be1d7887

[PATCH v3 1/1] virtio-blk: Add description for blk_size field

2024-10-09 Thread Max Gurtovoy
to provide clarity on its constraints. Reviewed-by: Daniel Verkamp Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Gurtovoy --- device-types/blk/description.tex | 34 1 file changed, 34 insertions(+) diff --git a/device-types/blk/description.tex b/device-types

[PATCH v2 1/1] virtio-blk: Add description for blk_size field

2024-10-06 Thread Max Gurtovoy
to provide clarity on its constraints. Signed-off-by: Max Gurtovoy --- changes from V1: - Addressed Stefan's and Daniel's comments: 1. use SHOULD instead of MUST 2. Add a note that devices may return IOERR upon misaligned IO - Add a note that devices may return IOERR

[PATCH 1/1] virtio_fs: store actual queue index in mq_map

2024-10-06 Thread Max Gurtovoy
This will eliminate the need for index recalculation during the fast path. Signed-off-by: Max Gurtovoy --- fs/fuse/virtio_fs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 78f579463cca..44f2580db4c2 100644 --- a

[PATCH 1/1] virtio_fs: add informative log for new tag discovery

2024-10-06 Thread Max Gurtovoy
Enhance the device probing process by adding a log message when a new virtio-fs tag is successfully discovered. This improvement provides better visibility into the initialization of virtio-fs devices. Signed-off-by: Max Gurtovoy --- fs/fuse/virtio_fs.c | 1 + 1 file changed, 1 insertion

Re: [PATCH v3 1/1] virtio-blk: Add description for blk_size field

2024-10-10 Thread Max Gurtovoy
On 10/10/2024 13:24, Matias Ezequiel Vara Larsen wrote: Hello, I wrote some minor comments below. On Wed, Oct 09, 2024 at 07:05:12PM +0300, Max Gurtovoy wrote: This field is only valid when the VIRTIO_BLK_F_BLK_SIZE feature bit is offered by the device. The blk_size field actually

[PATCH v4 1/1] virtio-blk: Add description for blk_size field

2024-10-10 Thread Max Gurtovoy
to provide clarity on its constraints. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/208 Reviewed-by: Daniel Verkamp Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Gurtovoy --- device-types/blk/description.tex | 32 1 file changed, 32 insertions

Re: [PATCH 1/1] virtio-blk: Add description for blk_size field

2024-10-06 Thread Max Gurtovoy
On 03/10/2024 2:56, Daniel Verkamp wrote: On Mon, Sep 30, 2024 at 6:45 PM Daniel Verkamp wrote: On Wed, Sep 25, 2024 at 4:42 PM Max Gurtovoy wrote: [...] I'm curious if you've encountered any actual implementations where drivers send non-block-size-aligned requests to block

[PATCH v5 1/1] virtio-blk: Add description for blk_size field

2024-10-22 Thread Max Gurtovoy
to provide clarity on its constraints. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/208 Reviewed-by: Daniel Verkamp Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Gurtovoy --- changes from v4: - reorder paragraphs (MST, Matias) --- device-types/blk/description.tex | 33

Re: [PATCH 1/1] virtio-blk: Add description for blk_size field

2024-09-27 Thread Max Gurtovoy
On 27/09/2024 0:44, Daniel Verkamp wrote: On Wed, Sep 25, 2024 at 4:42 PM Max Gurtovoy wrote: Hi Daniel, On 25/09/2024 23:57, Daniel Verkamp wrote: On Wed, Sep 25, 2024 at 8:05 AM Max Gurtovoy wrote: This field is only valid when the VIRTIO_BLK_F_BLK_SIZE feature bit is set. The

[PATCH 1/1] virtio-blk: Add description for blk_size field

2024-09-25 Thread Max Gurtovoy
/Windows systems typically use 512-byte/4-KB block sizes. This description provides clarity on the constraints of the blk_size field. Signed-off-by: Max Gurtovoy --- device-types/blk/description.tex | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/device

[PATCH v6 1/1] virtio-blk: Add description for blk_size field

2024-11-07 Thread Max Gurtovoy
to provide clarity on its constraints. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/208 Reviewed-by: Daniel Verkamp Reviewed-by: Stefan Hajnoczi Reviewed-by: Parav Pandit Signed-off-by: Max Gurtovoy --- changes from v5: - plural vs. non-plural fixes (Parav) changes from v4

[PATCH v6 1/1] virtio-blk: Add description for blk_size field

2024-11-07 Thread Max Gurtovoy
to provide clarity on its constraints. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/208 Reviewed-by: Daniel Verkamp Reviewed-by: Stefan Hajnoczi Reviewed-by: Parav Pandit Signed-off-by: Max Gurtovoy --- changes from v5: - plural vs. non-plural fixes (Parav) changes from v4

[PATCH v6 1/1] virtio-blk: Add description for blk_size field

2024-11-07 Thread Max Gurtovoy
to provide clarity on its constraints. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/208 Reviewed-by: Daniel Verkamp Reviewed-by: Stefan Hajnoczi Reviewed-by: Parav Pandit Signed-off-by: Max Gurtovoy --- changes from v5: - plural vs. non-plural fixes (Parav) changes from v4

Re: [PATCH 2/2] virtio-pci: Add admin command length check for device writable portions

2025-04-20 Thread Max Gurtovoy
ensure that the driver does not process potentially invalid or incomplete status from the device. Signed-off-by: Israel Rukshin Reviewed-by: Max Gurtovoy --- drivers/virtio/virtio_pci_modern.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_pci_mode

Re: [PATCH 2/2] virtio-pci: Add admin command length check for device writable portions

2025-04-21 Thread Max Gurtovoy
, 2025 at 02:05:27PM +0300, Israel Rukshin wrote: On 4/20/2025 4:07 PM, Michael S. Tsirkin wrote: On Sun, Apr 20, 2025 at 03:31:25PM +0300, Max Gurtovoy wrote: On 20/04/2025 14:33, Michael S. Tsirkin wrote: On Sun, Apr 20, 2025 at 02:19:05PM +0300, Israel Rukshin wrote: Add a safety check to ensure