Re: [PATCH] viommu: return error code for unknown probe type

2024-04-15 Thread Jean-Philippe Brucker
Hello, On Mon, Apr 15, 2024 at 04:18:23PM +0800, flyingpeng...@gmail.com wrote: > From: Peng Hao > > If the probe types processed by the loop are all unknown, > no error will be returned. > > Signed-off-by: Peng Hao > --- > drivers/iommu/virtio-iommu.c | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 0/5] Convert virtio-iommu to domain_alloc_paging()

2025-02-12 Thread Jean-Philippe Brucker
Hi Jacob, On Tue, Feb 11, 2025 at 04:41:51PM -0800, Jacob Pan wrote: > > However, there seem to be some unrelated qemu bugs. 7.0.0 does not > > have working VIRTIO_IOMMU_F_BYPASS_CONFIG and neither qemu works with > > an IDENTITY domain using !VIRTIO_IOMMU_F_BYPASS_CONFIG. It prints: > > > > qem

Re: [PATCH 3/5] iommu/virtio: Move to domain_alloc_paging()

2025-02-13 Thread Jean-Philippe Brucker
Hi Jacob, On Wed, Feb 12, 2025 at 09:47:23PM -0800, Jacob Pan wrote: > Our code and backend support are still in the early stages, that is why > I am attempting to convert virtio-iommu driver to iommu_pt. Not sure if > anyone has done the QEMU part to support VIRTIO_IOMMU_F_ATTACH_TABLE? > @Jean @

Re: [PATCH] iommu/virtio: Make instance lookup robust

2025-03-21 Thread Jean-Philippe Brucker
On Thu, Mar 20, 2025 at 03:32:54PM +, Robin Murphy wrote: > Much like arm-smmu in commit 7d835134d4e1 ("iommu/arm-smmu: Make > instance lookup robust"), virtio-iommu appears to have the same issue > where iommu_device_register() makes the IOMMU instance visible to other > API callers (including

Re: [PATCH 3/5] iommu/virtio: Move to domain_alloc_paging()

2025-02-19 Thread Jean-Philippe Brucker
On Wed, Feb 19, 2025 at 05:39:19PM +0800, Yu Zhang wrote: > On Thu, Feb 13, 2025 at 06:09:19PM +0000, Jean-Philippe Brucker wrote: > > On Fri, Feb 14, 2025 at 01:03:43AM +0800, Yu Zhang wrote: > > > On Thu, Feb 13, 2025 at 09:46:01AM +0000, Jean-Philippe Brucker wrote

Re: [PATCH 3/5] iommu/virtio: Move to domain_alloc_paging()

2025-02-19 Thread Jean-Philippe Brucker
On Wed, Feb 19, 2025 at 07:11:43PM +0800, Yu Zhang wrote: > On Wed, Feb 19, 2025 at 10:35:18AM +0000, Jean-Philippe Brucker wrote: > > On Wed, Feb 19, 2025 at 05:39:19PM +0800, Yu Zhang wrote: > > > On Thu, Feb 13, 2025 at 06:09:19PM +0000, Jean-Philippe Brucker wrote: > >

Re: [PATCH v2 1/5] iommu/virtio: Break out bypass identity support into a global static

2025-03-03 Thread Jean-Philippe Brucker
he domain_alloc path is still used, > which creates an IDENTITY domain out of a paging domain. > > Signed-off-by: Jason Gunthorpe Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/virtio-iommu.c | 86 > 1 file changed, 67 insertions(+)

Re: [PATCH v2 3/5] iommu/virtio: Move to domain_alloc_paging()

2025-03-03 Thread Jean-Philippe Brucker
entity(). > > Remove support for deferred finalize and the vdomain->mutex. > > Remove core support for domain_alloc() IDENTITY as virtio was the last > driver using it. > > Signed-off-by: Jason Gunthorpe Reviewed-by: Jean-Philippe Brucker And my tests still pass (after f

Re: [PATCH 3/5] iommu/virtio: Move to domain_alloc_paging()

2025-02-13 Thread Jean-Philippe Brucker
On Fri, Feb 14, 2025 at 01:03:43AM +0800, Yu Zhang wrote: > On Thu, Feb 13, 2025 at 09:46:01AM +0000, Jean-Philippe Brucker wrote: > > Hi Jacob, > > > > On Wed, Feb 12, 2025 at 09:47:23PM -0800, Jacob Pan wrote: > > > Our code and backend support are still in the ear

Re: [PATCH 0/5] Convert virtio-iommu to domain_alloc_paging()

2025-02-12 Thread Jean-Philippe Brucker
On Wed, Feb 12, 2025 at 09:05:35AM -0800, Jacob Pan wrote: > > Does reproducing this require > > modifying QEMU or Linux to disable support for F_BYPASS_CONFIG, or > > just passing QEMU/kernel parameters? > I only modified guest code to pretend F_BYPASS_CONFIG is not supported, > a couple of plac

Re: [PATCH 0/5] Convert virtio-iommu to domain_alloc_paging()

2025-02-21 Thread Jean-Philippe Brucker
On Wed, Feb 12, 2025 at 08:50:07AM -0400, Jason Gunthorpe wrote: > On Tue, Feb 11, 2025 at 04:41:51PM -0800, Jacob Pan wrote: > > > I see the same on arm64 with v9.0, assigned an ixgbe nic via VFIO. > > Huh, I figured it worked on ARM.. Crosvm would be a more useful test because it doesn't imple

Re: [PATCH 1/5] iommu/virtio: Break out bypass identity support into a global static

2025-02-21 Thread Jean-Philippe Brucker
On Fri, Feb 07, 2025 at 10:46:01AM -0400, Jason Gunthorpe wrote: > To make way for a domain_alloc_paging conversion add the typical global > static IDENTITY domain. This supports VMMs that have a > VIRTIO_IOMMU_F_BYPASS_CONFIG config. > > If the VMM does not have support then the domain_alloc path