Re: [EXTERNAL] Re: [PATCH v2 0/2] vhost-vdpa: Add support for NO-IOMMU mode

2024-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2024 at 01:41:51PM -0400, Michael S. Tsirkin wrote: > It's basically because vfio does, so we have to follow suit. That's a very bold argument, especially without any rationale of a) why you need to match the feature set b) how even adding it to vfio was agood idea

Re: [EXTERNAL] Re: [PATCH v2 0/2] vhost-vdpa: Add support for NO-IOMMU mode

2024-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2024 at 05:28:27PM +, Srujana Challa wrote: > When using the DPDK virtio user PMD, we’ve noticed a significant 70% > performance improvement when IOMMU is disabled on specific low-end > x86 machines. This performance improvement can be particularly > advantageous for embedded pl

[PATCH] vDPA/ifcvf: Fix pci_read_config_byte() return code handling

2024-10-16 Thread Yuan Can
ifcvf_init_hw() uses pci_read_config_byte() that returns PCIBIOS_* codes. The error handling, however, assumes the codes are normal errnos because it checks for < 0. Convert the error check to plain non-zero check. Fixes: 5a2414bc454e ("virtio: Intel IFC VF driver for VDPA") Signed-off-by: Yuan Ca

RE: [EXTERNAL] Re: [PATCH v2 0/2] vhost-vdpa: Add support for NO-IOMMU mode

2024-10-16 Thread Srujana Challa
> Subject: Re: [EXTERNAL] Re: [PATCH v2 0/2] vhost-vdpa: Add support for NO- > IOMMU mode > > On Mon, Oct 14, 2024 at 01: 18: 01PM +, Srujana Challa wrote: > > On Fri, > Sep 20, 2024 at 07: 35: 28PM +0530, Srujana Challa wrote: > > > This patchset > introduces support for an UNSAFE, no-IOMMU m

Re: [EXTERNAL] Re: [PATCH v2 0/2] vhost-vdpa: Add support for NO-IOMMU mode

2024-10-16 Thread Michael S. Tsirkin
On Mon, Oct 14, 2024 at 08:48:27PM -0700, Christoph Hellwig wrote: > On Mon, Oct 14, 2024 at 01:18:01PM +, Srujana Challa wrote: > > > On Fri, Sep 20, 2024 at 07:35:28PM +0530, Srujana Challa wrote: > > > > This patchset introduces support for an UNSAFE, no-IOMMU mode in the > > > > vhost-vdpa