Re: [PATCH v4 5/5] iommu: Hide ops.domain_alloc behind CONFIG_FSL_PAMU

2025-04-10 Thread Jason Gunthorpe
On Thu, Apr 10, 2025 at 05:57:44AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, April 9, 2025 12:36 AM > > > > +#if IS_ENABLED(CONFIG_FSL_PAMU) > > struct iommu_domain *(*domain_alloc)(unsigned > > iommu_domain_type); > > +#endif > > what about directly calling it

RE: [PATCH v4 5/5] iommu: Hide ops.domain_alloc behind CONFIG_FSL_PAMU

2025-04-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, April 9, 2025 12:36 AM > > +#if IS_ENABLED(CONFIG_FSL_PAMU) > struct iommu_domain *(*domain_alloc)(unsigned > iommu_domain_type); > +#endif what about directly calling it as domain_alloc_fsl(), given no more drivers can support it? Reviewed-by: K

[PATCH v4 5/5] iommu: Hide ops.domain_alloc behind CONFIG_FSL_PAMU

2025-04-08 Thread Jason Gunthorpe
fsl_pamu is the last user of domain_alloc(), and it is using it to create something weird that doesn't really fit into the iommu subsystem architecture. It is a not a paging domain since it doesn't have any map/unmap ops. It may be some special kind of identity domain. For now just leave it as is.