Re: [PATCH v3 1/1] virtio-blk: Add description for blk_size field

2024-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2024 at 05:04:55PM +0300, Max Gurtovoy wrote: > > On 10/10/2024 13:24, Matias Ezequiel Vara Larsen wrote: > > Hello, > > > > I wrote some minor comments below. > > > > On Wed, Oct 09, 2024 at 07:05:12PM +0300, Max Gurtovoy wrote: > > > This field is only valid when the VIRTIO_BLK

Re: [PATCH v3 1/1] virtio-blk: Add description for blk_size field

2024-10-10 Thread Max Gurtovoy
On 10/10/2024 13:24, Matias Ezequiel Vara Larsen wrote: Hello, I wrote some minor comments below. On Wed, Oct 09, 2024 at 07:05:12PM +0300, Max Gurtovoy wrote: This field is only valid when the VIRTIO_BLK_F_BLK_SIZE feature bit is offered by the device. The blk_size field actually represent

Re: [PATCH v3 1/1] virtio-blk: Add description for blk_size field

2024-10-10 Thread Matias Ezequiel Vara Larsen
Hello, I wrote some minor comments below. On Wed, Oct 09, 2024 at 07:05:12PM +0300, Max Gurtovoy wrote: > This field is only valid when the VIRTIO_BLK_F_BLK_SIZE feature bit is > offered by the device. > > The blk_size field actually represents the logical block size of the > device. It is alwa

[PATCH v3 1/1] virtio-blk: Add description for blk_size field

2024-10-09 Thread Max Gurtovoy
This field is only valid when the VIRTIO_BLK_F_BLK_SIZE feature bit is offered by the device. The blk_size field actually represents the logical block size of the device. It is always a power of two and typically ranges from 512 bytes to larger values such as 4 KB. Add description for this field