Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-22 Thread Michael S. Tsirkin
On Wed, Jul 23, 2025 at 01:54:37PM +0800, Jason Wang wrote: > On Wed, Jul 23, 2025 at 1:26 AM Michael S. Tsirkin wrote: > > > > On Mon, Jul 21, 2025 at 04:05:17PM +0800, Jason Wang wrote: > > > On Fri, Jul 18, 2025 at 6:09 PM Jason Wang wrote: > > > > > > > > On Fri, Jul 18, 2025 at 5:37 PM Micha

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-22 Thread Jason Wang
On Wed, Jul 23, 2025 at 1:26 AM Michael S. Tsirkin wrote: > > On Mon, Jul 21, 2025 at 04:05:17PM +0800, Jason Wang wrote: > > On Fri, Jul 18, 2025 at 6:09 PM Jason Wang wrote: > > > > > > On Fri, Jul 18, 2025 at 5:37 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Jul 18, 2025 at 05:

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-22 Thread Michael S. Tsirkin
On Mon, Jul 21, 2025 at 04:05:17PM +0800, Jason Wang wrote: > On Fri, Jul 18, 2025 at 6:09 PM Jason Wang wrote: > > > > On Fri, Jul 18, 2025 at 5:37 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 18, 2025 at 05:16:14PM +0800, Jason Wang wrote: > > > > Virtio core switches from DMA device to

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-22 Thread Michael S. Tsirkin
On Fri, Jul 18, 2025 at 06:09:35PM +0800, Jason Wang wrote: > On Fri, Jul 18, 2025 at 5:37 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 18, 2025 at 05:16:14PM +0800, Jason Wang wrote: > > > Virtio core switches from DMA device to mapping token, let's do that > > > as well for vDPA. > > > > Pls

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-22 Thread Michael S. Tsirkin
On Fri, Jul 18, 2025 at 06:09:35PM +0800, Jason Wang wrote: > On Fri, Jul 18, 2025 at 5:37 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 18, 2025 at 05:16:14PM +0800, Jason Wang wrote: > > > Virtio core switches from DMA device to mapping token, let's do that > > > as well for vDPA. > > > > Pls

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-21 Thread Jason Wang
On Fri, Jul 18, 2025 at 6:09 PM Jason Wang wrote: > > On Fri, Jul 18, 2025 at 5:37 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 18, 2025 at 05:16:14PM +0800, Jason Wang wrote: > > > Virtio core switches from DMA device to mapping token, let's do that > > > as well for vDPA. > > > > Pls switch

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-18 Thread Jason Wang
On Fri, Jul 18, 2025 at 5:37 PM Michael S. Tsirkin wrote: > > On Fri, Jul 18, 2025 at 05:16:14PM +0800, Jason Wang wrote: > > Virtio core switches from DMA device to mapping token, let's do that > > as well for vDPA. > > Pls switch to imperative mood. > > And add explanation about what is going on

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-18 Thread Michael S. Tsirkin
On Fri, Jul 18, 2025 at 05:16:14PM +0800, Jason Wang wrote: > Virtio core switches from DMA device to mapping token, let's do that > as well for vDPA. Pls switch to imperative mood. And add explanation about what is going on and why please. At least, document what are the actual types stored her

Re: [PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-18 Thread Zhu Lingshan
Reviewed-by Zhu Lingshan Jason Wang 于2025年7月18日周五 17:17写道： > > Virtio core switches from DMA device to mapping token, let's do that > as well for vDPA. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Jason Wang > --- > drivers/vdpa/alibaba/eni_vdpa.c | 2 +- > drivers/vdpa/ifcvf

[PATCH V4 7/9] vdpa: rename dma_dev to map_token

2025-07-18 Thread Jason Wang
Virtio core switches from DMA device to mapping token, let's do that as well for vDPA. Reviewed-by: Christoph Hellwig Signed-off-by: Jason Wang --- drivers/vdpa/alibaba/eni_vdpa.c | 2 +- drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- drivers/vdpa/mlx5/core/mr.c | 4 +