Re: [PATCH] virtio_pci: Fix admin vq cleanup by using correct info pointer

2024-10-31 Thread Feng Liu
On 2024-10-31 p.m.12:52, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Thu, Oct 31, 2024 at 10:17:00AM -0400, Feng Liu wrote: Hi, Excuse me. Have any comments for this patch? Thanks Feng it's tagged, will be in the next pull. Thanks! Thanks Mic

Re: [PATCH] virtio_pci: Fix admin vq cleanup by using correct info pointer

2024-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2024 at 10:17:00AM -0400, Feng Liu wrote: > Hi, > > Excuse me. Have any comments for this patch? > > Thanks > Feng it's tagged, will be in the next pull. Thanks!

Re: [PATCH] virtio_pci: Fix admin vq cleanup by using correct info pointer

2024-10-31 Thread Feng Liu
Hi, Excuse me. Have any comments for this patch? Thanks Feng On 2024-10-29 a.m.8:17, Feng Liu wrote: External email: Use caution opening links or attachments Hi, Any comments? Thanks Feng On 2024-10-24 a.m.9:54, Feng Liu wrote: vp_modern_avq_cleanup() and vp_del_vqs() clean up admin vq r

Re: [PATCH] virtio_pci: Fix admin vq cleanup by using correct info pointer

2024-10-29 Thread Feng Liu
Hi, Any comments? Thanks Feng On 2024-10-24 a.m.9:54, Feng Liu wrote: vp_modern_avq_cleanup() and vp_del_vqs() clean up admin vq resources by virtio_pci_vq_info pointer. The info pointer of admin vq is stored in vp_dev->admin_vq.info instead of vp_dev->vqs[]. Using the info pointer from vp_dev

[PATCH] virtio_pci: Fix admin vq cleanup by using correct info pointer

2024-10-24 Thread Feng Liu
vp_modern_avq_cleanup() and vp_del_vqs() clean up admin vq resources by virtio_pci_vq_info pointer. The info pointer of admin vq is stored in vp_dev->admin_vq.info instead of vp_dev->vqs[]. Using the info pointer from vp_dev->vqs[] for admin vq causes a kernel NULL pointer dereference bug. In vp_mo