Re: [PATCH vfio 0/7] Enhances the vfio-virtio driver to support live migration

2024-10-29 Thread Alex Williamson
On Mon, 28 Oct 2024 17:46:57 + Parav Pandit wrote: > > From: Alex Williamson > > Sent: Monday, October 28, 2024 10:24 PM > > > > On Mon, 28 Oct 2024 13:23:54 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Oct 28, 2024 at 10:13:48AM -0600, Alex Williamson wrote: > > > > > > > If th

Re: [PATCH] virtio-pmem: reset device before delete vqs on device removal

2024-10-29 Thread Pankaj Gupta
+CC MST > We should not update virtqueue status while device is in DRIVER_OK > status, so reset device first then delete vqs. > > Fixes: 6e84200c0a29 ("virtio-pmem: Add virtio pmem driver") > Signed-off-by: Eryu Guan Looks good to me. Acked-by: Pankaj Gupta --- > drivers/nvdimm/virtio_pmem.c |

Re: [PATCH] virtio_pci: Fix admin vq cleanup by using correct info pointer

2024-10-29 Thread Feng Liu
Hi, Any comments? Thanks Feng On 2024-10-24 a.m.9:54, Feng Liu wrote: vp_modern_avq_cleanup() and vp_del_vqs() clean up admin vq resources by virtio_pci_vq_info pointer. The info pointer of admin vq is stored in vp_dev->admin_vq.info instead of vp_dev->vqs[]. Using the info pointer from vp_dev

Re: [PATCH vfio 0/7] Enhances the vfio-virtio driver to support live migration

2024-10-29 Thread Yishai Hadas
On 28/10/2024 18:23, Jason Gunthorpe wrote: On Mon, Oct 28, 2024 at 10:13:48AM -0600, Alex Williamson wrote: On Sun, 27 Oct 2024 12:07:44 +0200 Yishai Hadas wrote: If the virtio spec doesn't support partial contexts, what makes it beneficial here? It stil lets the receiver 'warm up', like all

Re: [PATCH vfio 0/7] Enhances the vfio-virtio driver to support live migration

2024-10-29 Thread Yishai Hadas
On 28/10/2024 20:17, Alex Williamson wrote: On Sun, 27 Oct 2024 12:07:44 +0200 Yishai Hadas wrote: This series enhances the vfio-virtio driver to support live migration for virtio-net Virtual Functions (VFs) that are migration-capable. What's the status of making virtio-net VFs in QEMU migra