Made corresponding change per spec:
The device MUST NOT offer a feature which requires another feature
which was not offered.
Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 16 +---
1 file c
No functional change introduced. vdpa bus driver such as virtio_vdpa
or vhost_vdpa is not supposed to take care of the locking for core
by its own. The locked API vdpa_set_features should suffice the
bus driver's need.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/vdpa.c | 2 +-
dr
On 1/12/2022 10:57 PM, Michael S. Tsirkin wrote:
On Thu, Jan 13, 2022 at 12:10:50AM -0500, Si-Wei Liu wrote:
Made corresponding change per spec:
The device MUST NOT offer a feature which requires another feature
which was not offered.
Says nothing about the driver though, and you seem to
On 1/12/2022 11:00 PM, Michael S. Tsirkin wrote:
On Thu, Jan 13, 2022 at 12:10:51AM -0500, Si-Wei Liu wrote:
Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
Signed-off-by: Si-Wei Liu
Add motivation for change in the commit log.
---
drivers/vdpa/mlx5/net/mlx5_v
On 1/12/2022 11:03 PM, Michael S. Tsirkin wrote:
On Thu, Jan 13, 2022 at 12:10:48AM -0500, Si-Wei Liu wrote:
This patchset contains the fixes for a few issues uncovered during the
review for the "Allow for configuring max number of virtqueue pairs"
series.
It is based on E
t the actual
code change
- fixed corrupted email address format in SoB
Si-Wei Liu (3):
vdpa: factor out vdpa_set_features_unlocked for vdpa internal use
vdpa/mlx5: should verify CTRL_VQ feature exists for MQ
vdpa/mlx5: add validation for VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET command
drivers/vd
han just validate the minimum features. verify_driver_features()
is now used to accommodate various checks against the driver features
for set_driver_features().
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git
for the queues were there any bogus request
sent down by untrusted driver. Tie up the loose ends there.
Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 16
1 file changed, 16 insertions(+)
di
No functional change introduced. vdpa bus driver such as virtio_vdpa
or vhost_vdpa is not supposed to take care of the locking for core
by its own. The locked API vdpa_set_features should suffice the
bus driver's need.
Signed-off-by: Si-Wei Liu
Reviewed-by: Eli Cohen
---
drivers/vdpa/v
On 2/16/2022 3:33 AM, Eli Cohen wrote:
Allow an admin creating a vdpa device to specify the max MTU for the
net device.
For example, to create a device with max MTU of 1000, the following
command can be used:
$ vdpa dev add name vdpa-a mgmtdev auxiliary/mlx5_core.sf.1 mtu 1000
Signed-off-by
On 2/16/2022 12:00 AM, Eli Cohen wrote:
Allows to read vendor statistics of a vdpa device. The specific statistics
data is received by the upstream driver in the form of an (attribute
name, attribute value) pairs.
An example of statistics for mlx5_vdpa device are:
received_desc - number of d
On 2/16/2022 10:20 PM, Eli Cohen wrote:
On Wed, Feb 16, 2022 at 10:19:52AM -0800, Si-Wei Liu wrote:
On 2/16/2022 3:33 AM, Eli Cohen wrote:
Allow an admin creating a vdpa device to specify the max MTU for the
net device.
For example, to create a device with max MTU of 1000, the following
Sorry, I somehow missed this after my break. Please see comments in line.
On 2/16/2022 10:46 PM, Eli Cohen wrote:
On Wed, Feb 16, 2022 at 10:49:26AM -0800, Si-Wei Liu wrote:
On 2/16/2022 12:00 AM, Eli Cohen wrote:
Allows to read vendor statistics of a vdpa device. The specific statistics
On 3/6/2022 11:57 PM, Eli Cohen wrote:
-Original Message-
From: Si-Wei Liu
Sent: Saturday, March 5, 2022 12:34 AM
To: Eli Cohen
Cc: m...@redhat.com; jasow...@redhat.com; virtualization@lists.linux-
foundation.org; epere...@redhat.com; amore...@redhat.com;
lviv...@redhat.com; sgarz
On 3/8/2022 6:13 AM, Eli Cohen wrote:
-Original Message-
From: Si-Wei Liu
Sent: Tuesday, March 8, 2022 8:16 AM
To: Eli Cohen
Cc: m...@redhat.com; jasow...@redhat.com; virtualization@lists.linux-
foundation.org; epere...@redhat.com; amore...@redhat.com;
lviv...@redhat.com; sgarz
On 3/8/2022 9:07 PM, Eli Cohen wrote:
-Original Message-
From: Si-Wei Liu
Sent: Wednesday, March 9, 2022 5:33 AM
To: Eli Cohen
Cc: m...@redhat.com; jasow...@redhat.com; virtualization@lists.linux-
foundation.org; epere...@redhat.com; amore...@redhat.com;
lviv...@redhat.com; sgarz
On 3/13/2022 8:26 AM, Eli Cohen wrote:
On 3/8/2022 9:07 PM, Eli Cohen wrote:
-Original Message-
From: Si-Wei Liu
Sent: Wednesday, March 9, 2022 5:33 AM
To: Eli Cohen
Cc: m...@redhat.com; jasow...@redhat.com; virtualization@lists.linux-
foundation.org; epere...@redhat.com; amore
On 3/13/2022 11:25 PM, Jason Wang wrote:
On Sun, Mar 13, 2022 at 11:26 PM Eli Cohen wrote:
> On 3/8/2022 9:07 PM, Eli Cohen wrote:
> >
> >> -Original Message-----
> >> From: Si-Wei Liu
> >> Sent: Wednesday, March 9, 2022 5:33 AM
On 3/15/2022 2:10 AM, Eli Cohen wrote:
<...snip...>
Say you got a vdpa net device created with 4 data queue pairs and a
control vq. On boot some guest firmware may support just F_CTRL_VQ but
not F_MQ, then the index for the control vq in guest ends up with 2, as
in this case there's only a si
On 3/16/2022 12:10 AM, Eli Cohen wrote:
From: Si-Wei Liu
Sent: Wednesday, March 16, 2022 8:52 AM
To: Eli Cohen
Cc: m...@redhat.com; jasow...@redhat.com;
virtualization@lists.linux-foundation.org; epere...@redhat.com;
amore...@redhat.com;
lviv...@redhat.com; sgarz...@redhat.com; Parav
On 3/16/2022 7:32 PM, Jason Wang wrote:
On Thu, Mar 17, 2022 at 6:00 AM Si-Wei Liu wrote:
On 3/16/2022 12:10 AM, Eli Cohen wrote:
From: Si-Wei Liu
Sent: Wednesday, March 16, 2022 8:52 AM
To: Eli Cohen
Cc: m...@redhat.com; jasow...@redhat.com;
virtualization@lists.linux-foundation.org
for the network type of vdpa device. This is optional.
.BI mtu " MTU"
- specifies the mtu for the new vdpa device.
This is applicable only for the network type of vdpa device. This is optional.
Otherwise looks good to me.
Reviewed-by: Si-Wei Liu
Thanks,
-Siwei
.ti -8
.B vdpa de
e only for the network type of vdpa device. This is optional.
.BI mtu " MTU"
- specifies the mtu for the new vdpa device.
This is applicable only for the network type of vdpa device. This is optional.
Otherwise looks good to me.
Reviewed-by: Si-Wei Liu
Thanks,
-Siwei
.ti -8
.B vdpa
On 3/17/2022 7:27 PM, Jason Wang wrote:
On Fri, Mar 18, 2022 at 8:59 AM Si-Wei Liu wrote:
On 3/16/2022 7:32 PM, Jason Wang wrote:
On Thu, Mar 17, 2022 at 6:00 AM Si-Wei Liu wrote:
On 3/16/2022 12:10 AM, Eli Cohen wrote:
From: Si-Wei Liu
Sent: Wednesday, March 16, 2022 8:52 AM
To
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the pinning leakage first and do the
possible optimization on top (which is still questionable to me).
OK
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the
This reverts commit 7ed9e3d97c32d969caded2dfb6e67c1a2cc5a0b1.
Signed-off-by: Si-Wei Liu
---
drivers/vhost/vdpa.c | 119 +--
1 file changed, 48 insertions(+), 71 deletions(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index a2dbc85
memory demand for VM with a large
amount of memory, or in the situation where host is running
short of free memory.
Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
drivers/vhost/vdpa.c | 64 +---
1 fi
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the
On 11/3/2020 5:00 AM, Jason Wang wrote:
On 2020/10/30 下午3:45, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path.
The memory usage for bookkeeping pinned pages is reverted
to what
On 11/3/2020 5:06 PM, si-wei liu wrote:
On 11/3/2020 5:00 AM, Jason Wang wrote:
On 2020/10/30 下午3:45, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path.
The memory usage for
On 11/3/2020 5:58 PM, Jason Wang wrote:
On 2020/11/4 上午9:08, si-wei liu wrote:
On 11/3/2020 5:06 PM, si-wei liu wrote:
On 11/3/2020 5:00 AM, Jason Wang wrote:
On 2020/10/30 下午3:45, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB
On 11/3/2020 6:42 PM, Jason Wang wrote:
On 2020/10/30 下午3:45, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path.
The memory usage for bookkeeping pinned pages is reverted
to what
memory demand for VM with a large
amount of memory, or in the situation where host is running
short of free memory.
Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
Changes in v2:
- Drop the reversion patch
- Fix unhandled page leak towards the end of
On 11/4/2020 7:12 PM, Jason Wang wrote:
On 2020/11/5 上午7:40, si-wei liu wrote:
On 11/3/2020 6:42 PM, Jason Wang wrote:
On 2020/10/30 下午3:45, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for
On 11/4/2020 7:26 PM, Jason Wang wrote:
On 2020/11/5 上午7:33, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path.
The memory usage for bookkeeping pinned pages is reverted
to what
memory demand for VM with a large
amount of memory, or in the situation where host is running
short of free memory.
Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
Changes in v3:
- Turn explicit last_pfn check to a WARN_ON() (Jason)
Changes in v2:
On 11/8/2020 7:21 PM, Jason Wang wrote:
On 2020/11/6 上午6:57, si-wei liu wrote:
On 11/4/2020 7:26 PM, Jason Wang wrote:
On 2020/11/5 上午7:33, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for
On 11/9/2020 2:42 PM, Michael S. Tsirkin wrote:
On Mon, Nov 09, 2020 at 01:44:03PM -0800, si-wei liu wrote:
On 11/8/2020 7:21 PM, Jason Wang wrote:
On 2020/11/6 上午6:57, si-wei liu wrote:
On 11/4/2020 7:26 PM, Jason Wang wrote:
On 2020/11/5 上午7:33, Si-Wei Liu wrote:
Pinned pages are not
On 11/9/2020 7:28 PM, Jason Wang wrote:
On 2020/11/6 上午7:26, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path.
The memory usage for bookkeeping pinned pages is reverted
to what
A gentle reminder. Any chance this patch will get picked soon?
Thanks,
-Siwei
On 11/9/2020 7:28 PM, Jason Wang wrote:
On 2020/11/6 上午7:26, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the
On 11/25/2020 1:30 AM, Michael S. Tsirkin wrote:
On Thu, Nov 05, 2020 at 06:26:33PM -0500, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path.
The memory usage for bookkeeping
On 2/3/2021 11:36 PM, Eli Cohen wrote:
When a change of memory map occurs, the hardware resources are destroyed
and then re-created again with the new memory map. In such case, we need
to restore the hardware available and used indices. The driver failed to
restore the used index which is adde
to be started,
i.e. until VIRTIO_CONFIG_S_DRIVER_OK is set again in
set_status().
Fixes: b35ccebe3ef7 ("vdpa/mlx5: Restore the hardware used index after change
map")
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
e Ethernet header up to the FCS altogether.
Fix the MTU so packets won't get dropped silently.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 4
drivers/vdpa/mlx5/net/mlx5_vnet.c | 15 ++-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git
wire.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index b8416c4..aa6f8cd 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_v
On 2/7/2021 9:35 PM, Eli Cohen wrote:
On Sat, Feb 06, 2021 at 04:29:23AM -0800, Si-Wei Liu wrote:
The mlx_features denotes the capability for which
set of virtio features is supported by device. In
principle, this field needs not be cleared during
virtio device reset, as this capability is
On 2/7/2021 9:48 PM, Eli Cohen wrote:
On Sat, Feb 06, 2021 at 04:29:24AM -0800, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from device. The saved avail_index is used
to restate the virtq
On 2/8/2021 7:37 PM, Jason Wang wrote:
On 2021/2/6 下午8:29, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from device. The saved avail_index is used
to restate the virtq once device is st
, 2021 at 12:27:18PM +0800, Jason Wang wrote:
On 2021/2/6 上午7:07, Si-Wei Liu wrote:
On 2/3/2021 11:36 PM, Eli Cohen wrote:
When a change of memory map occurs, the hardware resources are
destroyed
and then re-created again with the new memory map. In such
case, we need
to restore the hardware
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote:
On 2021/2/8 下午6:04, Eli Cohen wrote:
On Mon, Feb 08, 2021 at 05:04
to be started,
i.e. until VIRTIO_CONFIG_S_DRIVER_OK is set again in
set_status().
Fixes: b35ccebe3ef7 ("vdpa/mlx5: Restore the hardware used index after change
map")
Signed-off-by: Si-Wei Liu
Acked-by: Jason Wang
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
1 file changed, 1 insertion
--
v1->v2: move feature capability query to probing (Eli)
Si-Wei Liu (3):
vdpa/mlx5: should exclude header length and fcs from mtu
vdpa/mlx5: fix feature negotiation across device reset
vdpa/mlx5: defer clear_virtqueues to until DRIVER_OK
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 4
driv
wire.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
b/driver
e Ethernet header up to the FCS altogether.
Fix the MTU so packets won't get dropped silently.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Si-Wei Liu
Acked-by: Jason Wang
Acked-by: Eli Cohen
---
drivers/vdpa/mlx5/core/mlx5_vdpa.
On 2/10/2021 7:45 AM, Eli Cohen wrote:
On Wed, Feb 10, 2021 at 12:59:03AM -0800, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20
set_vq_state(). In get_vq_state() we return the value of hardware
used index.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
Acked-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 -
1 file changed, 4 inserti
On 2/17/2021 1:20 PM, Michael S. Tsirkin wrote:
On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote:
On 2/16/2021 8:20 AM, Eli Cohen wrote:
When we suspend the VM, the VDPA interface will be reset. When the VM is
resumed again, clear_virtqueues() will clear the available and used
On 2/16/2021 7:21 AM, Eli Cohen wrote:
On Thu, Feb 11, 2021 at 09:33:14AM +0200, Eli Cohen wrote:
On Wed, Feb 10, 2021 at 01:48:00PM -0800, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from d
On 2/17/2021 8:44 PM, Jason Wang wrote:
On 2021/2/10 下午4:59, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason
o 0
prematurely causes correct MTU and link status unable to load
for the very first config space access, rendering issues like
guest showing inaccurate MTU value, or failure to reject
out-of-range MTU.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by:
On 2/18/2021 7:10 PM, Jason Wang wrote:
On 2021/2/18 8:43 下午, Si-Wei Liu wrote:
On 2/17/2021 8:44 PM, Jason Wang wrote:
On 2021/2/10 下午4:59, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote
On 2/17/2021 11:42 AM, Si-Wei Liu wrote:
On 2/16/2021 8:20 AM, Eli Cohen wrote:
When we suspend the VM, the VDPA interface will be reset. When the VM is
resumed again, clear_virtqueues() will clear the available and used
indices resulting in hardware virqtqueue objects becoming out of sync
On 2/19/2021 6:38 PM, Jason Wang wrote:
Right now the value is exposed to userspace via GET_VRING_BASE, so
only last_avail_idx is synced. If we need sync last_used_idx, we
should also sync pending indices which requires more thoughts.
Technically it doesn't sound right - crossing the bounda
On 2/19/2021 6:38 PM, Jason Wang wrote:
Right now the value is exposed to userspace via GET_VRING_BASE, so
only last_avail_idx is synced. If we need sync last_used_idx, we
should also sync pending indices which requires more thoughts.
Technically it doesn't sound right - crossing the bound
On 2/21/2021 8:14 PM, Jason Wang wrote:
On 2021/2/19 7:54 下午, Si-Wei Liu wrote:
Commit 452639a64ad8 ("vdpa: make sure set_features is invoked
for legacy") made an exception for legacy guests to reset
features to 0, when config space is accessed before features
are set. We should r
On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote:
On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote:
On 2021/2/19 7:54 下午, Si-Wei Liu wrote:
Commit 452639a64ad8 ("vdpa: make sure set_features is invoked
for legacy") made an exception for legacy guests to reset
features
On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote:
On 2021/2/23 9:12 上午, Si-Wei Liu wrote:
On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote:
On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote:
On 2021/2/19 7:54 下午, Si-Wei Liu
On 2/23/2021 9:04 PM, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote:
On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote:
On 2021/2/23 9:12 上午, Si-Wei Liu wrote:
On 2/21/2021 11:34 PM, Michael S
;s fine, I would proceed to reverting commit fe36cbe067 and related
code in question from the kernel.
Thanks,
-Siwei
On 2/24/2021 10:24 AM, Si-Wei Liu wrote:
Detecting it isn't enough though, we will need a new ioctl to notify
the kernel that it's a legacy guest. Ugh :(
Well, although I t
;s fine, I would proceed to reverting commit fe36cbe067 and related
code in question from the kernel.
Thanks,
-Siwei
On 2/24/2021 10:24 AM, Si-Wei Liu wrote:
Detecting it isn't enough though, we will need a new ioctl to notify
the kernel that it's a legacy guest. Ugh :(
Well, althou
On 2/28/2021 1:27 PM, Michael S. Tsirkin wrote:
On Thu, Feb 25, 2021 at 04:56:42PM -0800, Si-Wei Liu wrote:
Hi Michael,
Are you okay to live without this ioctl for now? I think QEMU is the one
that needs to be fixed and will have to be made legacy guest aware. I think
the kernel can just
ted on the wire.
The fix is to retain the features capability on
reset, and get it only once from firmware on the
vdpa_dev_add path.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Si-Wei Liu
Acked-by: Eli Cohen
Acked-by: Jason Wang
---
d
s series;
repost with updated commit message
v1->v2: move feature capability query to probing (Eli)
Si-Wei Liu (1):
vdpa/mlx5: fix feature negotiation across device reset
drivers/vdpa/mlx5/net/mlx5_vnet.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
On 10/19/2022 9:38 PM, Jason Wang wrote:
On Wed, Oct 19, 2022 at 8:56 AM Si-Wei Liu wrote:
In order to allow live migration orchestration software to export the
initial set of vdpa attributes with which the device was created, it
will be useful if the vdpa tool can report the config on
On 10/19/2022 10:25 PM, Jason Wang wrote:
On Wed, Oct 19, 2022 at 8:56 AM Si-Wei Liu wrote:
Live migration of vdpa would typically require re-instate vdpa
device with an idential set of configs on the destination node,
same way as how source node created the device in the first
place. In
On 10/19/2022 10:20 PM, Jason Wang wrote:
On Wed, Oct 19, 2022 at 8:56 AM Si-Wei Liu wrote:
Just as _vdpa_register_device taking @nvqs as the number of queues
I wonder if it's better to embed nvqs in the config structure.
Hmmm, the config structure is mostly for containin
ation
are carried over. Which will be used in subsequent commits.
Signed-off-by: Si-Wei Liu
---
include/linux/vdpa.h | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
index 6d0f5e4..9f519a3 100644
--- a/in
v3:
- Rename vdev_cfg to init_cfg and also related function (Jason)
- Change "virtio_config" to "initial_config" in command example
output (Parav)
v1 -> v2:
- Revised example output to export all config attributes under a
json object (Jason)
---
Si-Wei Liu
e vdpasim0 mtu 5000 max_vqp 2
Error: vdpa: Some provided attributes are not supported.
kernel answers: Operation not supported
$ vdpa dev add mgmtdev vdpasim_net name vdpasim0 max_vqp 2
Error: vdpa: All provided attributes are not supported.
kernel answers: Operation not supported
Signed-off-by:
Just as _vdpa_register_device taking @nvqs as the number of queues
to feed userspace inquery via vdpa_dev_fill(), we can follow the
same to stash config attributes in struct vdpa_device at the time
of vdpa registration.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/ifcvf/ifcvf_main.c | 2
",
"vendor_id": ,
"max_vqs": 9,
"max_vq_size": 256,
"initial_config": {
"mac": "e4:11:c6:d3:45:f0",
"max_vq_pairs": 4
}
}
On 10/20/2022 2:13 PM, Parav Pandit wrote:
From: Si-Wei Liu
Sent: Thursday, October 20, 2022 2:12 PM
On 10/19/2022 10:25 PM, Jason Wang wrote:
On Wed, Oct 19, 2022 at 8:56 AM Si-Wei Liu
wrote:
Live migration of vdpa would typically require re-instate vdpa device
with an idential set of
On 10/20/2022 7:51 PM, Jason Wang wrote:
On Fri, Oct 21, 2022 at 2:45 AM Si-Wei Liu wrote:
On 10/19/2022 10:20 PM, Jason Wang wrote:
On Wed, Oct 19, 2022 at 8:56 AM Si-Wei Liu wrote:
Just as _vdpa_register_device taking @nvqs as the number of queues
I wonder if it's better to
On 10/24/2022 1:40 AM, Jason Wang wrote:
On Sat, Oct 22, 2022 at 7:49 AM Si-Wei Liu wrote:
Live migration of vdpa would typically require re-instate vdpa
device with an idential set of configs on the destination node,
same way as how source node created the device in the first
place. In
On 10/24/2022 7:24 PM, Jason Wang wrote:
On Tue, Oct 25, 2022 at 3:14 AM Si-Wei Liu wrote:
On 10/24/2022 1:40 AM, Jason Wang wrote:
On Sat, Oct 22, 2022 at 7:49 AM Si-Wei Liu wrote:
Live migration of vdpa would typically require re-instate vdpa
device with an idential set of configs on
On 10/25/2022 9:44 PM, Jason Wang wrote:
在 2022/10/26 09:10, Si-Wei Liu 写道:
On 10/24/2022 7:24 PM, Jason Wang wrote:
On Tue, Oct 25, 2022 at 3:14 AM Si-Wei Liu
wrote:
On 10/24/2022 1:40 AM, Jason Wang wrote:
On Sat, Oct 22, 2022 at 7:49 AM Si-Wei Liu
wrote:
Live migration of vdpa
On 10/27/2022 1:47 AM, Jason Wang wrote:
On Thu, Oct 27, 2022 at 2:31 PM Si-Wei Liu wrote:
On 10/25/2022 9:44 PM, Jason Wang wrote:
在 2022/10/26 09:10, Si-Wei Liu 写道:
On 10/24/2022 7:24 PM, Jason Wang wrote:
On Tue, Oct 25, 2022 at 3:14 AM Si-Wei Liu
wrote:
On 10/24/2022 1:40 AM
On 11/16/2022 7:33 PM, Jason Wang wrote:
This patch allows device features to be provisioned via vdpa. This
will be useful for preserving migration compatibility between source
and destination:
# vdpa dev add name dev1 mgmtdev pci/:02:00.0 device_features 0x30002
Miss the actual "vdp
On 11/22/2022 7:35 PM, Jason Wang wrote:
On Wed, Nov 23, 2022 at 6:29 AM Si-Wei Liu wrote:
On 11/16/2022 7:33 PM, Jason Wang wrote:
This patch allows device features to be provisioned via vdpa. This
will be useful for preserving migration compatibility between source
and destination
already hinders
further vdpa tool development and iproute integration around
VDPA_ATTR_DEV_FEATURES...
Thanks,
-Siwei
On 10/11/2022 8:07 PM, Jason Wang wrote:
On Tue, Oct 11, 2022 at 2:32 AM Si-Wei Liu wrote:
We can merge VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES with
VDPA_ATTR_DEV_FEATURES which is
Sorry for getting back late due to the snag of the holidays.
On 11/23/2022 11:13 PM, Jason Wang wrote:
On Thu, Nov 24, 2022 at 6:53 AM Si-Wei Liu wrote:
On 11/22/2022 7:35 PM, Jason Wang wrote:
On Wed, Nov 23, 2022 at 6:29 AM Si-Wei Liu wrote:
On 11/16/2022 7:33 PM, Jason Wang wrote
On 12/4/2022 10:46 PM, Jason Wang wrote:
On Thu, Dec 1, 2022 at 8:53 AM Si-Wei Liu wrote:
Sorry for getting back late due to the snag of the holidays.
No worries :)
On 11/23/2022 11:13 PM, Jason Wang wrote:
On Thu, Nov 24, 2022 at 6:53 AM Si-Wei Liu wrote:
On 11/22/2022 7:35 PM
On 12/5/2022 7:14 PM, Jason Wang wrote:
On Tue, Dec 6, 2022 at 9:43 AM Si-Wei Liu wrote:
On 12/4/2022 10:46 PM, Jason Wang wrote:
On Thu, Dec 1, 2022 at 8:53 AM Si-Wei Liu wrote:
Sorry for getting back late due to the snag of the holidays.
No worries :)
On 11/23/2022 11:13 PM, Jason
On 12/18/2022 10:31 PM, Michael S. Tsirkin wrote:
On Fri, Oct 28, 2022 at 04:23:49PM -0700, Si-Wei Liu wrote:
I can post a v3 that shows the code, it shouldn't be
too hard.
I take it another version of this patchset is planned?
Yes, I saw you just merged "vdpa: merge fu
Apologies, I was over booked for multiple things in parallel, and there
had been urgent internal priorities popped up at times for the past few
weeks. On the other hand, there were brokenness or incompleteness
identified around features provisioning while this series was being
developed, which
er to formalize migration compatibility
support at the driver level.
Thanks,
-Siwei
[1] [PATCH v3 0/4] vDPA: initial config export via "vdpa dev show"
https://lore.kernel.org/virtualization/1666392237-4042-1-git-send-email-si-wei@oracle.com/
---
Si-Wei Liu (6):
vdpa: fix improper err
The spec says:
status only exists if VIRTIO_NET_F_STATUS is set
Similar to MAC and MTU, vdpa_dev_net_config_fill() should read
STATUS conditionally depending on the feature bits.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/vdpa.c | 20 +++-
1 file changed, 15 insertions
e_features
without providing a corresponding @mac attribute, in which case the vdpa
vendor driver could load certain default value for attribute that is not
explicitly specified.
Generalize this check in vdpa core so that there's no duplicate code in
each vendor driver.
Signed-off-by: Si-Wei
Introduce VIRTIO_DEVICE_F_MASK bitmask used for identification
of per-device features. Feature bits VIRTIO_TRANSPORT_F_START
through VIRTIO_TRANSPORT_F_END are reserved for transport
features hence are not counted as per-device features against
the 64bit feature space.
Signed-off-by: Si-Wei Liu
201 - 300 of 483 matches
Mail list logo
