ack")
Cc: xieyon...@bytedance.com
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
b/drivers/vdpa/vdpa_user/vduse_dev.c
index 5f5c21674fdc..cdca94e85762 1006
On 6/15/23 09:25, Yongji Xie wrote:
On Wed, Jun 14, 2023 at 7:52 PM Maxime Coquelin
wrote:
vduse_vdpa_set_vq_affinity callback can be called
with NULL value as cpu_mask when deleting the vduse
device.
This patch clears virtqueue's IRQ affinity mask value
instead of dereferencing
ffinity callback")
Cc: xieyon...@bytedance.com
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
b/drivers/vdpa/vdpa_user/vduse_dev.c
index 5f5c21674fdc..0d84
not support VERSION_1 (Jason)
Maxime Coquelin (2):
vduse: validate block features only with block devices
vduse: enable Virtio-net device type
drivers/vdpa/vdpa_user/vduse_dev.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
--
2.4
This patch is preliminary work to enable network device
type support to VDUSE.
As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk device type.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 9
This patch adds Virtio-net device type to the supported
devices types. Initialization fails if the device does
not support VIRTIO_F_VERSION_1 feature, in order to
guarantee the configuration space is read-only.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 6 ++
1
On 7/3/23 08:44, Jason Wang wrote:
On Sun, Jul 2, 2023 at 9:37 PM Michael S. Tsirkin wrote:
On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote:
This small series enables virtio-net device type in VDUSE.
With it, basic operation have been tested, both with
virtio-vdpa and vhost
On 7/3/23 23:45, Michael S. Tsirkin wrote:
On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote:
On 7/3/23 08:44, Jason Wang wrote:
On Sun, Jul 2, 2023 at 9:37 PM Michael S. Tsirkin wrote:
On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote:
This small series
On 7/4/23 11:59, Michael S. Tsirkin wrote:
On Tue, Jul 04, 2023 at 10:43:07AM +0200, Maxime Coquelin wrote:
On 7/3/23 23:45, Michael S. Tsirkin wrote:
On Mon, Jul 03, 2023 at 09:43:49AM +0200, Maxime Coquelin wrote:
On 7/3/23 08:44, Jason Wang wrote:
On Sun, Jul 2, 2023 at 9:37 PM
/cacgkmetgrxn3ppwsdo4oosnssljfembez0wvjgrr3whu+qa...@mail.gmail.com/T/
v1 -> v2 changes:
=
- Add a patch to disable CVQ (Michael)
RFC -> v1 changes:
==
- Fail device init if it does not support VERSION_1 (Jason)
Maxime Coquelin (3):
vduse: validate block features only with
This patch adds Virtio-net device type to the supported
devices types. Initialization fails if the device does
not support VIRTIO_F_VERSION_1 feature, in order to
guarantee the configuration space is read-only.
Acked-by: Jason Wang
Reviewed-by: Xie Yongji
Signed-off-by: Maxime Coquelin
This patch is preliminary work to enable network device
type support to VDUSE.
As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk device type.
Acked-by: Jason Wang
Reviewed-by: Xie Yongji
Signed-off-by: Maxime Coquelin
. Until it is completed,
let's disable control virtqueue and features that depend on
it.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
b/drivers/vdpa/vdpa
On 7/4/23 18:43, Michael S. Tsirkin wrote:
On Tue, Jul 04, 2023 at 06:40:45PM +0200, Maxime Coquelin wrote:
Virtio-net driver control queue implementation is not safe
when used with VDUSE. If the VDUSE application does not
reply to control queue messages, it currently ends up
hanging the
This patch adds Virtio-net device type to the supported
devices types. Initialization fails if the device does
not support VIRTIO_F_VERSION_1 feature, in order to
guarantee the configuration space is read-only.
Acked-by: Jason Wang
Reviewed-by: Xie Yongji
Signed-off-by: Maxime Coquelin
t support VERSION_1 (Jason)
Maxime Coquelin (3):
vduse: validate block features only with block devices
vduse: enable Virtio-net device type
vduse: Temporarily disable control queue features
drivers/vdpa/vdpa_user/vduse_dev.c | 51 +++---
1 file changed, 47 insertions(+), 4
This patch is preliminary work to enable network device
type support to VDUSE.
As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk device type.
Acked-by: Jason Wang
Reviewed-by: Xie Yongji
Signed-off-by: Maxime Coquelin
. Until it is completed,
let's filter out control virtqueue and features that depend
on it by keeping only features known to be supported.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 36 ++
1 file changed, 36 insertions(+)
diff --
vduse: Introduce VDUSE - vDPA Device in Userspace")
Cc: xieyon...@bytedance.com
Suggested-by: Jason Wang
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
b/dr
Hello Cindy,
On 6/28/23 08:59, Cindy Lu wrote:
From: Your Name
this struct is to save the reconnect info struct, in this
struct saved the page info that alloc to save the
reconnect info
Signed-off-by: Cindy Lu
---
drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++
1 file changed, 7 insertion
On 6/28/23 08:59, Cindy Lu wrote:
From: Your Name
Add the operation for mmap, The user space APP will
use this function to map the pages to userspace
Signed-off-by: Cindy Lu
---
drivers/vdpa/vdpa_user/vduse_dev.c | 49 ++
1 file changed, 49 insertions(+)
dif
On 7/20/23 23:02, Michael S. Tsirkin wrote:
On Thu, Jul 20, 2023 at 01:26:20PM -0700, Shannon Nelson wrote:
On 7/20/23 1:38 AM, Jason Wang wrote:
Adding cond_resched() to the command waiting loop for a better
co-operation with the scheduler. This allows to give CPU a breath to
run other tas
On 7/21/23 16:45, Michael S. Tsirkin wrote:
On Fri, Jul 21, 2023 at 04:37:00PM +0200, Maxime Coquelin wrote:
On 7/20/23 23:02, Michael S. Tsirkin wrote:
On Thu, Jul 20, 2023 at 01:26:20PM -0700, Shannon Nelson wrote:
On 7/20/23 1:38 AM, Jason Wang wrote:
Adding cond_resched() to the
On 7/21/23 17:10, Michael S. Tsirkin wrote:
On Fri, Jul 21, 2023 at 04:58:04PM +0200, Maxime Coquelin wrote:
On 7/21/23 16:45, Michael S. Tsirkin wrote:
On Fri, Jul 21, 2023 at 04:37:00PM +0200, Maxime Coquelin wrote:
On 7/20/23 23:02, Michael S. Tsirkin wrote:
On Thu, Jul 20, 2023 at
On 8/11/23 00:00, Jakub Kicinski wrote:
On Thu, 10 Aug 2023 17:42:11 -0400 Michael S. Tsirkin wrote:
Directly into the stack? I thought VDUSE is vDPA in user space,
meaning to get to the kernel the packet has to first go thru
a virtio-net instance.
yes. is that a sufficient filter in your o
On 8/29/23 19:05, Michael S. Tsirkin wrote:
On Tue, Aug 29, 2023 at 03:34:06PM +0200, Maxime Coquelin wrote:
On 8/11/23 00:00, Jakub Kicinski wrote:
On Thu, 10 Aug 2023 17:42:11 -0400 Michael S. Tsirkin wrote:
Directly into the stack? I thought VDUSE is vDPA in user space,
meaning to get
On 9/25/23 06:15, Cindy Lu wrote:
On Tue, Sep 12, 2023 at 3:39 PM Jason Wang wrote:
On Tue, Sep 12, 2023 at 11:00 AM Cindy Lu wrote:
In VDUSE_VQ_GET_INFO, the driver will sync the last_avail_idx
with reconnect info, After mapping the reconnect pages to userspace
The userspace App will upd
On 9/25/23 04:57, Jason Wang wrote:
On Thu, Sep 21, 2023 at 10:07 PM Cindy Lu wrote:
On Mon, Sep 18, 2023 at 4:49 PM Jason Wang wrote:
On Tue, Sep 12, 2023 at 11:01 AM Cindy Lu wrote:
In VDUSE_GET_RECONNECT_INFO, the Userspace App can get the map size
and The number of mapping memory p
On 9/12/23 09:39, Jason Wang wrote:
On Tue, Sep 12, 2023 at 11:00 AM Cindy Lu wrote:
In VDUSE_VQ_GET_INFO, the driver will sync the last_avail_idx
with reconnect info, After mapping the reconnect pages to userspace
The userspace App will update the reconnect_time in
struct vhost_reconnect_vr
. Until it is completed,
let's disable control virtqueue and features that depend on
it.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 37 ++
1 file changed, 37 insertions(+)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
b/drivers
This patch adds Virtio-net device type to the supported
devices types. Initialization fails if the device does
not support VIRTIO_F_VERSION_1 feature, in order to
guarantee the configuration space is read-only.
Acked-by: Jason Wang
Reviewed-by: Xie Yongji
Signed-off-by: Maxime Coquelin
w list instead of deny list (Michael)
v1 -> v2 changes:
=
- Add a patch to disable CVQ (Michael)
RFC -> v1 changes:
==
- Fail device init if it does not support VERSION_1 (Jason)
Maxime Coquelin (4):
vduse: validate block features only with block devices
v
This patch introduces LSM hooks for devices creation,
destruction and opening operations, checking the
application is allowed to perform these operations for
the Virtio device type.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 12 +++
include/linux
This patch is preliminary work to enable network device
type support to VDUSE.
As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk device type.
Acked-by: Jason Wang
Reviewed-by: Xie Yongji
Signed-off-by: Maxime Coquelin
On 10/21/23 00:20, Casey Schaufler wrote:
On 10/20/2023 8:58 AM, Maxime Coquelin wrote:
This patch introduces LSM hooks for devices creation,
destruction and opening operations, checking the
application is allowed to perform these operations for
the Virtio device type.
Why do you think
On 10/21/23 00:07, Casey Schaufler wrote:
On 10/20/2023 8:58 AM, Maxime Coquelin wrote:
This patch is preliminary work to enable network device
type support to VDUSE.
As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk
On 10/23/23 05:08, Jason Wang wrote:
On Fri, Oct 20, 2023 at 11:58 PM Maxime Coquelin
wrote:
Virtio-net driver control queue implementation is not safe
when used with VDUSE. If the VDUSE application does not
reply to control queue messages, it currently ends up
hanging the kernel thread
On 10/23/23 17:13, Casey Schaufler wrote:
On 10/23/2023 12:28 AM, Maxime Coquelin wrote:
On 10/21/23 00:20, Casey Schaufler wrote:
On 10/20/2023 8:58 AM, Maxime Coquelin wrote:
This patch introduces LSM hooks for devices creation,
destruction and opening operations, checking the
On 10/24/23 17:30, Casey Schaufler wrote:
On 10/24/2023 2:49 AM, Maxime Coquelin wrote:
On 10/23/23 17:13, Casey Schaufler wrote:
On 10/23/2023 12:28 AM, Maxime Coquelin wrote:
On 10/21/23 00:20, Casey Schaufler wrote:
On 10/20/2023 8:58 AM, Maxime Coquelin wrote:
This patch
On 11/2/23 19:59, Michael S. Tsirkin wrote:
On Thu, Nov 02, 2023 at 06:56:59PM +0100, Maxime Coquelin wrote:
On 10/24/23 17:30, Casey Schaufler wrote:
On 10/24/2023 2:49 AM, Maxime Coquelin wrote:
On 10/23/23 17:13, Casey Schaufler wrote:
On 10/23/2023 12:28 AM, Maxime Coquelin wrote
cast+0x217/0x340
[<0>] netlink_sendmsg+0x23e/0x4a0
[<0>] sock_sendmsg+0x8f/0xa0
[<0>] __sys_sendto+0xfc/0x170
[<0>] __x64_sys_sendto+0x20/0x30
[<0>] do_syscall_64+0x59/0x90
[<0>] entry_SYSCALL_64_after_hwframe+0x72/0xdc
Once fixed on DPDK side (you can use my vduse_v1 branc
On 4/13/23 15:02, Maxime Coquelin wrote:
Hi Jason,
On 4/13/23 08:40, Jason Wang wrote:
Hi all:
The code used to busy poll for cvq command which turns out to have
several side effects:
1) infinite poll for buggy devices
2) bad interaction with scheduler
So this series tries to use sleep
This patch adds Virtio-net device type to the supported
devices types.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
b/drivers/vdpa/vdpa_user/vduse_dev.c
index 6fa598a03d8e
=%2A&archive=both
[1]:
https://lore.kernel.org/lkml/cacgkmetgrxn3ppwsdo4oosnssljfembez0wvjgrr3whu+qa...@mail.gmail.com/T/
Maxime Coquelin (2):
vduse: validate block features only with block devices
vduse: enable Virtio-net device type
drivers/vdpa/vdpa_user/vduse_dev.c | 11 +++
1
This patch is preliminary work to enable network device
type support to VDUSE.
As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk device type.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 9
On 4/20/23 06:06, Jason Wang wrote:
On Wed, Apr 19, 2023 at 9:43 PM Maxime Coquelin
wrote:
This patch is preliminary work to enable network device
type support to VDUSE.
As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk
On 4/20/23 06:34, Jason Wang wrote:
On Wed, Apr 19, 2023 at 9:43 PM Maxime Coquelin
wrote:
This small series enables virtio-net device type in VDUSE.
With it, basic operation have been tested, both with
virtio-vdpa and vhost-vdpa using DPDK Vhost library series
adding VDUSE support [0
On 4/20/23 10:13, Yongji Xie wrote:
On Wed, Apr 19, 2023 at 9:44 PM Maxime Coquelin
wrote:
This small series enables virtio-net device type in VDUSE.
With it, basic operation have been tested, both with
virtio-vdpa and vhost-vdpa using DPDK Vhost library series
adding VDUSE support [0
On 4/21/23 07:51, Jason Wang wrote:
On Thu, Apr 20, 2023 at 10:16 PM Maxime Coquelin
wrote:
On 4/20/23 06:34, Jason Wang wrote:
On Wed, Apr 19, 2023 at 9:43 PM Maxime Coquelin
wrote:
This small series enables virtio-net device type in VDUSE.
With it, basic operation have been tested
If the VDUSE application provides a smaller config space
than the driver expects, the driver may use uninitialized
memory from the stack.
This patch prevents it by initializing the buffer passed by
the driver to store the config value.
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user
On 8/27/22 08:54, Dan Carpenter wrote:
On Fri, Aug 26, 2022 at 06:16:05PM +0200, Maxime Coquelin wrote:
If the VDUSE application provides a smaller config space
than the driver expects, the driver may use uninitialized
memory from the stack.
This patch prevents it by initializing the buffer
...@bytedance.com
Cc: sta...@vger.kernel.org # v5.15+
Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Acked-by: Jason Wang
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/dr
On 8/29/22 09:48, Greg KH wrote:
On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote:
If the VDUSE application provides a smaller config space
than the driver expects, the driver may use uninitialized
memory from the stack.
This patch prevents it by initializing the buffer passed
On 8/31/22 17:46, Michael S. Tsirkin wrote:
On Wed, Aug 31, 2022 at 05:01:11PM +0200, Maxime Coquelin wrote:
On 8/29/22 09:48, Greg KH wrote:
On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote:
If the VDUSE application provides a smaller config space
than the driver expects
...@vger.kernel.org # v5.15+
Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Reviewed-by: Xie Yongji
Acked-by: Jason Wang
Signed-off-by: Maxime Coquelin
---
drivers/vdpa/vdpa_user/vduse_dev.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/dr
[ 1398.943845] R13: 7ffd0948e6a0 R14: R15:
[ 1398.951809] Modules linked in: vxlan ip6_udp_tunnel udp_tunnel
ip_vs_sh ip_vs_wrr ip_vs_rr ip_vs xt_comment xt_mark nf_tables xt_nat vetht
[ 1398.951847] ghash_clmulni_intel iTCO_vendor_support mlx5_core
56 matches
Mail list logo
