Re: [RESEND PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem

b/include/drm/drm_mode_config.h > @@ -969,4 +969,10 @@ static inline int drm_mode_config_init(struct drm_device > *dev) > void drm_mode_config_reset(struct drm_device *dev); > void drm_mode_config_cleanup(struct drm_device *dev); > > +#ifdef CONFIG_VGA_CONSOLE > +extern bool

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

04,8 +104,9 @@ static int virtio_gpu_probe(struct virtio_device *vdev) > struct drm_device *dev; > int ret; > > - if (vgacon_text_force() && virtio_gpu_modeset == -1) > - return -EINVAL; > + ret = drm_drv_enabled(&driver); > + if (r

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

amp;& i915_modparams.modeset == -1) >> +ret = drm_drv_enabled(&driver); > > You pass the local driver variable here - which looks wrong as this is > not the same as the driver variable declared in another file. Indeed. > Maybe move the check to new functio

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

name will clash. > > Just add a > const drm_driver * i915_drm_driver(void) > { > return &driver; > } > > And then use this function to access the drm_driver variable. Agreed on the general principle of exposing interfaces over data. But... why? I'm

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

bled\n", driver->name); > + return -ENODEV; > + } > + > + return 0; > +} > +EXPORT_SYMBOL(drm_drv_enabled); The name implies a bool return, but it's not. if (drm_drv_enabled(...)) { /* surprise, it'

Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem

ode_force; >> static bool vga_hardscroll_enabled; >> static bool vga_hardscroll_user_enable = true; >> >> -bool vgacon_text_force(void) >> -{ >> -return vgacon_text_mode_force; >> -} >> -EXPORT_SYMBOL(v

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

On Fri, 05 Nov 2021, Javier Martinez Canillas wrote: > Hello Thomas, > > On 11/5/21 09:43, Thomas Zimmermann wrote: >> Hi >> >> Am 04.11.21 um 21:09 schrieb Javier Martinez Canillas: >>> Hello Jani, >>> >>> On 11/4/21 20:57, Jani Nikula wro

Re: [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

1 + > include/uapi/linux/netfilter/xt_sctp.h| 1 + > include/xen/hvm.h | 1 + > kernel/kallsyms.c | 3 +- > 94 files changed, 255 insertions(+), 79 deletions(-) > create mode 100644 include/linux/NULL.h > create mode 100644 include/linux/array_size.h > create mode 100644 include/linux/memberof.h > create mode 100644 include/linux/offsetof.h > create mode 100644 include/linux/offsetofend.h > create mode 100644 include/linux/sizeof_field.h > create mode 100644 include/linux/typeof_member.h -- Jani Nikula, Intel Open Source Graphics Center ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, 19 Nov 2021, "Alejandro Colomar (man-pages)" wrote: > Hi Jani, > > On 11/19/21 13:47, Jani Nikula wrote: >> On Fri, 19 Nov 2021, Alejandro Colomar wrote: >>> In the first and second commits >>> I changed a lot of stuff in many parts, >>&g

Re: [PATCH v2 09/20] drm/i915: Remove references to struct drm_device.pdev

On Tue, 08 Dec 2020, Thomas Zimmermann wrote: > ping for a review of the i915 patches What did you have in mind regarding merging the series? Should we just pick the patches up? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Cen

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

for v11. >> > > Applied patches 1-2 to misc-fixes and patches 3-7 to misc-next, with the > review comments addressed. Please resolve the drm-tip rebuild conflict [1]. BR, Jani. [1] https://paste.debian.net/1272275/ -- Jani Nikula, Intel Open Source Graphics Center ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 07/38] drm: handle HAS_IOPORT dependencies

accfa52e78c5..9da89732c5ac 100644 > --- a/drivers/gpu/drm/tiny/cirrus.c > +++ b/drivers/gpu/drm/tiny/cirrus.c > @@ -308,8 +308,10 @@ static int cirrus_mode_set(struct cirrus_device *cirrus, > > cirrus_set_start_address(cirrus, 0); > > +#ifdef CONFIG_HAS_IOPORT > /* Unblank (needed on S3 resume, vgabios doesn't do it then) */ > outb(0x20, 0x3c0); > +#endif > > drm_dev_exit(idx); > return 0; -- Jani Nikula, Intel Open Source Graphics Center ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] drm: Split out drm_probe_helper.h

I > expect. > > v3: Rebase on top of atomic bochs. > > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-ker...@lists.infradead.org > Cc:

Re: [PATCH] gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache_zalloc

ly add the newline while applying. Review is much more valuable than nitpicking on the commit message. Reviewed-by: Jani Nikula > >> Signed-off-by: Sabyasachi Gupta >> --- >> drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [PATCH v3] drm/bochs: add edid support.

count = drm_add_modes_noedid(connector, 8192, 8192); > + drm_set_preferred_mode(connector, defx, defy); > + } > return count; > } > > @@ -271,6 +278,11 @@ static void bochs_connector_init(struct drm_device *dev) > drm_connector_helper_add(connector, >

Re: [PATCH v3] drm/bochs: add edid support.

On Tue, 30 Oct 2018, Daniel Vetter wrote: > On Mon, Oct 29, 2018 at 09:05:20PM +0100, Gerd Hoffmann wrote: >> On Mon, Oct 29, 2018 at 07:44:28PM +0200, Jani Nikula wrote: >> > On Mon, 29 Oct 2018, Gerd Hoffmann wrote: >> > > Recent qemu (latest master branch, upc

Re: [PATCH 3/9] drm: replace "drm_dev_unref" function with "drm_dev_put"

r developers to work on drm-tip because it contains the latest stuff in drm core, i915, amd, most of the small drivers, as well as sound. It's a bit like "linux-next for graphics". And you don't really have to care about the merge cycles with that. But YMMV, it probably doesn&#x

Re: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue.

If you instead select something with dependencies, it'll be right most of the time, and it's "convenient", until it breaks. (And hey, it usually breaks for someone else with some other config, so it's still convenient for you.) Perhaps kconfig should complain about selecting visible symbols and symbols with dependencies. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] drm/virtio: print a single line with device features

; : '-'); > > Maybe we should move the various yesno/onoff/enableddisabled helpers from > i915_utils.h to drm_utils.h and use them more widely? I'm trying to take it one step further by adding them to include/linux/string-choice.h [1]. Maybe, uh, fourth time's the

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

. Are you sure it's okay to make the change you're proposing? Anyway, due to the time of year and all, I'd like to ask you to file a bug against i915 at [1] so this is not forgotten, and please let's not merge the changes before this is resolved. Thanks, Jani. [1] https://

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

On Mon, 23 Dec 2019, Robin Murphy wrote: > On 2019-12-23 10:37 am, Jani Nikula wrote: >> On Sat, 21 Dec 2019, Tom Murphy wrote: >>> This patchset converts the intel iommu driver to the dma-iommu api. >>> >>> While converting the driver I exposed a bug in the

Re: [PATCH][next] drm: Replace zero-length array with flexible-array member

e/drm/drm_displayid.h | 2 +- > include/uapi/drm/i915_drm.h | 4 ++-- Not sure it's worth touching uapi headers. They're full of both [0] and []. Again, please at least split it to a separate patch to be decided separately. BR, Jani.