RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

Hi Halil, Commit 4058cf08945 introduced a check for detecting crypto completion function called with enable BH, and indeed the virtio-crypto driver didn't disable BH, which needs a patch to fix it. P.S.: https://lore.kernel.org/lkml/20220221120833.2618733-5-cla...@baylibre.com/T/ Regards, -Go

[PATCH] crypto: virtio-crypto: call finalize with bh disabled

Doing ipsec produces a spinlock recursion warning. This is due to not disabling BH during crypto completion function. Fixes: 59ca6c93387d3 ("virtio-crypto: implement RSA algorithm") Reported-by: Halil Pasic Signed-off-by: Gonglei --- drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 3 ++-

RE: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

> -Original Message- > From: Halil Pasic [mailto:pa...@linux.ibm.com] > Sent: Wednesday, September 27, 2023 12:42 AM > To: Gonglei (Arei) > Cc: Herbert Xu ; linux-cry...@vger.kernel.org; > Marc Hartmayer ; Michael S. Tsirkin > ; Jason Wang ; > virtualization@lists.linux-foundation.org;

RE: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, September 27, 2023 1:14 AM > To: Halil Pasic > Cc: Gonglei (Arei) ; Herbert Xu > ; linux-cry...@vger.kernel.org; Marc > Hartmayer ; Jason Wang > ; virtualization@lists.linux-foundation.org; > lin

RE: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, September 28, 2023 9:24 AM > To: Michael S. Tsirkin ; Gonglei (Arei) > > Cc: Halil Pasic ; Herbert Xu > ; linux-cry...@vger.kernel.org; Marc > Hartmayer ; Jason Wang > ; virtualization@lists.linux

RE: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

Ping Herbert. Thanks. > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, September 27, 2023 5:18 PM > To: 'Halil Pasic' > Cc: Herbert Xu ; linux-cry...@vger.kernel.org; > Marc Hartmayer ; Michael S. Tsirkin > ; Jason Wang ; > virtualization@lists.linux-foundation.org; linux

RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, November 1, 2023 9:26 PM > To: Halil Pasic > Cc: Gonglei (Arei) ; Herbert Xu > ; Jason Wang ; > virtualization@lists.linux-foundation.org; linux-ker...@vger.kernel.org; > linux-cry...@vger.kernel

RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, November 2, 2023 9:17 PM > To: Gonglei (Arei) > Cc: Halil Pasic ; Herbert Xu > ; Jason Wang ; > virtualization@lists.linux-foundation.org; linux-ker...@vger.kernel.org; > linux-cry...@vger.kernel.

RE: [PATCH 1/3] virtio_crypto: Introduce VIRTIO_CRYPTO_NOSPC

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, January 21, 2022 10:25 AM > To: m...@redhat.com; Gonglei (Arei) > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: [PATCH 2/3] virtio-crypto: introduce akcipher service

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, January 21, 2022 10:25 AM > To: m...@redhat.com; Gonglei (Arei) > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, February 10, 2022 4:18 PM > To: Gonglei (Arei) > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; > helei.si...@byt

RE: [PATCH v2 3/3] virtio-crypto: implement RSA algorithm

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:41 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: [PATCH v2 2/3] virtio-crypto: introduce akcipher service

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:41 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: [PATCH v2 1/3] virtio-crypto: header update

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, February 11, 2022 4:44 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; qemu-de...@nongnu.org; > helei.s

RE: PING: [PATCH v2 3/3] virtio-crypto: implement RSA algorithm

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Tuesday, March 1, 2022 6:26 PM > To: Gonglei (Arei) > Cc: jasow...@redhat.com; m...@redhat.com; > virtualization@lists.linux-foundation.org; linux-cry...@vger.kernel.org; > linux-ker...@vger.kernel.org; hele

RE: [PATCH v3 2/4] virtio-crypto: introduce akcipher service

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Wednesday, March 2, 2022 11:39 AM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: [PATCH v3 3/4] virtio-crypto: implement RSA algorithm

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Wednesday, March 2, 2022 11:39 AM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: [PATCH v3 4/4] virtio-crypto: rename skcipher algs

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Wednesday, March 2, 2022 11:39 AM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >

RE: [PATCH] virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session()

> -Original Message- > From: Wei Yongjun [mailto:weiyong...@huaweicloud.com] > Sent: Monday, November 14, 2022 7:08 PM > To: Michael S. Tsirkin ; Jason Wang > ; Gonglei (Arei) ; > Herbert Xu ; David S. Miller > ; zhenwei pi > Cc: weiyongjun (A) ; > virtualization@lists.linux-foundation.

RE: [PATCH] crypto: virtio - Use helper to set reqsize

> -Original Message- > From: Herbert Xu [mailto:herb...@gondor.apana.org.au] > Sent: Tuesday, November 22, 2022 5:42 PM > To: Gonglei (Arei) ; > virtualization@lists.linux-foundation.org; Linux Crypto Mailing List > > Subject: [PATCH] crypto: virtio - Use helper to set reqsize > > The v

RE: [PATCH v3 4/5] virtio-crypto: adjust dst_len at ops callback

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, April 21, 2022 6:40 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; > li

RE: PING: [PATCH v4 0/5] virtio-crypto: Improve performance

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 10:35 AM > To: Gonglei (Arei) ; m...@redhat.com; > jasow...@redhat.com > Cc: herb...@gondor.apana.org.au; linux-ker...@vger.kernel.org; > virtualization@lists.linux-foundation.org; linu

RE: [PATCH v5 1/5] virtio-crypto: change code style

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; > linux

RE: [PATCH v5 2/5] virtio-crypto: use private buffer for control request

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; > linux

RE: [PATCH v5 3/5] virtio-crypto: wait ctrl queue instead of busy polling

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; > linux

RE: [PATCH v5 4/5] virtio-crypto: adjust dst_len at ops callback

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; > linux

RE: [PATCH v5 5/5] virtio-crypto: enable retry for virtio-crypto-dev

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, May 5, 2022 5:24 PM > To: Gonglei (Arei) ; m...@redhat.com > Cc: jasow...@redhat.com; herb...@gondor.apana.org.au; > linux-ker...@vger.kernel.org; virtualization@lists.linux-foundation.org; > linux

RE: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

> -Original Message- > From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr] > Sent: Sunday, May 22, 2022 9:07 PM > To: dan.carpen...@oracle.com; Gonglei (Arei) ; > Michael S. Tsirkin ; Jason Wang ; > Herbert Xu ; David S. Miller > ; zhenwei pi > Cc: linux-ker...@vger.kernel.o

RE: [PATCH v7 0/9] Introduce akcipher service for virtio-crypto

> -Original Message- > From: Daniel P. Berrangé [mailto:berra...@redhat.com] > Sent: Thursday, May 26, 2022 6:48 PM > To: Lei He > Cc: m...@redhat.com; Gonglei (Arei) ; > qemu-de...@nongnu.org; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; jasow...@redhat.com

RE: [PATCH 9/9] crypto: Introduce RSA algorithm

> -Original Message- > From: Lei He [mailto:helei.si...@bytedance.com] > Sent: Wednesday, May 25, 2022 5:01 PM > To: m...@redhat.com; Gonglei (Arei) ; > berra...@redhat.com > Cc: qemu-de...@nongnu.org; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; jasow...@re

RE: [PATCH v8 1/1] crypto: Introduce RSA algorithm

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Friday, May 27, 2022 4:48 PM > To: m...@redhat.com; Gonglei (Arei) > Cc: qemu-de...@nongnu.org; virtualization@lists.linux-foundation.org; > helei.si...@bytedance.com; berra...@redhat.com; zhenwei pi > > S

RE: RE: [PATCH v8 1/1] crypto: Introduce RSA algorithm

> -Original Message- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Tuesday, May 31, 2022 9:48 AM > To: Gonglei (Arei) > Cc: qemu-de...@nongnu.org; m...@redhat.com; > virtualization@lists.linux-foundation.org; helei.si...@bytedance.com; > berra...@redhat.com > Subject: Re:

RE: [PATCH] crypto-virtio: fix memory-leak

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, August 16, 2022 4:43 PM > To: Lei He > Cc: Gonglei (Arei) ; > herb...@gondor.apana.org.au; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; >