From: Rusty Russell <[EMAIL PROTECTED]>
Date: Mon, 7 Apr 2008 17:24:51 +1000
> On Monday 07 April 2008 15:13:44 Herbert Xu wrote:
> > On second thought, this is not going to work. The network stack
> > can clone individual pages out of this skb and put it into a new
> > skb. Therefore whatever s
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Sun, 20 Apr 2008 02:41:14 +1000
> If only there were some kind of, I don't know... summit... for kernel
> people...
I'm starting to disbelieve the myth that because we can discuss
technical issues on mailing lists, we should talk primarily about
pro
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Tue, 22 Apr 2008 05:06:16 +1000
> I'm not sure what the right number is here. Say worst case is header which
> goes over a page boundary then MAX_SKB_FRAGS in the skb, but for some reason
> that already has a +2:
>
> /* To allow 64K frame to be pac
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Tue, 22 Apr 2008 12:50:27 +1000
> But I was curious as to why the +2 in the MAX_SKB_FRAGS definition?
To be honest I have no idea.
When Alexey added the TSO changeset way back then, it had the
"+2", from the history-2.6 tree:
commit 80223d5186f73bf4
You sent these patches to "kvm-owner", ie. the mailing list owner, and
not the list itself which would be plain "kvm".
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtuali
From: Max Krasnyansky <[EMAIL PROTECTED]>
Date: Tue, 01 Jul 2008 21:59:02 -0700
> Dave, do you want me to put all outstanding TUN patches into a git tree so
> that you can pull them in one shot ?
> Otherwise if you're ok with applying them one by one please apply this one.
>
> Acked-by: Max Krasn
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Thu, 3 Jul 2008 11:34:14 +1000
> Add a IFF_VNET_HDR flag. This uses the same ABI as virtio_net (ie. prepending
> struct virtio_net_hdr to packets) to indicate GSO and checksum information.
>
> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
Also ap
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Thu, 3 Jul 2008 11:32:12 +1000
> The problem with introducing checksum offload and gso to tun is they
> need to set dev->features to enable GSO and/or checksumming, which is
> supposed to be done before register_netdevice(), ie. as part of
> TUNSETIFF.
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Thu, 3 Jul 2008 11:33:11 +1000
> ethtool is useful for setting (some) device fields, but it's
> root-only. Finer feature control is available through a tun-specific
> ioctl.
>
> (Includes Mark McLoughlin <[EMAIL PROTECTED]>'s fix to hold rtnl sem).
>
From: David Miller <[EMAIL PROTECTED]>
Date: Mon, 14 Jul 2008 22:16:02 -0700 (PDT)
> It doesn't apply cleanly to net-next-2.6, as I just tried to
> stick this into my tree.
Ignore this, I did something stupid.
___
Virtualiza
From: Max Krasnyansky <[EMAIL PROTECTED]>
Date: Sat, 12 Jul 2008 01:52:54 -0700
> This is on top of the latest and greatest :). Assuming virt folks are ok with
> the API this should go into 2.6.27.
Really? :-)
It doesn't apply cleanly to net-next-2.6, as I just tried to
stick this into my tree.
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 22 Jul 2008 19:41:47 -0400
> looks mostly OK, but stuff like the above should be
>
> (void __user *) arg
>
> Did you check this with sparse (Documentation/sparse.txt)?
Jeff, I already added this particular patch to the tree
a week or so ago
From: Max Krasnyansky <[EMAIL PROTECTED]>
Date: Tue, 22 Jul 2008 21:45:30 -0700
> Jeff Garzik wrote:
> > David Miller wrote:
> >> Jeff, I already added this particular patch to the tree
> >> a week or so ago.
> >
> > Yeah, later on in my queue we
From: Max Krasnyansky <[EMAIL PROTECTED]>
Date: Fri, 15 Aug 2008 11:00:19 -0700
> Rusty Russell wrote:
> > On Thursday 14 August 2008 00:30:16 Mark McLoughlin wrote:
> >> A very simple approach is attached; I did consider doing a TUNGETFLAGS
> >> that would return tun->flags, but I think it's nice
From: Mark McLoughlin <[EMAIL PROTECTED]>
Date: Wed, 26 Nov 2008 13:58:11 +
> We don't really have a max tx packet size limit, so allow configuring
> the device with up to 64k tx MTU.
>
> Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]>
Rusty, ACK?
If so, I'll toss this into net-next-2.6,
From: Gleb Natapov
Date: Sun, 14 Dec 2008 13:50:55 +0200
> It is undesirable to use TCP/IP for this purpose since network
> connectivity may not exist between host and guest and if it exists the
> traffic can be not routable between host and guest for security reasons
> or TCP/IP traffic can be f
From: Gleb Natapov
Date: Mon, 15 Dec 2008 09:48:19 +0200
> On Sun, Dec 14, 2008 at 10:44:36PM -0800, David Miller wrote:
> > You guys really need to rethink this. Either a stream protocol is a
> > workable solution to your problem, or it isn't.
>
> Stream protocol i
From: Anthony Liguori
Date: Mon, 15 Dec 2008 09:02:23 -0600
> There is already an AF_IUCV for s390.
This is a scarecrow and irrelevant to this discussion.
And this is exactly why I asked that any arguments in this thread
avoid talking about virtualization technology and why it's "special."
Thi
From: Anthony Liguori
Date: Mon, 15 Dec 2008 14:44:26 -0600
> We want this communication mechanism to be simple and reliable as we
> want to implement the backends drivers in the host userspace with
> minimum mess.
One implication of your statement here is that TCP is unreliable.
That's absolute
From: Anthony Liguori
Date: Mon, 15 Dec 2008 17:01:14 -0600
> No, TCP falls under the not simple category because it requires the
> backend to have access to a TCP/IP stack.
I'm at a loss for words if you need TCP in the hypervisor, if that's
what you're implying here.
You only need it in the g
From: Herbert Xu
Date: Mon, 20 Apr 2009 16:35:50 +0800
> On Thu, Apr 16, 2009 at 07:09:52PM +0800, Herbert Xu wrote:
>>
>> tun: Fix sk_sleep races when attaching/detaching
>
> That patch doesn't apply anymore because of contextual changes
> caused by the first patch. Here's an update.
>
> tun
From: Herbert Xu
Date: Mon, 20 Apr 2009 17:35:49 +0800
> On Mon, Apr 20, 2009 at 02:26:35AM -0700, David Miller wrote:
>>
>> Do you think these two patches are ready to go into net-2.6
>> now?
>
> I think so.
Gre
From: Rusty Russell
Date: Mon, 18 May 2009 22:18:47 +0930
> We check for finished xmit skbs on every xmit, or on a timer (unless
> the host promises to force an interrupt when the xmit ring is empty).
> This can penalize userspace tasks which fill their sockbuf. Not much
> difference with TSO, b
From: Rusty Russell
Date: Thu, 21 May 2009 16:27:05 +0930
> On Tue, 19 May 2009 12:10:13 pm David Miller wrote:
>> What you're doing by orphan'ing is creating a situation where a single
>> UDP socket can loop doing sends and monopolize the TX queue of a
>> device.
From: Patrick Ohly
Date: Mon, 01 Jun 2009 21:47:22 +0200
> On Fri, 2009-05-29 at 23:44 +0930, Rusty Russell wrote:
>> This patch adds skb_orphan to the start of dev_hard_start_xmit(): it
>> can be premature in the NETDEV_TX_BUSY case, but that's uncommon.
>
> Would it be possible to make the new
From: Rusty Russell
Date: Tue, 2 Jun 2009 23:38:29 +0930
> On Tue, 2 Jun 2009 04:55:53 pm David Miller wrote:
>> From: Patrick Ohly
>> Date: Mon, 01 Jun 2009 21:47:22 +0200
>>
>> > On Fri, 2009-05-29 at 23:44 +0930, Rusty Russell wrote:
>> >>
From: Rusty Russell
Date: Thu, 4 Jun 2009 13:24:57 +0930
> On Thu, 4 Jun 2009 06:32:53 am Eric Dumazet wrote:
>> Also, taking a reference on socket for each xmit packet in flight is very
>> expensive, since it slows down receiver in __udp4_lib_lookup(). Several
>> cpus are fighting for sk->refcnt
From: Eric Dumazet
Date: Thu, 04 Jun 2009 06:54:24 +0200
> We also can avoid the sock_put()/sock_hold() pair for each tx packet,
> to only touch sk_wmem_alloc (with appropriate atomic_sub_return() in
> sock_wfree()
> and atomic_dec_test in sk_free
>
> We could initialize sk->sk_wmem_alloc to on
From: Herbert Xu
Date: Fri, 3 Jul 2009 15:55:30 +0800
> Calling skb_orphan like this should be forbidden. Apart from the
> problems already raised, it is a sign that the driver is trying to
> paper over a more serious issue of not cleaning up skb's timely.
>
> Yes skb_orphan will work for the c
From: Herbert Xu
Date: Sat, 4 Jul 2009 11:08:30 +0800
> On Fri, Jul 03, 2009 at 08:02:54PM -0700, David Miller wrote:
>>
>> In particular the case of handling a device without usable TX
>> completion event indications is still quite troublesome.
> e
> Which particular
From: "Fischer, Anna"
Date: Thu, 13 Aug 2009 16:55:16 +
> This patch adds a 'hairpin' (also called 'reflective relay') mode
> port configuration to the Linux Ethernet bridge kernel module.
> A bridge supporting hairpin forwarding mode can send frames back
> out through the port the frame was
From: Herbert Xu
Date: Sun, 5 Jul 2009 11:34:08 +0800
> Here's an even crazier idea that doesn't use dummy descriptors.
>
> xmit(skb)
>
> if (TX queue contains no interrupting descriptor &&
> qdisc is empty)
> mark TX descriptor as interrupting
>
> if (TX qu
From: Herbert Xu
Date: Wed, 19 Aug 2009 13:19:26 +1000
> I'm in the process of repeating the same experiment with cxgb3
> which hopefully should let me turn interrupts off on descriptors
> while still reporting completion status.
Ok, I look forward to seeing your work however it turns out.
Once
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Sat, 17 Mar 2007 21:33:58 +1100
> On Fri, 2007-03-16 at 13:38 -0700, Jeremy Fitzhardinge wrote:
> > David Miller wrote:
> > > Perhaps the problem can be dealt with using ELF relocations.
> > >
> > > There is a
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Mon, 19 Mar 2007 11:57:28 +0100
> On Monday 19 March 2007 00:46, Jeremy Fitzhardinge wrote:
> > Andi Kleen wrote:
> > For example, say we wanted to put a general call for sti into entry.S,
> > where its expected it won't touch any registers. In that case
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Date: Mon, 19 Mar 2007 12:10:08 -0700
> All this is doable; I'd probably end up hacking boot/compressed/relocs.c
> to generate the appropriate reloc table. My main concern is hacking the
> kernel build process itself; I'm unsure of what it would actua
From: Linus Torvalds <[EMAIL PROTECTED]>
Date: Mon, 19 Mar 2007 20:18:14 -0700 (PDT)
> > > Please don't subject us to another couple months of hair-pulling only
> > > to have Linus yank the thing out again, there are certainly more
> > > useful things to spend time on :-)
>
> Good call. Dwarf2 un
From: Paul Mackerras <[EMAIL PROTECTED]>
Date: Wed, 21 Mar 2007 11:03:14 +1100
> Linus Torvalds writes:
>
> > We should just do this natively. There's been several tests over the years
> > saying that it's much more efficient to do sti/cli as a simple store, and
> > handling the "oops, we got a
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 8 May 2007 22:16:09 +1000
> [NET]: Remove link_watch delay for up even when we're down
>
> Currently all link carrier events are delayed by up to a second
> before they're processed to prevent link storms. This causes
> unnecessary packet loss duri
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 8 May 2007 22:13:22 +1000
> [NET] link_watch: Move link watch list into net_device
>
> These days the link watch mechanism is an integral part of the
> network subsystem as it manages the carrier status. So it now
> makes sense to allocate some mem
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Date: Thu, 10 May 2007 15:00:05 -0700
> Herbert Xu wrote:
> > [NET] link_watch: Move link watch list into net_device
> >
> > These days the link watch mechanism is an integral part of the
> > network subsystem as it manages the carrier status. So it n
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Date: Thu, 10 May 2007 15:22:17 -0700
> Andrew Morton wrote:
> > Five minutes after boot is when jiffies wraps. Are you sure it's
> > a list-screwup rather than a jiffy-wrap screwup?
> >
>
>
> Hm, its suggestive, isn't it? Apparently they've alr
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Date: Thu, 10 May 2007 15:45:42 -0700
> David Miller wrote:
> > I'm not so certain now that we know it's the jiffies wrap point :-)
> >
> > The fixes in question are attached below and they were posted and
>
From: Christian Borntraeger <[EMAIL PROTECTED]>
Date: Wed, 11 Jul 2007 12:45:40 +0200
> Am Mittwoch, 4. Juli 2007 schrieb Rusty Russell:
> > +static void receive_skb(struct net_device *dev, struct sk_buff *skb,
> [...]
> > + netif_rx(skb);
>
> In the NAPI case, we should use netif_receive_skb,
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Thu, 12 Jul 2007 12:21:33 +1000
> Dave, I think you're the only one (so far?) with multiple irqs.
Luckily there are known hw implementations with that issue
so I won't be weird for long :)
> It's not clear that guest-controlled interrupt mitigation i
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Tue, 15 Jan 2008 21:41:55 +1100
> Implement skb_partial_csum_set, for setting partial csums on untrusted
> packets.
>
> Use it in virtio_net (replacing buggy version there), it's also going
> to be used by TAP for partial csum support.
>
> Signed-of
From: "Michael S. Tsirkin"
Date: Sun, 21 Oct 2012 14:49:01 +0200
> On Mon, Oct 15, 2012 at 07:55:34PM +0200, Michael S. Tsirkin wrote:
>> We copy head count to a 16 bit field,
>> this works by chance on LE but on BE
>> guest gets 0. Fix it up.
>>
>> Signed-off-by: Michael S. Tsirkin
>> Tested-b
From: "Michael S. Tsirkin"
Date: Wed, 24 Oct 2012 18:24:38 +0200
> Would you like me to repost the patch?
This question is almost retorical.
I said I don't reliably read things I'm not explicitly CC:'d
on, therefore it's possible (and in fact, likely) I don't have
the patch in my inbox.
What d
From: "Michael S. Tsirkin"
Date: Wed, 24 Oct 2012 20:37:51 +0200
> We copy head count to a 16 bit field, this works by chance on LE but on
> BE guest gets 0. Fix it up.
>
> Signed-off-by: Michael S. Tsirkin
> Tested-by: Alexander Graf
> Cc: sta...@vger.kernel.org
Applied, thanks.
From: "Michael S. Tsirkin"
Date: Wed, 31 Oct 2012 12:31:06 +0200
> -void vhost_zerocopy_callback(struct ubuf_info *ubuf)
> +void vhost_zerocopy_callback(struct ubuf_info *ubuf, int zerocopy_status)
If you're only reporting true/false values, even just for now,
please use 'bool' for this.
___
From: "Michael S. Tsirkin"
Date: Thu, 1 Nov 2012 18:16:11 +0200
> Do you think it's over-engineering, or a good idea?
Engineer what you need, not what you might need.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lis
From: "Michael S. Tsirkin"
Date: Thu, 1 Nov 2012 21:16:17 +0200
>
> tun supports zero copy transmit since
> 0690899b4d4501b3505be069b9a687e68ccbe15b,
> however you can only enable this mode if you know your workload does not
> trigger heavy guest to host/host to guest traffic - otherwise you
>
The big and only question is whether anyone can actually use any of
this stuff without your proprietary bits?
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
From: David Miller
Date: Mon, 05 Nov 2012 13:09:17 -0500 (EST)
> The big and only question is whether anyone can actually use any of
> this stuff without your proprietary bits?
And BTW vm-crosst...@vmware.com bounces, take it out of the CC: list
on all future
From: Sachin Kamat
Date: Mon, 19 Nov 2012 16:58:28 +0530
> linux/vhost.h was included twice.
>
> Signed-off-by: Sachin Kamat
Michael, are you gonna take this?
Thanks.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://
From: "Michael S. Tsirkin"
Date: Mon, 19 Nov 2012 21:49:55 +0200
> On Mon, Nov 19, 2012 at 02:18:13PM -0500, David Miller wrote:
>> From: Sachin Kamat
>> Date: Mon, 19 Nov 2012 16:58:28 +0530
>>
>> > linux/vhost.h was included twice.
>> >
>
From: "Michael S. Tsirkin"
Date: Mon, 26 Nov 2012 17:14:16 +0200
> On Mon, Nov 19, 2012 at 10:26:41PM +0200, Michael S. Tsirkin wrote:
>> >
>> > Userspace bits:
>> > -
>> > 1) LKVM
>> > The latest vhost-blk userspace bits for kvm tool can be found here:
>> > g...@gith
From: "Michael S. Tsirkin"
Date: Mon, 3 Dec 2012 19:31:51 +0200
> These packet counters are used to drive the zercopy
> selection heuristic so nothing too bad happens if they are off a bit -
> and they are also reset once in a while.
> But it's cleaner to clear them when backend is set so that
>
From: Jason Wang
Date: Sat, 8 Dec 2012 01:04:54 +0800
> This series is an update version (hope the final version) of multiqueue
> (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were
> addressed, the work were based on Krishna Kumar's work to let virtio-net use
> multiple r
From: Jason Wang
Date: Sat, 8 Dec 2012 01:04:54 +0800
> This series is an update version (hope the final version) of multiqueue
> (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were
> addressed, the work were based on Krishna Kumar's work to let virtio-net use
> multiple r
From: Greg KH
Date: Tue, 8 Jan 2013 16:21:10 -0800
> On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote:
>>
>> * * *
>>
>> This series of VSOCK linux upstreaming patches include latest udpate from
>> VMware to address Greg's and all other's code review comments.
>
> Dave, you acked t
From: Dmitry Torokhov
Date: Tue, 08 Jan 2013 17:41:44 -0800
> On Tuesday, January 08, 2013 05:30:56 PM David Miller wrote:
>> From: Greg KH
>> Date: Tue, 8 Jan 2013 16:21:10 -0800
>>
>> > On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote:
>>
From: ak...@redhat.com
Date: Sun, 20 Jan 2013 10:43:08 +0800
> From: Stefan Hajnoczi
>
> When we set mac address, software mac address in system and hardware mac
> address all need to be updated. Current eth_mac_addr() doesn't allow
> callers to implement error handling nicely.
>
> This patch s
From: Amos Kong
Date: Mon, 21 Jan 2013 19:17:20 +0800
> Currenly mac is programmed byte by byte. This means that we
> have an intermediate step where mac is wrong.
>
> Third patch introduced a new vq control command to set mac
> address, it's atomic.
>
> V2: check return of sending command, de
From: Wanlong Gao
Date: Fri, 25 Jan 2013 17:51:29 +0800
> As Michael mentioned, set affinity and select queue will not work very
> well when CPU IDs are not consecutive, this can happen with hot unplug.
> Fix this bug by traversal the online CPUs, and create a per cpu variable
> to find the mappi
From: Wanlong Gao
Date: Fri, 25 Jan 2013 17:51:30 +0800
> Split out the clean affinity function to virtnet_clean_affinity().
>
> Cc: Rusty Russell
> Cc: "Michael S. Tsirkin"
> Cc: Jason Wang
> Cc: Eric Dumazet
> Cc: "David S. Miller"
> Cc: virtualization@lists.linux-foundation.org
> Cc: net
From: Wanlong Gao
Date: Fri, 25 Jan 2013 17:51:31 +0800
> Add a cpu notifier to virtio-net, so that we can reset the
> virtqueue affinity if the cpu hotplug happens. It improve
> the performance through enabling or disabling the virtqueue
> affinity after doing cpu hotplug.
>
> Cc: Rusty Russell
From: Joe Perches
Date: Sun, 3 Feb 2013 19:28:07 -0800
> Remove all the OOM messages that follow kernel alloc
> failures as there is already a generic equivalent to
> these messages in the mm subsystem.
>
> Joe Perches (8):
> caif: Remove unnecessary alloc/OOM messages
> can: Remove unneces
From: Dmitry Torokhov
Date: Fri, 8 Feb 2013 17:20:44 -0800
> Hi David,
>
> On Wed, Feb 06, 2013 at 04:23:55PM -0800, Andy King wrote:
>> In an effort to improve the out-of-the-box experience with Linux kernels for
>> VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly
>>
From: Andy King
Date: Wed, 6 Feb 2013 16:23:55 -0800
> In an effort to improve the out-of-the-box experience with Linux kernels for
> VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly
> VMCI Sockets) (vsock) kernel module for inclusion in the Linux kernel. The
> purpose
From: Andy King
Date: Mon, 18 Feb 2013 08:04:09 -0800
> Minor vSockets fixes, two of which were reported on LKML.
Series applied, thanks.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailma
From: Jason Wang
Date: Thu, 7 Mar 2013 12:31:56 +0800
> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle
> polling
> errors when setting backend), we in fact track the polling state through
> poll->wqh, so there's no need to duplicate the work with an extra
> vhost_net_p
From: David Howells
Date: Fri, 08 Mar 2013 01:09:18 +
> Greg KH wrote:
>
>> David, is there any rush to get stuff like this into 3.9 for any
>> uapi-type changes, or can it just wait for 3.10?
>
> Not especially. It won't appear in userspace due to the __KERNEL__ guards.
I've applied thi
From: Erwan Yvin
Date: Fri, 15 Mar 2013 10:42:17 +0100
> caif-virtio is going to replace caif-shm.
> This patch should be merged in rusty's tree. (vringh)
> because there is a dependency with vringh wrapper.
Feel free to add my:
Acked-by: David S. Miller
___
From: "Michael S. Tsirkin"
Date: Sun, 17 Mar 2013 14:46:09 +0200
> ubuf info allocator uses guest controlled head as an index,
> so a malicious guest could put the same head entry in the ring twice,
> and we will get two callbacks on the same value.
> To fix use upend_idx which is guaranteed to b
From: "Michael S. Tsirkin"
Date: Thu, 11 Apr 2013 10:24:30 +0300
> On Thu, Apr 11, 2013 at 02:50:48PM +0800, Jason Wang wrote:
>> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle
>> polling
>> errors when setting backend), we in fact track the polling state through
>> pol
From: Rusty Russell
Date: Thu, 16 May 2013 09:05:38 +0930
> memcpy_fromiovec() has nothing to do with networking: that was just the
> first user. Note that crypto/algif_skcipher.c also uses it. The
> obvious answer is to move it into lib/.
+1
___
Vir
From: "Michael S. Tsirkin"
Date: Thu, 16 May 2013 09:46:21 +0300
> On Wed, May 15, 2013 at 08:10:55PM -0700, David Miller wrote:
>> From: Rusty Russell
>> Date: Thu, 16 May 2013 09:05:38 +0930
>>
>> > memcpy_fromiovec() has nothing to do with netwo
From: Jason Wang
Date: Wed, 22 May 2013 14:03:58 +0800
> Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx
> queues which are being used) only does the napi enabling during open for
> curr_queue_pairs. This will break multiqueue receiving since napi of new
> queues
> were
From: "Michael S. Tsirkin"
Date: Wed, 5 Jun 2013 12:02:52 +0300
> On Wed, Jun 05, 2013 at 03:40:46PM +0800, Jason Wang wrote:
>> When we decide not use zero-copy, msg.control should be set to NULL otherwise
>> macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs
>> wrongly.
From: "Michael S. Tsirkin"
Date: Thu, 20 Jun 2013 14:48:13 +0300
> vhost_net_ubuf_put_and_wait has a confusing name:
> it will actually also free it's argument.
> Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01
Never reference commits only by SHA1 ID, it is never sufficient.
Always p
From: "Michael S. Tsirkin"
Date: Tue, 25 Jun 2013 17:29:46 +0300
> vhost_net_ubuf_put_and_wait has a confusing name:
> it will actually also free it's argument.
> Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01
> "vhost-net: flush outstanding DMAs on memory change"
> vhost_net_flus
From: Asias He
Date: Thu, 27 Jun 2013 16:00:01 +0800
> +static void
> +virtio_transport_recv_dgram(struct sock *sk,
> + struct virtio_vsock_pkt *pkt)
...
> + memcpy(skb->data, pkt, sizeof(*pkt));
> + memcpy(skb->data + sizeof(*pkt), pkt->buf, pkt->len);
Are you s
From: Ian Campbell
Date: Fri, 28 Jun 2013 08:59:50 +0100
> On Thu, 2013-06-27 at 21:57 -0700, Joe Perches wrote:
>> Instead of mixing printk and pr_ forms,
>> just use pr_
>>
>> Miscellaneous changes around these conversions:
>>
>> Add a missing newline to avoid message interleaving,
>> coalesc
From: Jason Wang
Date: Wed, 3 Jul 2013 20:15:52 +0800
> Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx
> queues
> which are being used) tries to refill on demand when changing the number of
> channels by call try_refill_recv() directly, this may race:
>
> - the refil
From: "Michael S. Tsirkin"
Date: Sun, 7 Jul 2013 14:26:53 +0300
> vhost_net_ubuf_put_and_wait has a confusing name:
> it will actually also free it's argument.
> Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01
> "vhost-net: flush outstanding DMAs on memory change"
> vhost_net_flush
From: Rusty Russell
Date: Tue, 09 Jul 2013 17:38:51 +0930
> If you convince DaveM, I won't object :)
Simplifications are great, but not when the merge window opens up.
Sorry, this isn't appropriate now.
___
Virtualization mailing list
Virtualization@l
From: Rusty Russell
Date: Mon, 15 Jul 2013 11:13:25 +0930
> From: Michael S. Tsirkin
>
> For small packets we can simplify xmit processing
> by linearizing buffers with the header:
> most packets seem to have enough head room
> we can use for this purpose.
> Since existing hypervisors require t
From: "Michael S. Tsirkin"
Date: Wed, 17 Jul 2013 08:00:32 +0300
> On Tue, Jul 16, 2013 at 12:33:26PM -0700, David Miller wrote:
>> From: Rusty Russell
>> Date: Mon, 15 Jul 2013 11:13:25 +0930
>>
>> > From: Michael S. Tsirkin
>> >
>&
From: Joe Perches
Date: Thu, 1 Aug 2013 16:17:46 -0700
> Convert the uses mac addresses to ETH_ALEN so
> it's easier to find and verify where mac addresses
> need to be __aligned(2)
Series applied to net-next, thanks.
___
Virtualization mailing list
V
From: Asias He
Date: Thu, 15 Aug 2013 11:20:16 +0800
> memcpy_fromiovec is moved to lib/iovec.c. No need to include
> linux/socket.h for it.
>
> Signed-off-by: Asias He
You can't do this.
Because this file doesn't include the header file that
provides the declaration, which is linux/uio.h
li
From: Asias He
Date: Fri, 16 Aug 2013 09:27:43 +0800
> On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:
>> From: Asias He
>> Date: Thu, 15 Aug 2013 11:20:16 +0800
>>
>> > memcpy_fromiovec is moved to lib/iovec.c. No need to include
>> > linux
From: Asias He
Date: Fri, 16 Aug 2013 17:27:43 +0800
> On Fri, Aug 16, 2013 at 12:31:59AM -0700, David Miller wrote:
>> From: Asias He
>> Date: Fri, 16 Aug 2013 09:27:43 +0800
>>
>> > On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:
>> >&g
From: Asias He
Date: Mon, 19 Aug 2013 09:23:19 +0800
> memcpy_fromiovec is moved from net/core/iovec.c to lib/iovec.c.
> linux/uio.h provides the declaration for memcpy_fromiovec.
>
> Include linux/uio.h instead of inux/socket.h for it.
>
> Signed-off-by: Asias He
Applied.
___
From: Andy King
Date: Tue, 20 Aug 2013 10:33:32 -0700
> We can't just do virt_to_phys() on memory that we pass to the device and
> expect it to work in presence of a virtual IOMMU. We need to add IOMMU
> mappings for such DMAs to work correctly. Fix that with
> pci_alloc_consistent() where poss
From: Andy King
Date: Fri, 23 Aug 2013 09:33:49 -0700
> This patch adds support for virtual IOMMU to the vmxnet3 module. We
> switch to DMA consistent mappings for anything we pass to the device.
> There were a few places where we already did this, but using pci_blah();
> these have been fixed t
From: Thomas Huth
Date: Tue, 27 Aug 2013 17:09:02 +0200
> If the VIRTIO_NET_F_GUEST_CSUM virtio feature is available, the guest
> does not have to calculate the checksums on all received packets. This
> is pretty much the same feature as RX checksum offloading on real
> network cards, so the virt
From: Jason Wang
Date: Mon, 2 Sep 2013 16:40:55 +0800
> This series tries to unify and simplify vhost codes especially for
> zerocopy. With this series, 5% - 10% improvement for per cpu throughput were
> seen during netperf guest sending test.
>
> Plase review.
Applied and patch #5 queued up f
From: "Michael S. Tsirkin"
Date: Mon, 12 Apr 2021 18:33:45 -0400
> On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote:
>> OK I started looking at this again. My idea is simple.
>> A. disable callbacks before we try to drain skbs
>> B. actually do disable callbacks even with event
From: Jason Wang
Date: Mon, 30 Sep 2013 15:37:17 +0800
> We used to use a percpu structure vq_index to record the cpu to queue
> mapping, this is suboptimal since it duplicates the work of XPS and
> loses all other XPS functionality such as allowing use to configure
> their own transmission steer
1 - 100 of 536 matches
Mail list logo
