On Thu, 11 Dec 2008 10:05:49 +0100,
Christian Borntraeger <[EMAIL PROTECTED]> wrote:
> Am Mittwoch, 10. Dezember 2008 schrieb Mark McLoughlin:
> > This is basically a no-op change, since it does exactly the
> > same thing as s390_root_dev_register() when the caller isn't
> > a module.
>
> Ok, I g
On Wed, 10 Dec 2008 17:45:35 +,
Mark McLoughlin <[EMAIL PROTECTED]> wrote:
> Add a function to allocate a root device object to group the
> devices from a given virtio implementation.
>
> Also add a 'module' sysfs symlink to allow so that userspace
> can generically determine which virtio imp
On Thu, 11 Dec 2008 16:16:53 +,
Mark McLoughlin <[EMAIL PROTECTED]> wrote:
> Add support for allocating root device objects which group
> device objects under /sys/devices directories.
>
> Also add a sysfs 'module' symlink which points to the owner
> of the root device object. This will be us
h
> deleted file mode 100644
> index 6fa2044..000
> --- a/arch/s390/include/asm/s390_rdev.h
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -/*
> - * include/asm-s390/ccwdev.h
> - *
> - *Copyright (C) 2002,2005 IBM Deutschland Entwicklung GmbH, IBM
> Corp
On Thu, 11 Dec 2008 18:23:27 +,
Mark McLoughlin wrote:
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 8c2cc26..20e5825 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1196,6 +1196,93 @@ EXPORT_SYMBOL_GPL(put_device);
> EXPORT_SYMBOL_GPL(device_create_fi
t device object. This symlink will be used in virtio
> to allow userspace to determine which virtio bus implementation
> a given device is associated with.
>
> [Includes suggestions from Cornelia Huck]
>
> Signed-off-by: Mark McLoug
On Thu, 11 Dec 2008 18:00:25 +0100,
Cornelia Huck wrote:
> On Thu, 11 Dec 2008 16:16:56 +,
> Mark McLoughlin wrote:
>
> > Replace s390_root_dev_register() with root_device_register() etc.
>
> Nice, one more special case generalized :) I'll give it a run.
You mis
On Fri, 12 Dec 2008 09:35:46 +,
Mark McLoughlin wrote:
> From: Mark McLoughlin
> Subject: [PATCH] s390: remove s390_root_dev_*()
>
> Replace s390_root_dev_register() with root_device_register() etc.
>
> [Includes fix from Cornelia Huck]
>
> Signed-off-by: Ma
On Tue, 3 Apr 2007 10:30:36 +0200,
Andi Kleen <[EMAIL PROTECTED]> wrote:
> On Tuesday 03 April 2007 10:29:06 Christian Borntraeger wrote:
> > On Monday 02 April 2007 23:12, Andi Kleen wrote:
> > >
> > > > How would that work in the case where virtualized guests don't have a
> > > > visible PCI bu
On Tue, 3 Apr 2007 11:41:49 +0200,
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> On Tuesday 03 April 2007, H. Peter Anvin wrote:
> > However, one probably wants to think about what the heck one actually
> > means with "virtualization" in the absence of a lot of this stuff. PCI
> > is probably the
On Tue, 3 Apr 2007 11:26:52 +0200,
Andi Kleen <[EMAIL PROTECTED]> wrote:
> >
> > On s390, it would be more than strangeness. There's no implementation
> > of PCI at all, someone would have to cook it up - and it wouldn't have
> > any use beyond those special devices. Since there isn't any bus typ
On Tue, 3 Apr 2007 14:15:37 +0200,
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> Right, but an interesting point is the question what to do when running
> another operating system as a guest under Linux, e.g. with kvm.
>
> Ideally, you'd want to use the same interface to announce the presence
> of t
On Tue, 3 Apr 2007 16:03:14 +0200,
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> > > struct virt_dev {
> > > struct device dev;
> > > struct virt_driver *driver;
> > > struct virt_bus *bus;
> > > struct pci_device_id id;
> > > int irq;
> > > };
> >
> > And that's where I have problems :) T
On Tue, 25 Sep 2007 09:37:38 +1000,
Rusty Russell <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-09-25 at 00:18 +0200, Arnd Bergmann wrote:
> > On Monday 24 September 2007, Rusty Russell wrote:
> > > +
> > > +struct virtio_bus {
> > > + struct bus_type bus;
> > > + struct device dev;
> > > +};
> > > +
On Tue, Sep 26 2023, Halil Pasic wrote:
> [..]
>> --- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
>> +++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
>> @@ -61,8 +61,9 @@ static void virtio_crypto_akcipher_finalize_req(
>> vc_akcipher_req->src_buf = NULL;
>> vc_akciph
On Wed, Sep 27 2023, Halil Pasic wrote:
> On Wed, 27 Sep 2023 12:08:43 +0200
> Cornelia Huck wrote:
>
>> > On the other hand virtio_airq_handler() calls vring_interrupt() with
>> > interrupts enabled. (While vring_interrupt() is called in a (read)
>> > cri
Hi Rusty,
here are some clarifications for virtio-ccw: feature bit endianess
and how setting the indicator location works (with the channel
data address only being 32 bit wide).
Cornelia Huck (1):
virtio-ccw: Clarifications.
virtio-spec.lyx |9 +
1 files changed, 5 insertions
Clarify how indicator location is communicated and that the
feature bits are little-endian.
Signed-off-by: Cornelia Huck
---
virtio-spec.lyx |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index b0532ef..83f2771 100644
--- a
the index we want to release before calling
device_unregister().
Signed-off-by: Cornelia Huck
---
drivers/virtio/virtio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 1e8659c..809b0de 100644
--- a/drivers/virtio/vi
On Tue, 26 Feb 2013 13:13:39 +0100
Christian Borntraeger wrote:
> On 26/02/13 12:18, Michael S. Tsirkin wrote:
> > virtio_ccw: pass a cookie value to kvm hypercall
> >
> > Lookups by channel/vq pair on host during virtio notifications might be
> > expensive. Interpret hypercall return value as
On Tue, 26 Feb 2013 15:56:43 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Feb 26, 2013 at 02:29:07PM +0100, Cornelia Huck wrote:
> > On Tue, 26 Feb 2013 13:13:39 +0100
> > Christian Borntraeger wrote:
> >
> > > On 26/02/13 12:18, Michael S. Tsirkin wrote:
Signed-off-by: Michael S. Tsirkin
Otherwise:
Reviewed-by: Cornelia Huck
Rusty, could you please apply?
>
> ---
> diff --git a/virtio-spec.lyx b/virtio-spec.lyx
> index 72d956c..91aed06 100644
> --- a/virtio-spec.lyx
> +++ b/virtio-spec.lyx
> @@ -10627,7 +10626,252 @@ Guest-&
On Thu, 21 Mar 2013 18:59:24 +1030
Rusty Russell wrote:
> All transports just pass through at the moment.
>
> Cc: Ohad Ben-Cohen
> Cc: Brian Swetland
> Cc: Cornelia Huck
> Cc: Pawel Moll
> Cc: Christian Borntraeger
> Signed-off-by: Rusty Russell
> ---
>
On Thu, 21 Mar 2013 18:59:25 +1030
Rusty Russell wrote:
> It seemed like a good idea, but it's actually a pain when we get more
> than 32 feature bits. Just change it to a u32 for now.
>
> Cc: Ohad Ben-Cohen
> Cc: Brian Swetland
> Cc: Cornelia Huck
> Cc: P
On Thu, 21 Mar 2013 18:59:26 +1030
Rusty Russell wrote:
> Change the u32 to a u64, and make sure to use 1ULL everywhere!
>
> Cc: Ohad Ben-Cohen
> Cc: Brian Swetland
> Cc: Cornelia Huck
> Cc: Pawel Moll
> Cc: Christian Borntraeger
> Signed-off-by: Rusty Russel
On Fri, 22 Mar 2013 11:01:20 +1030
Rusty Russell wrote:
> Nice understatement. I guess you know where I cut & pasted from...
>
> Here is the updated version.
Looks sane to me.
>
> Thanks,
> Rusty.
>
> diff --git a/drivers/s390/kvm/kvm_virtio.c b/drivers/s390/kvm/kvm_virtio.c
> index 6711e6
On Fri, 22 Mar 2013 11:20:05 +1030
Rusty Russell wrote:
> Cornelia Huck writes:
> > On Thu, 21 Mar 2013 18:59:26 +1030
> > Rusty Russell wrote:
> >
> >> Change the u32 to a u64, and make sure to use 1ULL everywhere!
> >
> > And a not-even-compiled
on the error handling path. This way, the kvm_irqfd system will
> not be ready.
Since we can't have the initialization as kvm module init function
without forcing everyone to split modules, this is probably the best
way to handle this.
Acked-by: Cornelia Huck
>
> This patch fi
0f b6 03 38 c2 75 f7 48 83
> c4 08 5b c9 c3 55 48 89 e5 66 66 66 66 90 b8 00 01 00 00 66 0f c1 07 89
> c2 66 c1 ea 08 38 c2 74 0c 0f 1f 00 f3 90 0f
> RIP [] _raw_spin_lock+0xe/0x30
> RSP
> CR2:
> ---[ end trace 13fb1e4b6e5ab21f ]---
>
> Signed-off-by: Asias He
Signed-off-by: Cornelia Huck
---
virtio-spec.lyx | 147 +--
1 file changed, 144 insertions(+), 3 deletions(-)
diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index c920155..4729766 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
Hi,
here's again my proposal for adapter (thin) interrupt support for virtio-ccw
devices, originally posted at
http://marc.info/?l=linux-virtualization&m=137060143904927&w=2
The document is unchanged, only rebased against current master.
Cornelia Huck (1):
virtio-ccw: Doc
Hi,
here's the current implementation of virtio-ccw adapter interrupts in qemu.
Code is unchanged, only rebased against current master.
Cornelia Huck (1):
s390/virtio-ccw: Adapter interrupt support.
hw/s390x/css.c| 10
hw/s390x/css.h|2 ++
hw/s390x/v
offset.
Signed-off-by: Cornelia Huck
---
hw/s390x/css.c| 10
hw/s390x/css.h|2 ++
hw/s390x/virtio-ccw.c | 64 -
hw/s390x/virtio-ccw.h |4
target-s390x/ioinst.h |2 ++
target-s390x/kvm.c
Hi,
next version of the guest exploitation of virtio-ccw adapter interrupts.
Changes from the last version:
- adapt to latest kvm-next
- changed housekeeping for indicator locations: we now use cacheline-sized
and aligned areas
- minor tweaks
Cornelia Huck (2):
KVM: s390: virtio-ccw
A command reject for a ccw may happen if we run on a host not supporting
a certain feature. We want to be able to handle this as special case of
command failure, so let's split this off from the generic -EIO error code.
Signed-off-by: Cornelia Huck
---
drivers/s390/kvm/virtio_ccw.c
summary indicator for all devices sharing the same indicator
area.
Indicator bits for the individual virtqueues may be contained in the same
indicator area for different devices.
Signed-off-by: Cornelia Huck
---
arch/s390/include/asm/irq.h | 1 +
arch/s390/kernel/irq.c| 1 +
drivers
On Tue, 09 Jul 2013 15:27:14 +0200
Christian Borntraeger wrote:
> On 09/07/13 13:34, Cornelia Huck wrote:
> > Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts
> > on guest request. When active, host->guest notifications will be handled
> > via g
On Thu, Sep 30 2021, Halil Pasic wrote:
> This patch fixes a regression introduced by commit 82e89ea077b9
> ("virtio-blk: Add validation for block size in config space") and
> enables similar checks in verify() on big endian platforms.
>
> The problem with checking multi-byte config fields in the
On Thu, Sep 30 2021, Halil Pasic wrote:
> On Thu, 30 Sep 2021 11:28:23 +0200
> Cornelia Huck wrote:
>
>> On Thu, Sep 30 2021, Halil Pasic wrote:
>>
>> > This patch fixes a regression introduced by commit 82e89ea077b9
>> > ("virtio-blk: Add val
On Thu, Sep 30 2021, "Michael S. Tsirkin" wrote:
> On Thu, Sep 30, 2021 at 03:20:49AM +0200, Halil Pasic wrote:
>> This patch fixes a regression introduced by commit 82e89ea077b9
>> ("virtio-blk: Add validation for block size in config space") and
>> enables similar checks in verify() on big endi
On Fri, Oct 01 2021, Halil Pasic wrote:
> On Thu, 30 Sep 2021 13:31:04 +0200
> Cornelia Huck wrote:
>
>> On Thu, Sep 30 2021, Halil Pasic wrote:
>>
>> > On Thu, 30 Sep 2021 11:28:23 +0200
>> > Cornelia Huck wrote:
>> >
>> >>
On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote:
> On Fri, Oct 01, 2021 at 05:18:46PM +0200, Cornelia Huck wrote:
>> I'd say we need a hack here so that we assume little-endian config space
>> if VERSION_1 has been offered; if your patch here works, I assu
On Mon, Oct 04 2021, Halil Pasic wrote:
> On Mon, 04 Oct 2021 09:01:42 +0200
> Cornelia Huck wrote:
>
>> On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote:
>>
>> > On Fri, Oct 01, 2021 at 05:18:46PM +0200, Cornelia Huck wrote:
>> >> I'
On Sun, Oct 03 2021, "Michael S. Tsirkin" wrote:
> Sent too early. So here's what I propose. Could you pls take a look
> and if you like this, post a ccw section?
We have not talked about the mmio transport so far, but I guess it
should be fine as legacy and standard are separated.
> There's al
[cc:qemu-devel]
On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote:
> On Fri, Oct 01, 2021 at 09:21:25AM +0200, Halil Pasic wrote:
>> On Thu, 30 Sep 2021 07:12:21 -0400
>> "Michael S. Tsirkin" wrote:
>>
>> > On Thu, Sep 30, 2021 at 03:20:49AM +0200, Halil Pasic wrote:
>> > > This patch fixes a
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 02:01:14PM +0200, Cornelia Huck wrote:
>> On Sun, Oct 03 2021, "Michael S. Tsirkin" wrote:
>> > @@ -160,6 +163,33 @@ \subsection{Legacy Interface: A Note on Feature
>>
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 02:19:55PM +0200, Cornelia Huck wrote:
>>
>> [cc:qemu-devel]
>>
>> On Sat, Oct 02 2021, "Michael S. Tsirkin" wrote:
>>
>> > On Fri, Oct 01, 2021 at 09:21:
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote:
>> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
>>
>> > On Mon, Oct 04, 2021 at 02:01:14PM +0200, Cornelia Huck wrote:
>> &
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 04:33:21PM +0200, Cornelia Huck wrote:
>> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
>>
>> > On Mon, Oct 04, 2021 at 02:19:55PM +0200, Cornelia Huck wrote:
>> >
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 05:45:06PM +0200, Cornelia Huck wrote:
>> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
>>
>> > On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote:
>> &
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 04:23:23AM +0200, Halil Pasic wrote:
>> --8<-
>>
>> From: Halil Pasic
>> Date: Thu, 30 Sep 2021 02:38:47 +0200
>> Subject: [PATCH] virtio: write back feature VERSION_1 before v
On Tue, Oct 05 2021, Halil Pasic wrote:
> On Mon, 4 Oct 2021 05:07:13 -0400
> "Michael S. Tsirkin" wrote:
>> Well we established that we can know. Here's an alternative explanation:
>
>
> I thin we established how this should be in the future, where a transport
> specific mechanism is used to de
On Tue, Oct 05 2021, "Michael S. Tsirkin" wrote:
> On Tue, Oct 05, 2021 at 01:17:51PM +0200, Halil Pasic wrote:
>> On Mon, 4 Oct 2021 16:01:12 -0400
>> "Michael S. Tsirkin" wrote:
>>
>> > >
>> > > Ok, so what about something like
>> > >
>> > > "If FEATURES_OK is not set, the driver MAY change
On Tue, Oct 05 2021, Halil Pasic wrote:
> On Tue, 05 Oct 2021 13:13:31 +0200
> Cornelia Huck wrote:
>> Or am I misunderstanding what you're getting at?
>>
>
> Probably. I'm talking about pre- "do transport specific legacy detection
> in the devic
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
> On Mon, Oct 04, 2021 at 05:50:44PM +0200, Cornelia Huck wrote:
>> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote:
>>
>> > On Mon, Oct 04, 2021 at 04:33:21PM +0200, Cornelia Huck wrote:
>> &
On Fri, Aug 06 2021, Enrico Granata wrote:
> Hi folks,
> I am back from my leave of absence, so thank you everyone for your patience
>
> This proposal has been outstanding for a while and didn't seem to
> receive pushback, especially compared to the initial proposal
>
> Would it be the right time
On Wed, Oct 06 2021, Halil Pasic wrote:
> The virtio specification virtio-v1.1-cs01 states: Transitional devices
> MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not
> been acknowledged by the driver. This is exactly what QEMU as of 6.1
> has done relying solely on VIRTIO_F_
On Thu, Oct 07 2021, Halil Pasic wrote:
> On Thu, 07 Oct 2021 13:52:24 +0200
> Cornelia Huck wrote:
>
>> On Wed, Oct 06 2021, Halil Pasic wrote:
>>
>> > The virtio specification virtio-v1.1-cs01 states: Transitional devices
>> > MUST detect Legacy drive
On Thu, Oct 07 2021, Halil Pasic wrote:
> On Thu, 07 Oct 2021 17:25:52 +0200
> Cornelia Huck wrote:
>
>> On Thu, Oct 07 2021, Halil Pasic wrote:
>>
>> > On Thu, 07 Oct 2021 13:52:24 +0200
>> > Cornelia Huck wrote:
>> >
>> >> O
> > +++ b/drivers/virtio/virtio.c
>> > @@ -239,6 +239,17 @@ static int virtio_dev_probe(struct device *_d)
>> >driver_features_legacy = driver_features;
>> >}
>> >
>> > + /*
>> > + * Some devices detect legacy so
t and virtio blk seem to be affected.
>
> Long term the right thing to do is to fix the hypervisors.
>
> Cc: #v4.11
> Signed-off-by: Halil Pasic
> Fixes: 82e89ea077b9 ("virtio-blk: Add validation for block size in config
> space")
> Fixes: fe36cbe0671e ("virti
On Wed, Oct 13 2021, "Michael S. Tsirkin" wrote:
> On Wed, Oct 13, 2021 at 01:23:50PM +0200, Christian Borntraeger wrote:
>> Can we get this kernel patch queued for 5.15 and stable without waiting for
>> the QEMU patch
>> as we have a regression with 4.14?
>
> Probably. Still trying to decide be
On Wed, Oct 06 2021, Enrico Granata wrote:
> I would very much favor that - thanks for bringing this thread back to
> attention
Merged now, thank you for your patience.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https:/
2 files changed, 1 insertion(+), 3 deletions(-)
>
And nobody else really should use it.
Reviewed-by: Cornelia Huck
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Mon, Jan 17 2022, "Michael S. Tsirkin" wrote:
> On Mon, Jan 17, 2022 at 02:31:49PM +0800, Jason Wang wrote:
>>
>> 在 2022/1/15 上午4:09, Michael S. Tsirkin 写道:
>> > @@ -495,6 +494,10 @@ int virtio_device_restore(struct virtio_device *dev)
>> >/* We have a driver! */
>> >virtio_add_status
On Tue, Jan 18 2022, "Michael S. Tsirkin" wrote:
> On Mon, Jan 17, 2022 at 01:38:42PM +0100, Cornelia Huck wrote:
>> On Mon, Jan 17 2022, "Michael S. Tsirkin" wrote:
>>
>> > On Mon, Jan 17, 2022 at 02:31:49PM +0800, Jason Wang wrote:
>> &
74f918e ("virtio: write back F_VERSION_1 before validate")
> Cc: "Halil Pasic"
> Signed-off-by: Michael S. Tsirkin
>
> fixup! virtio: acknowledge all features before access
Leftover from rebasing?
> ---
> drivers/virtio/virtio.c | 39 +
On Mon, Mar 14 2022, Xuan Zhuo wrote:
> Record the maximum queue num supported by the device.
>
> virtio-net can display the maximum (supported by hardware) ring size in
> ethtool -g eth0.
>
> When the subsequent patch implements vring reset, it can judge whether
> the ring size passed by the dri
on(use "__le32 akcipher_algo;"
>> instead of "__le32 reserve;" only, see v1->v2 change), and start a new issue
>> for a revoting procedure?
>
> You can but not it probably will be deferred to 1.3. OK with you?
>
>> Also cc Cornelia Huck.
[Apologies,
On Tue, Apr 05 2022, "Michael S. Tsirkin" wrote:
> On Mon, Apr 04, 2022 at 05:39:24PM +0200, Cornelia Huck wrote:
>> On Mon, Mar 07 2022, "Michael S. Tsirkin" wrote:
>>
>> > On Mon, Mar 07, 2022 at 10:42:30AM +0800, zhenwei pi wrote:
>> >&
at most 1, as we never bumped
the maximum revision; let's do that now.
Fixes: 7d3ce5ab9430 ("virtio/s390: support READ_STATUS command for virtio-ccw")
Signed-off-by: Cornelia Huck
---
QEMU does not fence off READ_STATUS for revisions < 2, which is probably
why we never noticed t
On Fri, 12 Feb 2021 18:04:11 +0100
Cornelia Huck wrote:
> CCW_CMD_READ_STATUS was introduced with revision 2 of virtio-ccw,
> and drivers should only rely on it being implemented when they
> negotiated at least that revision with the device.
>
> However, virtio_ccw_get_
On Mon, 15 Feb 2021 19:51:44 +0100
Halil Pasic wrote:
> On Mon, 15 Feb 2021 12:47:02 +0100
> Cornelia Huck wrote:
>
> > On Fri, 12 Feb 2021 18:04:11 +0100
> > Cornelia Huck wrote:
> >
> > > CCW_CMD_READ_STATUS was introduced with revision 2 of virtio-ccw
: sta...@vger.kernel.org
Fixes: 7d3ce5ab9430 ("virtio/s390: support READ_STATUS command for virtio-ccw")
Reviewed-by: Halil Pasic
Signed-off-by: Cornelia Huck
---
v1->v2:
tweak patch description and cc:stable
---
drivers/s390/virtio/virtio_ccw.c | 4 ++--
1 file changed, 2 insertio
I was thinking of queuing this, but maybe it is quicker to pick it into
the s390 tree directly and save us the extra pull request dance?
Especially as this is a stable-worthy bugfix.
On Tue, 16 Feb 2021 12:06:45 +0100
Cornelia Huck wrote:
> CCW_CMD_READ_STATUS was introduced with revision 2
On Tue, 23 Feb 2021 17:46:20 +0800
Jason Wang wrote:
> On 2021/2/23 下午5:25, Michael S. Tsirkin wrote:
> > On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote:
> >>
> >> On 2/21/2021 8:14 PM, Jason Wang wrote:
> >>> On 2021/2/19 7:54 下午, Si-Wei Liu wrote:
> Commit 452639a64ad8 ("
On Tue, 23 Feb 2021 18:31:07 +0800
Jason Wang wrote:
> On 2021/2/23 6:04 下午, Cornelia Huck wrote:
> > On Tue, 23 Feb 2021 17:46:20 +0800
> > Jason Wang wrote:
> >
> >> On 2021/2/23 下午5:25, Michael S. Tsirkin wrote:
> >>> On Mon, Feb 22,
On Wed, 24 Feb 2021 17:29:07 +0800
Jason Wang wrote:
> On 2021/2/23 6:58 下午, Cornelia Huck wrote:
> > On Tue, 23 Feb 2021 18:31:07 +0800
> > Jason Wang wrote:
> >
> >> On 2021/2/23 6:04 下午, Cornelia Huck wrote:
> >>> On Tue, 23 Feb 2
On Thu, 25 Feb 2021 12:36:07 +0800
Jason Wang wrote:
> On 2021/2/24 7:12 下午, Cornelia Huck wrote:
> > On Wed, 24 Feb 2021 17:29:07 +0800
> > Jason Wang wrote:
> >
> >> On 2021/2/23 6:58 下午, Cornelia Huck wrote:
> >>> On Tue, 23 Feb 2021 18:31:07
On Mon, 1 Mar 2021 11:51:08 +0800
Jason Wang wrote:
> On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote:
> > On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote:
> >> On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote:
> >>> Confused. What is wrong with the above? It never reads the
> >>> fie
On Wed, 3 Mar 2021 12:01:01 +0800
Jason Wang wrote:
> On 2021/3/2 8:08 下午, Cornelia Huck wrote:
> > On Mon, 1 Mar 2021 11:51:08 +0800
> > Jason Wang wrote:
> >
> >> On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote:
> >>> On Fri, Feb 26, 2021 at 04:19
On Wed, 24 Feb 2021 10:32:00 +0100
Stefano Garzarella wrote:
> On Thu, Feb 18, 2021 at 09:08:23AM +0300, Arseny Krasnov wrote:
> >Signed-off-by: Arseny Krasnov
> >---
> > virtio-vsock.tex | 40 +---
> > 1 file changed, 37 insertions(+), 3 deletions(-)
> >
> >di
On Wed, 3 Mar 2021 11:52:43 -0500
"Michael S. Tsirkin" wrote:
> On Wed, Mar 03, 2021 at 01:08:43PM +0100, Cornelia Huck wrote:
> > On Wed, 24 Feb 2021 10:32:00 +0100
> > Stefano Garzarella wrote:
> >
> > > On Thu, Feb 18, 2021 at 09:08:23AM +0300, Arse
restrict use of
old transport revisions. In particular, setting a minimum revision
of 1 makes our driver act as a non-transitional driver.
With the default min_revision of 0, we continue to act as a
transitional driver.
Signed-off-by: Cornelia Huck
---
drivers/s390/virtio/virtio_ccw.c | 21
We may want to remove legacy virtio support in the future. In order
to prepare virtio-ccw for that, add an option to disable legacy
support there. This means raising the minimum transport revision
to 1.
Signed-off-by: Cornelia Huck
---
arch/s390/Kconfig | 11 ++
drivers
x27;t yet found time to polish the patches.)
Cornelia Huck (2):
virtio/s390: add parameter for minimum revision
virtio/s390: make legacy support configurable
arch/s390/Kconfig | 11 ++
drivers/s390/virtio/Makefile| 1 +
drivers/s390/virtio/virtio_ccw
On Thu, 4 Mar 2021 16:24:16 +0800
Jason Wang wrote:
> On 2021/3/3 4:29 下午, Cornelia Huck wrote:
> > On Wed, 3 Mar 2021 12:01:01 +0800
> > Jason Wang wrote:
> >
> >> On 2021/3/2 8:08 下午, Cornelia Huck wrote:
> >>> On Mon, 1 Mar 2
On Mon, 15 Mar 2021 11:35:41 +0300
Arseny Krasnov wrote:
> This replaces constants defined in "bit X set to Y" manner
> with enums from Linux kernel uapi headers.
> ---
> virtio-vsock.tex | 29 ++---
> 1 file changed, 22 insertions(+), 7 deletions(-)
>
> diff --git a/vir
On Tue, 16 Mar 2021 06:35:11 +0300
Arseny Krasnov wrote:
> On 15.03.2021 18:53, Cornelia Huck wrote:
> > On Mon, 15 Mar 2021 11:35:41 +0300
> > Arseny Krasnov wrote:
> >
> >> This replaces constants defined in "bit X set to Y" manner
> &
On Tue, 16 Mar 2021 09:23:39 -0400
"Michael S. Tsirkin" wrote:
> On Tue, Mar 16, 2021 at 09:11:40AM +0100, Cornelia Huck wrote:
> > On Tue, 16 Mar 2021 06:35:11 +0300
> > Arseny Krasnov wrote:
> >
> > > On 15.03.2021 18:53, Cornelia Huck wrote:
&g
On Wed, 7 Apr 2021 12:09:22 +
Max Gurtovoy wrote:
> The reset device operation, usually is an operation that might fail from
> various reasons. For example, the controller might be in a bad state and
> can't answer to any request. Usually, the paravirt SW based virtio
> devices always succeed
On Tue, 20 Apr 2021 06:08:29 -0400
"Michael S. Tsirkin" wrote:
> On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote:
> > Just to despit my 2 cents again: I think the way this is specified
> > in the virtio spec is actively harmful and we should not suport it in
> > Linux.
> >
> >
On Thu, 4 Mar 2021 14:27:13 +0100
Cornelia Huck wrote:
Just found this old series sitting there... does anyone have an opinion
on the general approach?
> Unlike virtio-pci, virtio-ccw is currently always a transitional
> driver (i.e. it always includes support for legacy devices
On Mon, 31 May 2021 15:27:42 +0800
Zhu Lingshan wrote:
> This commit updates virtio id table by adding transitional device
> ids
>
> Signed-off-by: Zhu Lingshan
> ---
> include/uapi/linux/virtio_ids.h | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/uapi/linux/vi
On Tue, Jul 06 2021, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their
On Tue, Jul 06 2021, Cornelia Huck wrote:
> On Tue, Jul 06 2021, Uwe Kleine-König wrote:
>
>> The driver core ignores the return value of this callback because there
>> is only little it can do when a device disappears.
>>
>> This is the final bit of a long lasti
| 4 +---
> drivers/s390/cio/scm.c| 4 +---
> drivers/s390/crypto/ap_bus.c | 4 +---
> drivers/vfio/mdev/mdev_driver.c | 4 +---
For drivers/s390 and drivers/vfio:
Reviewed-by: Cornelia Huck
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
On Sat, Jul 17 2021, "Michael S. Tsirkin" wrote:
> On Sat, Jul 17, 2021 at 10:42:58AM +0300, Parav Pandit wrote:
>> When a virtio pci device undergo surprise removal (aka async removaln in
>
> typo
>
>> PCIe spec), mark the device is broken so that any upper layer drivers can
>> abort any outstan
On Wed, Sep 15 2021, Halil Pasic wrote:
> Since commit 48720ba56891 ("virtio/s390: use DMA memory for ccw I/O and
> classic notifiers") we were supposed to make sure that
> virtio_ccw_release_dev() completes before the ccw device, and the
> attached dma pool are torn down, but unfortunately we di
On Thu, Sep 16 2021, Halil Pasic wrote:
> On Thu, 16 Sep 2021 10:59:15 +0200
> Cornelia Huck wrote:
>
>> > Since commit 48720ba56891 ("virtio/s390: use DMA memory for ccw I/O and
>> > classic notifiers") we were supposed to make sure that
>> > vir
1 - 100 of 852 matches
Mail list logo
