Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Andrew Morton
On Wed, 19 Mar 2008 19:24:25 +0800 "Jaya Kumar" <[EMAIL PROTECTED]> wrote: > On Wed, Mar 19, 2008 at 6:45 PM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > > > > Any progress on this? > > > > Considering that fb_defio is utterly broken without the fix (writing > > the frame buffer makes the VM

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Andrew Morton
On Thu, 20 Mar 2008 06:30:37 +0800 "Jaya Kumar" <[EMAIL PROTECTED]> wrote: > On Thu, Mar 20, 2008 at 2:37 AM, Andrew Morton > <[EMAIL PROTECTED]> wrote: > > > > Do we need some of all of that patch in 2.6.25? I wasn't aware of such a > > nee

Re: [RFC/PATCH 01/15 v2] preparation: provide hook to enable pgstes in user pagetable

2008-03-24 Thread Andrew Morton
On Sat, 22 Mar 2008 18:02:37 +0100 Carsten Otte <[EMAIL PROTECTED]> wrote: > From: Martin Schwidefsky <[EMAIL PROTECTED]> > > The SIE instruction on s390 uses the 2nd half of the page table page to > virtualize the storage keys of a guest. This patch offers the s390_enable_sie > function, which r

Re: [RFC/PATCH 02/15 v2] preparation: host memory management changes for s390 kvm

2008-03-24 Thread Andrew Morton
On Sat, 22 Mar 2008 18:02:39 +0100 Carsten Otte <[EMAIL PROTECTED]> wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > From: Christian Borntraeger <[EMAIL PROTECTED]> > > This patch changes the s390 memory management defintions to use the pgste > field > for dirty and reference bit tracking of

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 14:39:48 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > virtio introduced a ring structure ABI for guest-host communications > (currently used by lguest and kvm). Using this same ABI, we can > create a nice fd version. > > This is useful for efficiently passing packets to a

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > This patch modifies tun to allow a vringfd to specify the send > buffer. The user does a write to push out packets from the buffer. > > Again we use the 'struct virtio_net_hdr' to allow userspace to send > GSO packets.

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 00:32:39 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > Isn't this kinda-sorta like what a relayfs file does? The oprofile > > buffers? etc? Nothing in common at all, no hope? > > An excellent question, but I thought the modern kernel etiquette was to only > comment on

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
r of disks upon which they can open files. > Subject: Export release_pages; nice undo for get_user_pages. > > Andrew Morton suggests tun/tap use release_pages, but it's not > exported. It's not clear to me why this is in swap.c, but it exists > even without CONFIG_SWAP,

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > It's not clear to me why this is in swap.c, but it exists > even without CONFIG_SWAP, so that's OK. We should have done mv mm/swap.c mm/mmlib.c years ago. ___ Virtualization m

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-19 Thread Andrew Morton
> On Sun, 20 Apr 2008 00:41:43 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Saturday 19 April 2008 05:06:34 Andrew Morton wrote: > > On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> > wrote: > > > > What is the maximum numbet

Re: [PATCH 2/2] dm-ioband: I/O bandwidth controller v0.0.4: Document

2008-04-26 Thread Andrew Morton
On Thu, 24 Apr 2008 20:22:19 +0900 (JST) Ryo Tsuruta <[EMAIL PROTECTED]> wrote: > +What's dm-ioband all about? > + > + dm-ioband is an I/O bandwidth controller implemented as a device-mapper > + driver. Several jobs using the same physical device have to share the > + bandwidth of the devi

Re: [PATCH 1/5] xen: Enable console tty by default in domU if it's not a dummy

2008-05-21 Thread Andrew Morton
On Wed, 21 May 2008 10:38:50 +0200 Markus Armbruster <[EMAIL PROTECTED]> wrote: > Without console= arguments on the kernel command line, the first > console to register becomes enabled and the preferred console (the one > behind /dev/console). This is normally tty (assuming > CONFIG_VT_CONSOLE is

Re: [PATCHv2 1/2] mm: export use_mm/unuse_mm to modules

2009-08-11 Thread Andrew Morton
On Wed, 12 Aug 2009 00:27:52 +0300 "Michael S. Tsirkin" wrote: > vhost net module wants to do copy to/from user from a kernel thread, > which needs use_mm (like what fs/aio has). Move that into mm/ and > export to modules. OK by me. Please include this change in the virtio patchset. Which I s

Re: [PATCH] make CONFIG_PARAVIRT require NO_HZ

2007-03-16 Thread Andrew Morton
gt; Require NO_HZ when CONFIG_PARAVIRT. Signed-off-by: Chris Wright <[EMAIL PROTECTED]> Cc: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Rusty Russell <[EMAIL PROTECTED]> Acked-by: Zachary Amsden <[EMAIL PROTECTED]> Cc: Ingo Molnar <[EMAIL PROTECTED]> Cc: Thomas Gleixn

Re: [PATCH/RFC] replace get_scheduled_cycles with sched_clock paravirt_op

2007-03-16 Thread Andrew Morton
On Wed, 14 Mar 2007 12:07:14 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Subject: Add a sched_clock paravirt_op > > The tsc-based get_scheduled_cycles interface is not a good match for > Xen's runstate accounting, which reports everything in nanoseconds. > > This patch replaces this

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-20 Thread Andrew Morton
On Tue, 20 Mar 2007 21:23:52 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > Well it causes additional problems. We had some cases where it was really > hard to distingush garbage and the true call chain. yes, for some reason the naive backtraces seem to have got messier and messier over the years

Re: [patch 09/20] rename struct paravirt_patch to paravirt_patch_site for clarity

2007-04-06 Thread Andrew Morton
On Wed, 04 Apr 2007 12:12:00 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Rename struct paravirt_patch to paravirt_patch_site, so that it > clearly refers to a callsite, and not the patch which may be applied > to that callsite. Needed a bit of updating for Andi's recently-merged x86_6

Re: [patch 18/20] clean up tsc-based sched_clock

2007-04-06 Thread Andrew Morton
On Wed, 04 Apr 2007 12:12:09 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Three cleanups: > - change "instable" -> "unstable" > - its better to use get_cpu_var for getting this cpu's variables > - change cycles_2_ns to do the full computation rather than just the >tsc->ns scaling

Re: [patch 07/20] Allow paravirt backend to choose kernel PMD sharing

2007-04-06 Thread Andrew Morton
On Wed, 04 Apr 2007 12:11:58 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Normally when running in PAE mode, the 4th PMD maps the kernel address > space, which can be shared among all processes (since they all need > the same kernel mappings). > > Xen, however, does not allow guests to

Re: [patch 18/20] clean up tsc-based sched_clock

2007-04-06 Thread Andrew Morton
On Fri, 06 Apr 2007 16:27:20 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > I still need to work out why that hang is happening - it is very > > mysterious. I got as far as working out that it was hanging on > > write_seqlock_irqsave(xtime_lock), then remembered that it's with > > CONF

Re: [patch 07/20] Allow paravirt backend to choose kernel PMD sharing

2007-04-06 Thread Andrew Morton
On Fri, 06 Apr 2007 17:02:58 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > All this paravirt stuff isn't making the kernel any prettier, is it? > > > > You're too kind. wli's comment on the first version of thi

Re: [patch 07/20] Allow paravirt backend to choose kernel PMD sharing

2007-04-06 Thread Andrew Morton
On Fri, 06 Apr 2007 17:40:13 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > Something like that. I don't want to redo my patch if we're going to change > > your patch ;) > > > > OK. I won't specifically redo

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > identify_cpu() is used to identify both the boot CPU and secondary > CPUs, but it performs some actions which only apply to the boot CPU. > Those functions are therefore really __init functions, but because > they

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > I don't have a x86-64 compile environment on > hand, so the 64 bits are completely untested http://userweb.kernel.org/~akpm/cross-compilers/ ___ Virtualization mailing

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Sat, 7 Apr 2007 20:39:16 +0200 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Sat, Apr 07, 2007 at 10:59:47AM -0700, Andrew Morton wrote: > > On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> > > wrote: > > > > > I don't

Re: [patch 4/6] Rename the parainstructions symbols to be consistent with the others

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:07:48 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Wednesday 04 April 2007 03:06:59 Jeremy Fitzhardinge wrote: > > The other symbols used to delineate the alt-instructions sections have > > the form __foo/__foo_end. Rename parainstructions to match. > > This patch brea

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-23 Thread Andrew Morton
On Tue, 27 Mar 2007 14:49:20 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > The softlockup watchdog is currently a nuisance in a virtual machine, > since the whole system could have the CPU stolen from it for a long > period of time. While it would be unlikely for a guest domain to be >

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Mon, 23 Apr 2007 23:58:20 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Tue, 27 Mar 2007 14:49:20 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> > > wrote: > > > > > >> The softlockup watchdog is currently

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 10:51:35 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > It seems fairly sensitive to .config settings. See > > http://userweb.kernel.org/~akpm/config-sony.txt > > > > I haven't tried your config yet,

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 11:16:09 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > I said that because the damn thing went away when I was hunting it down > > because I lost the config and was unable to remember the right combination > > of d

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:00:49 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > Well, it _is_ mysterious. > > > > Did you try to locate the code which failed? I got lost in macros and > > include files, and gave up ver

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:24:24 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Jeremy Fitzhardinge wrote: > > Andrew Morton wrote: > > > >> Well, it _is_ mysterious. > >> > >> Did you try to locate the code which failed? I got lost in macr

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 22:59:18 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: > > > > > And sched_clock's use of local_irq_save/restore appears to be absolutely > > > correct, so I thi

lguest re-review

2007-05-09 Thread Andrew Morton
Some concern was expressed over the lguest review status, so I shall send the patches out again for people to review, to test, to make observations about the author's personal appearance, etc. I'll plan on sending these patches off to Linus in a week's time, assuming all goes well. Thanks. _

Re: lguest re-review

2007-05-09 Thread Andrew Morton
On Thu, 10 May 2007 10:24:08 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-09 at 02:51 -0700, Andrew Morton wrote: > > Some concern was expressed over the lguest review status, so I shall send > > the patches out again for people to review, to test,

Re: [1/2] [NET] link_watch: Move link watch list into net_device

2007-05-10 Thread Andrew Morton
On Thu, 10 May 2007 15:00:05 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Herbert Xu wrote: > > [NET] link_watch: Move link watch list into net_device > > > > These days the link watch mechanism is an integral part of the > > network subsystem as it manages the carrier status. So it now

Re: [PATCH 1/7] lguest documentation: infrastructure and Chapter I

2007-06-07 Thread Andrew Morton
On Fri, 08 Jun 2007 13:10:57 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > The netfilter code had very good documentation: the Netfilter Hacking > HOWTO. Noone ever read it. > > So this time I'm trying something different, using a bit of > Knuthiness. > > Signed-off-by: Rusty Russell <[EMAIL

Re: [PATCH 03/10] define ELF notes for adding to a boot image

2007-06-26 Thread Andrew Morton
On Fri, 15 Jun 2007 09:40:31 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > H. Peter Anvin wrote: > > Jeremy Fitzhardinge wrote: > > > >> +#define EIN_PROGRAM_CHECKSUM 3 /* ip style checksum of the memory > >> image. */ > >> > > > > Why on earth use one of the weakest verific

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Andrew Morton
On Sat, 21 Jul 2007 11:17:58 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > The netfilter code had very good documentation: the Netfilter Hacking > HOWTO. Noone ever read it. > > So this time I'm trying something different, using a bit of > Knuthiness. Start with drivers/lguest/README. um.

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Andrew Morton
On Tue, 24 Jul 2007 11:01:48 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > But I worry that you're proposing adding what appears to be new > > Documentation-related machinery and infrastructure when there's already > > increased activity in that area from other people and we might all be > >

Re: [PATCH v2 2/3] virtio: 9p: correctly pass physical address to userspace for high pages

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 14:03:32 +0100 Will Deacon wrote: > When using a virtio transport, the 9p net device may pass the physical > address of a kernel buffer to userspace via a scatterlist inside a > virtqueue. If the kernel buffer is mapped outside of the linear mapping > (e.g. highmem), then virt

Re: [PATCH v2 1/3] mm: highmem: export kmap_to_page for modules

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 14:03:31 +0100 Will Deacon wrote: > Some virtio device drivers (9p) need to translate high virtual addresses > to physical addresses, which are inserted into the virtqueue for > processing by userspace. > > This patch exports the kmap_to_page symbol, so that the affected driv

Re: [PATCH v11 1/7] mm: adjust address_space_operations.migratepage() return code

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:48 -0200 Rafael Aquini wrote: > This patch introduces MIGRATEPAGE_SUCCESS as the default return code > for address_space_operations.migratepage() method and documents the > expected return code for the same method in failure cases. I hit a large number of rejects applyi

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:52 -0200 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: [PATCH v11 3/7] mm: introduce a common interface for balloon pages mobility

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:50 -0200 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Thu, 08 Nov 2012 09:32:18 +1030 Rusty Russell wrote: > Rafael Aquini writes: > > + * virtballoon_migratepage - perform the balloon page migration on behalf > > of > > + * a compation thread. (called under page lock) > > > + if (!mutex_trylock(&vb->balloon_lock)) >

Re: [PATCH -next] virtio: balloon: fix missing unlock on error in fill_balloon()

2012-11-12 Thread Andrew Morton
On Mon, 12 Nov 2012 21:50:40 +0800 Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock before return from function fill_balloon() > in the error handling case. > > Introduced by 9864a8(virtio_balloon: introduce migration primitives > to balloon pages) > > dpatch engine is used t

Re: [PATCH v11 7/7] mm: add vm event counters for balloon pages compaction

2012-11-20 Thread Andrew Morton
On Fri, 9 Nov 2012 12:58:29 -0200 Rafael Aquini wrote: > On Fri, Nov 09, 2012 at 12:20:33PM +, Mel Gorman wrote: > > On Wed, Nov 07, 2012 at 01:05:54AM -0200, Rafael Aquini wrote: > > > This patch introduces a new set of vm event counters to keep track of > > > ballooned pages compaction acti

Re: [PATCH v11 4/7] mm: introduce compaction and migration for ballooned pages

2012-11-20 Thread Andrew Morton
On Fri, 9 Nov 2012 12:16:02 + Mel Gorman wrote: > On Wed, Nov 07, 2012 at 01:05:51AM -0200, Rafael Aquini wrote: > > Memory fragmentation introduced by ballooning might reduce significantly > > the number of 2MB contiguous memory blocks that can be used within a guest, > > thus imposing perfo

Re: [PATCH] drivers: virtio: Use PTR_RET function

2013-03-25 Thread Andrew Morton
On Tue, 26 Mar 2013 13:57:09 +1030 Rusty Russell wrote: > Alexandru Gheorghiu writes: > > > Used PTR_RET function instead of IS_ERR and PTR_ERR. > > Patch found using coccinelle. > > WTF is PTR_RET? PTR_RET doesn't return anything. Why is it called > that? It doesn't even make sense. > > Z

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-20 Thread Andrew Morton
On Fri, 16 Aug 2013 23:09:06 + "Nicholas A. Bellinger" wrote: > From: Kent Overstreet > > Percpu frontend for allocating ids. With percpu allocation (that works), > it's impossible to guarantee it will always be possible to allocate all > nr_tags - typically, some will be stuck on a remote

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 12:53:17 -0700 Kent Overstreet wrote: > > > + while (1) { > > > + spin_lock(&pool->lock); > > > + > > > + /* > > > + * prepare_to_wait() must come before steal_tags(), in case > > > + * percpu_ida_free() on another cpu flips a bit in > > > +

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 12:55:17 -0700 Kent Overstreet wrote: > Fixup patch, addressing Andrew's review feedback: Looks reasonable. > lib/idr.c | 38 +- I still don't think it should be in this file. You say that some as-yet-unmerged patches will tie

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 13:44:54 -0700 Kent Overstreet wrote: > > > > What guarantees that this wait will terminate? > > > > > > It seems fairly clear to me from the break statement a couple lines up; > > > if we were passed __GFP_WAIT we terminate iff we succesfully allocated a > > > tag. If we wer

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:00:10 -0700 Kent Overstreet wrote: > On Wed, Aug 28, 2013 at 01:25:50PM -0700, Andrew Morton wrote: > > On Wed, 28 Aug 2013 12:55:17 -0700 Kent Overstreet > > wrote: > > > > > Fixup patch, addressing Andrew's review feedback: > &g

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:12:17 -0700 Kent Overstreet wrote: > How's this look? > > diff --git a/lib/idr.c b/lib/idr.c > index 15c021c..a3f8e9a 100644 > --- a/lib/idr.c > +++ b/lib/idr.c > @@ -1288,6 +1288,11 @@ static inline unsigned alloc_local_tag(struct > percpu_ida *pool, > * Safe to be cal

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:23:58 -0700 Kent Overstreet wrote: > > I found things to be quite the opposite - it took 5 minutes of staring, > > head-scratching, double-checking and penny-dropping before I was > > confident that the newly-added code actually has nothing at all to do > > with the current

Re: [PATCH v2 27/29] mm/memory_hotplug: extend offline_and_remove_memory() to handle more than one memory block

2020-11-17 Thread Andrew Morton
i_scan_try_to_offline() simply onlines all memory in case > something goes wrong. It doesn't restore previous online type. Let's do > that, so we won't overwrite what e.g., user space configured. > > ... > uint8_t is a bit of a mouthful. u8 is less typing

Re: [PATCH v1 1/4] mm/memory_hotplug: use "unsigned long" for PFN in zone_for_pfn_range()

2021-07-15 Thread Andrew Morton
On Thu, 15 Jul 2021 11:42:21 +0200 David Hildenbrand wrote: > > I'd propose to add Cc: since I actually had > > the fun to try to debug something like this a couple of years ago: > > 6cdb18ad98a4 ("mm/vmstat: fix overflow in mod_zone_page_state()") > > > > Good point, and thinking again what c

Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread Andrew Morton
On Wed, 25 Jan 2023 00:37:05 +0800 kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next > specific files for 20230124 > > Error/Warning: (recently discovered

Re: [PATCH 1/3] sched/headers: Fix compilation error with GCC 12

2022-04-14 Thread Andrew Morton
On Thu, 14 Apr 2022 17:21:01 +0200 Peter Zijlstra wrote: > > +/* The + 1 below places the pointers within the range of their array */ > > #define for_class_range(class, _from, _to) \ > > - for (class = (_from); class != (_to); class--) > > + for (class = (_from); class + 1 != (_to) + 1; clas

Re: [PATCH v11 0/6] Use pageblock_order for cma and alloc_contig_range alignment.

2022-05-09 Thread Andrew Morton
On Mon, 25 Apr 2022 10:31:12 -0400 Zi Yan wrote: > This patchset tries to remove the MAX_ORDER-1 alignment requirement for CMA > and alloc_contig_range(). It prepares for my upcoming changes to make > MAX_ORDER adjustable at boot time[1]. I'm thinking this looks ready to be merged into mm-stable

Re: [PATCH] mm: fix a potential infinite loop in start_isolate_page_range().

2022-05-24 Thread Andrew Morton
On Tue, 24 May 2022 15:47:56 -0400 Zi Yan wrote: > From: Zi Yan > > In isolate_single_pageblock() called by start_isolate_page_range(), > there are some pageblock isolation issues causing a potential > infinite loop when isolating a page range. This is reported by Qian Cai. > > 1. the pagebloc

Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d

2022-05-25 Thread Andrew Morton
On Thu, 26 May 2022 05:35:20 +0800 kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 8cb8311e95e3bb58bd84d6350365f14a718faa6d Add linux-next > specific files for 20220525 > > Error/Warning reports: > > ... > >

Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d

2022-05-25 Thread Andrew Morton
On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke wrote: > This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t > i.e. a u64, which makes the shift without a cast of the LHS fishy. Ah, of course, thanks. I remember 32 bits ;) --- a/mm/shmem.c~mm-shmemc-suppress-shift-warning

Re: [PATCH v25 1/2 RESEND] mm: support reporting free page blocks

2018-01-25 Thread Andrew Morton
On Thu, 25 Jan 2018 17:38:27 +0800 Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either dete

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either dete

Re: [PATCH v29 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:53 +0800 Wei Wang wrote: > In some usages, e.g. virtio-balloon, a kernel module needs to know if > page poisoning is in use. This patch exposes the page_poisoning_enabled > function to kernel modules. Acked-by: Andr

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Andrew Morton
On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" wrote: > > Andrew, were your questions answered? If yes could I bother you for an ack on > this? > Still not very happy that readers are told that "this function may sleep" when it clearly doesn't do so. If we wish to be able to change

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 12:12:38 -0400 (EDT) Mikulas Patocka wrote: > The kvmalloc function tries to use kmalloc and falls back to vmalloc if > kmalloc fails. > > Unfortunatelly, some kernel code has bugs - it uses kvmalloc and then > uses DMA-API on the returned memory or frees it with kfree. Such

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 17:19:20 -0400 (EDT) Mikulas Patocka wrote: > > > In order to detect these bugs reliably I submit this patch that changes > > > kvmalloc to always use vmalloc if CONFIG_DEBUG_VM is turned on. > > > > > > ... > > > > > > --- linux-2.6.orig/mm/util.c 2018-04-18 15:46:23.0

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-05-01 Thread Andrew Morton
On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: >

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-07 Thread Andrew Morton
On Tue, 7 Jul 2015 13:36:20 +0900 Gioh Kim wrote: > From: Gioh Kim > > Hello, > > This series try to enable migration of non-LRU pages, such as driver's page. > > My ARM-based platform occured severe fragmentation problem after long-term > (several days) test. Sometimes even order-3 page all

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-07 Thread Andrew Morton
On Wed, 08 Jul 2015 09:02:59 +0900 Gioh Kim wrote: > > > 2015-07-08 __ 7:37___ Andrew Morton ___(___) ___ ___: > > On Tue, 7 Jul 2015 13:36:20 +0900 Gioh Kim wrote: > > > >> From: Gioh Kim > >> > >> Hello, > >> > >> This

Re: [PATCH v3 00/16] Support non-lru page migration

2016-03-30 Thread Andrew Morton
On Wed, 30 Mar 2016 16:11:59 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation > in embedded system(Android mobile phone, webOS TV and so on) > and failed to fork easily. > > The problem was fragmentation caused by zram and GPU driver > pages. Their pages cann

Re: [PATCH v4 00/13] Support non-lru page migration

2016-04-27 Thread Andrew Morton
On Wed, 27 Apr 2016 16:48:13 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation in embedded > system(Android mobile phone, webOS TV and so on) and easy fork fail. > > The problem was fragmentation caused by zram and GPU driver mainly. > With memory pressure, th

Re: [PATCH v7 00/12] Support non-lru page migration

2016-06-01 Thread Andrew Morton
On Wed, 1 Jun 2016 08:21:09 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation in embedded > system(Android mobile phone, webOS TV and so on) and easy fork fail. > > The problem was fragmentation caused by zram and GPU driver mainly. > With memory pressure, th

Re: [PATCHv2 1/2] mm: export use_mm/unuse_mm to modules

2009-09-16 Thread Andrew Morton
On Thu, 17 Sep 2009 08:38:18 +0300 "Michael S. Tsirkin" wrote: > Hi Andrew, > On Tue, Aug 11, 2009 at 03:10:10PM -0700, Andrew Morton wrote: > > On Wed, 12 Aug 2009 00:27:52 +0300 > > "Michael S. Tsirkin" wrote: > > > > > vhost net modu

Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()

2011-01-20 Thread Andrew Morton
On Thu, 20 Jan 2011 17:55:02 +0100 torbenh wrote: > On Thu, Jan 20, 2011 at 08:34:48AM -0800, Greg KH wrote: > > On Thu, Jan 20, 2011 at 04:58:13PM +0100, Torben Hohn wrote: > > > the -rt patches change the console_semaphore to console_mutex. > > > so a quite large chunk of the patches changes al

Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()

2011-01-21 Thread Andrew Morton
On Fri, 21 Jan 2011 09:10:06 +0100 Geert Uytterhoeven wrote: > include/linux/mutex.h: > > /* > * NOTE: mutex_trylock() follows the spin_trylock() convention, > * not the down_trylock() convention! > * > * Returns 1 if the mutex has been acquired successfully, and 0 on contention. > *

Re: [PATCH v2 0/3] kcov: collect coverage from usb and vhost

2019-10-23 Thread Andrew Morton
On Wed, 23 Oct 2019 17:24:28 +0200 Andrey Konovalov wrote: > This patchset extends kcov to allow collecting coverage from the USB > subsystem and vhost workers. See the first patch description for details > about the kcov extension. The other two patches apply this kcov extension > to USB and vh

Re: [PATCH v2 1/3] kcov: remote coverage support

2019-10-23 Thread Andrew Morton
On Wed, 23 Oct 2019 17:24:29 +0200 Andrey Konovalov wrote: > This patch adds background thread coverage collection ability to kcov. > > With KCOV_ENABLE coverage is collected only for syscalls that are issued > from the current process. With KCOV_REMOTE_ENABLE it's possible to collect > coverag

Re: [PATCH v2 0/3] kcov: collect coverage from usb and vhost

2019-10-24 Thread Andrew Morton
On Thu, 24 Oct 2019 14:47:31 +0200 Andrey Konovalov wrote: > > is it expected that the new kcov feature will be used elsewhere in the > > kernel? > > > > If the latter, which are the expected subsystems? > > Currently we encountered two cases where this is useful: USB and vhost > workers. Most

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Andrew Morton
On Fri, 20 Jan 2012 11:09:38 -0500 Konrad Rzeszutek Wilk wrote: > > > > > Did you test this patch with a large amount of minors? > > > > Sorry I didn't do runtime test. > > Please do. The poor guy probably doesn't know how to test it and surely it would be quite a lot of work for him to do so

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Andrew Morton
On Fri, 20 Jan 2012 18:55:08 -0500 Konrad Rzeszutek Wilk wrote: > On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote: > > On Fri, 20 Jan 2012 11:09:38 -0500 > > Konrad Rzeszutek Wilk wrote: > > > > > > > > > > > Did y

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:50:41 -0300 Rafael Aquini wrote: > This patch introduces the helper functions as well as the necessary changes > to teach compaction and migration bits how to cope with pages which are > part of a guest memory balloon, in order to make them movable by memory > compaction pr

Re: [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:50:42 -0300 Rafael Aquini wrote: > Besides making balloon pages movable at allocation time and introducing > the necessary primitives to perform balloon page migration/compaction, > this patch also introduces the following locking scheme to provide the > proper synchronizat

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 20:07:07 -0300 Rafael Aquini wrote: > > > > > +} > > > +#else > > > +static inline bool is_balloon_page(struct page *page) { return > > > false; } > > > +static inline bool isolate_balloon_page(struct page *page) { return > > > false; } > > > +static inline bool putb

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 22:00:48 -0300 Rafael Aquini wrote: > > So the function needs a better name - one which communicates that it is > > a balloon page *for the purposes of processing by the compaction code*. > > Making the function private to compaction.c would help with that, if > > feasible. >

Re: [PATCH v10 0/5] make balloon pages movable by compaction

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:15 -0300 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:18 -0300 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: [PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:16 -0300 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > transparen

Re: [PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-18 Thread Andrew Morton
On Tue, 18 Sep 2012 13:24:21 -0300 Rafael Aquini wrote: > On Mon, Sep 17, 2012 at 03:15:43PM -0700, Andrew Morton wrote: > > > +/* return code to identify when a ballooned page has been migrated */ > > > +#define BALLOON_MIGRATION_RETURN 0xba1100 > > > > I d

Re: [PATCH kernel v8 3/4] mm: add inerface to offer info about unused pages

2017-03-16 Thread Andrew Morton
On Thu, 16 Mar 2017 15:08:46 +0800 Wei Wang wrote: > From: Liang Li > > This patch adds a function to provides a snapshot of the present system > unused pages. An important usage of this function is to provide the > unsused pages to the Live migration thread, which skips the transfer of > those

Re: [PATCH v9 3/5] mm: function to offer a page block on the free list

2017-04-13 Thread Andrew Morton
On Thu, 13 Apr 2017 17:35:06 +0800 Wei Wang wrote: > Add a function to find a page block on the free list specified by the > caller. Pages from the page block may be used immediately after the > function returns. The caller is responsible for detecting or preventing > the use of such pages. > >

Re: [PATCH v13 1/5] Introduce xbitmap

2017-08-09 Thread Andrew Morton
On Thu, 3 Aug 2017 14:38:15 +0800 Wei Wang wrote: > From: Matthew Wilcox > > The eXtensible Bitmap is a sparse bitmap representation which is > efficient for set bits which tend to cluster. It supports up to > 'unsigned long' worth of bits, and this commit adds the bare bones -- > xb_set_bit(

Re: [PATCH v18 01/10] idr: add #include

2017-11-30 Thread Andrew Morton
On Wed, 29 Nov 2017 16:58:17 -0800 Matthew Wilcox wrote: > On Wed, Nov 29, 2017 at 09:55:17PM +0800, Wei Wang wrote: > > The was removed from radix-tree.h by the following commit: > > f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890. > > > > Since that commit, tools/testing/radix-tree/ couldn't pass co

Re: [PATCH v2 07/10] mm/memory_hotplug: Introduce offline_and_remove_memory()

2020-04-14 Thread Andrew Morton
gt; Lost the ACK from Michael > > > > Acked-by: Michal Hocko [1] > > > > [1] https://lkml.kernel.org/r/20200302142737.gp4...@dhcp22.suse.cz > > > Andrew, could you pls ack merging this through the vhost tree, > with the rest of the patchset? I wish th

Re: [PATCH v2 05/10] mm: Allow to offline unmovable PageOffline() pages via MEM_GOING_OFFLINE

2020-04-14 Thread Andrew Morton
On Tue, 14 Apr 2020 12:34:26 -0400 "Michael S. Tsirkin" wrote: > Andrew, could you please ack merging this through the vhost tree > together with the rest of the patches? Acked-by: Andrew Morton ___ Virtualization mailing lis

Re: [PATCH v2 2/3] mm/memory_hotplug: Introduce MHP_NO_FIRMWARE_MEMMAP

2020-04-30 Thread Andrew Morton
On Thu, 30 Apr 2020 20:43:39 +0200 David Hildenbrand wrote: > > > > Why does the firmware map support hotplug entries? > > I assume: > > The firmware memmap was added primarily for x86-64 kexec (and still, is > mostly used on x86-64 only IIRC). There, we had ACPI hotplug. When DIMMs > get hotp

  1   2   >