On Fri, Jun 2, 2023 at 5:22 PM Xuan Zhuo wrote:
>
> Introduce the module param "experiment_premapped" to enable the function
> that the virtio-net do dma mapping.
>
> If that is true, the vq of virtio-net is under the premapped mode.
> It just handle the sg with dma_address. And the driver must ge
type.
>
> Signed-off-by: Maxime Coquelin
Acked-by: Jason Wang
Thanks
> ---
> drivers/vdpa/vdpa_user/vduse_dev.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
> b/drivers/vdpa/vdpa_user/vduse_de
t;
> Signed-off-by: Maxime Coquelin
Acked-by: Jason Wang
Thanks
> ---
> drivers/vdpa/vdpa_user/vduse_dev.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c
> b/drivers/vdpa/vdpa_user/vduse_dev.c
> index c1c2f4c711ae
On Tue, Jun 27, 2023 at 5:05 PM Xuan Zhuo wrote:
>
> On Tue, 27 Jun 2023 16:03:26 +0800, Jason Wang wrote:
> > On Fri, Jun 2, 2023 at 5:22 PM Xuan Zhuo wrote:
> > >
> > > If the vq is the premapped mode, use the sg_dma_address() directly.
> &
On Wed, Jun 28, 2023 at 2:02 PM Xuan Zhuo wrote:
>
> On Wed, 28 Jun 2023 12:07:10 +0800, Jason Wang wrote:
> > On Tue, Jun 27, 2023 at 5:05 PM Xuan Zhuo
> > wrote:
> > >
> > > On Tue, 27 Jun 2023 16:03:26 +0800, Jason Wang
> > > wrote:
>
On Wed, Jun 28, 2023 at 2:59 PM Cindy Lu wrote:
>
> From: Your Name
It looks to me your git is not properly configured.
>
> this struct is to save the reconnect info struct, in this
> struct saved the page info that alloc to save the
> reconnect info
>
> Signed-off-by: Cindy Lu
> ---
> driver
On Wed, Jun 28, 2023 at 2:59 PM Cindy Lu wrote:
>
> From: Your Name
>
> Add the operation for mmap, The user space APP will
> use this function to map the pages to userspace
Please be specific in the log. E.g why and what the main goal for this mmap.
>
> Signed-off-by: Cindy Lu
> ---
> driver
On Wed, Jun 28, 2023 at 2:59 PM Cindy Lu wrote:
>
> From: Your Name
>
> Add the function for get/free pages, ad this info
> will saved in dev->reconnect_info
I think this should be squashed to patch 2 otherwise it fixes a bug
that is introduced in patch 2?
>
> Signed-off-by: Cindy Lu
> ---
>
On Wed, Jun 28, 2023 at 3:00 PM Cindy Lu wrote:
>
> From: Your Name
>
> in VDUSE_VQ_GET_INFO, driver will sync the last_avail_idx
> with reconnect info, I have olny test the split mode, so
Typo, should be "only".
> only use this here, will add more information later
>
> Signed-off-by: Cindy Lu
On Wed, Jun 28, 2023 at 9:34 PM Michael S. Tsirkin wrote:
>
> On Wed, May 31, 2023 at 09:07:25AM +0800, Jason Wang wrote:
> > On Mon, May 29, 2023 at 9:21 AM Jason Wang wrote:
> > >
> > > On Sun, May 28, 2023 at 7:39 PM Michael S. Tsirkin
> > > wrote:
>
On Fri, Jun 30, 2023 at 10:37 AM Zhu Lingshan wrote:
>
> This commits synchronizes irqs when free them
Need to explain why it is needed.
>
> Signed-off-by: Zhu Lingshan
> Tested-by: Cindy Lu
> ---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/d
On Sat, Jul 1, 2023 at 5:25 PM Cindy Lu wrote:
>
> On Wed, Jun 28, 2023 at 4:04 PM Jason Wang wrote:
> >
> > On Wed, Jun 28, 2023 at 2:59 PM Cindy Lu wrote:
> > >
> > > From: Your Name
> >
> > It looks to me your git is not properly config
st-vdpa using DPDK Vhost library series
> > adding VDUSE support using split rings layout (merged in
> > DPDK v23.07-rc1).
> >
> > Control queue support (and so multiqueue) has also been
> > tested, but requires a Kernel series from Jason Wang
> > relaxing control que
On Mon, Jul 3, 2023 at 3:43 PM Maxime Coquelin
wrote:
>
>
> On 7/3/23 08:44, Jason Wang wrote:
> > On Sun, Jul 2, 2023 at 9:37 PM Michael S. Tsirkin wrote:
> >>
> >> On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote:
> >>> This small s
On Tue, Jul 4, 2023 at 6:16 PM Michael S. Tsirkin wrote:
>
> On Mon, Jul 03, 2023 at 05:26:02PM -0700, Si-Wei Liu wrote:
> >
> >
> > On 7/3/2023 8:46 AM, Michael S. Tsirkin wrote:
> > > On Mon, Jul 03, 2023 at 04:25:14PM +0200, Eugenio Pérez wrote:
> > > > Offer this backend feature as mlx5 is com
On Wed, Jul 5, 2023 at 1:31 PM Michael S. Tsirkin wrote:
>
> On Wed, Jul 05, 2023 at 01:11:37PM +0800, Jason Wang wrote:
> > On Tue, Jul 4, 2023 at 6:16 PM Michael S. Tsirkin wrote:
> > >
> > > On Mon, Jul 03, 2023 at 05:26:02PM -0700, Si-Wei Liu wrote:
> >
On Wed, Jul 5, 2023 at 1:41 PM Liang Chen wrote:
>
> On Fri, Jun 9, 2023 at 10:57 AM Liang Chen wrote:
> >
> > On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote:
> > >
> > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote:
> > > >
> &g
On Wed, Jul 5, 2023 at 2:16 PM Michael S. Tsirkin wrote:
>
> On Wed, Jul 05, 2023 at 01:47:44PM +0800, Jason Wang wrote:
> > On Wed, Jul 5, 2023 at 1:31 PM Michael S. Tsirkin wrote:
> > >
> > > On Wed, Jul 05, 2023 at 01:11:37PM +0800, Jason Wang wrote:
> >
On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote:
> > On Tue, Jul 4, 2023 at 12:38 PM Michael S. Tsirkin wrote:
> > >
> > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote:
> > > > On Mon, Jul 3
On Tue, Jul 4, 2023 at 6:38 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote:
> > On Mon, Jul 3, 2023 at 4:52 PM Michael S. Tsirkin wrote:
> > >
> > > On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio Pérez wrote:
> > > > With the current code
On Wed, Jul 5, 2023 at 4:41 PM Michael S. Tsirkin wrote:
>
> On Wed, Jul 05, 2023 at 03:49:58PM +0800, Jason Wang wrote:
> > On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote:
> > >
> > > On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote:
On Wed, Jul 5, 2023 at 4:42 PM Michael S. Tsirkin wrote:
>
> On Wed, Jul 05, 2023 at 03:55:23PM +0800, Jason Wang wrote:
> > On Tue, Jul 4, 2023 at 6:38 PM Michael S. Tsirkin wrote:
> > >
> > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote:
&g
gt;
> Some work is on-going to make the control queue
> implementation robust with VDUSE. Until it is completed,
> let's filter out control virtqueue and features that depend
> on it by keeping only features known to be supported.
>
> Signed-off-by: Maxime Coquelin
Acked-
On Thu, Jul 6, 2023 at 3:06 PM Eugenio Perez Martin wrote:
>
> On Thu, Jul 6, 2023 at 3:55 AM Jason Wang wrote:
> >
> > On Wed, Jul 5, 2023 at 4:41 PM Michael S. Tsirkin wrote:
> > >
> > > On Wed, Jul 05, 2023 at 03:49:58PM +0800, Jason Wang wrote:
>
On Thu, Jul 6, 2023 at 3:55 PM Jason Wang wrote:
>
> On Thu, Jul 6, 2023 at 3:06 PM Eugenio Perez Martin
> wrote:
> >
> > On Thu, Jul 6, 2023 at 3:55 AM Jason Wang wrote:
> > >
> > > On Wed, Jul 5, 2023 at 4:41 PM Michael S. Tsirkin wrote:
> > &
On Fri, Jun 30, 2023 at 8:36 AM Shannon Nelson wrote:
>
> From: Allen Hubbe
>
> When the vdpa device is reset, also reinitialize it with the mac address
> that was assigned when the device was added.
>
> Fixes: 151cc834f3dd ("pds_vdpa: add support for vdpa and vdpamgmt interfaces")
> Signed-off-b
On Fri, Jun 30, 2023 at 8:36 AM Shannon Nelson wrote:
>
> Make sure that we initialize the vqs[] entries the same
> way both for initial setup and after a vq reset.
>
> Fixes: 151cc834f3dd ("pds_vdpa: add support for vdpa and vdpamgmt interfaces")
> Signed-off-by: Shannon Nelson
> Reviewed-by: Br
mt interfaces")
> Signed-off-by: Allen Hubbe
> Signed-off-by: Shannon Nelson
> Reviewed-by: Brett Creeley
Acked-by: Jason Wang
Thanks
> ---
> drivers/vdpa/pds/vdpa_dev.c | 110 ++--
> 1 file changed, 81 insertions(+), 29 deletions(-)
>
&g
On Fri, Jun 30, 2023 at 8:36 AM Shannon Nelson wrote:
>
> Our driver sets a mac if the HW is 00:..:00 so we need to be sure to
> advertise VIRTIO_NET_F_MAC even if the HW doesn't. We also need to be
> sure that virtio_net sees the VIRTIO_NET_F_MAC and doesn't rewrite the
> mac address that a user
On Thu, Jul 6, 2023 at 5:39 PM Eugenio Perez Martin wrote:
>
> On Thu, Jul 6, 2023 at 10:03 AM Jason Wang wrote:
> >
> > On Thu, Jul 6, 2023 at 3:55 PM Jason Wang wrote:
> > >
> > > On Thu, Jul 6, 2023 at 3:06 PM Eugenio Perez Martin
> > > wrote:
&
On Sat, Jul 8, 2023 at 4:12 AM Shannon Nelson wrote:
>
>
>
> On 7/7/23 12:33 AM, Jason Wang wrote:
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> &g
;
> Link:
> https://lore.kernel.org/linux-next/fec68c3c-8249-7af4-5390-0495386a7...@infradead.org/
> Fixes: a16291b5bcbb ("pds_vdpa: Add new vDPA driver for AMD/Pensando DSC")
> Signed-off-by: Shannon Nelson
Acked-by: Jason Wang
Thanks
> ---
> drivers/vdpa/pds/Makefil
On Mon, Jul 10, 2023 at 8:41 PM Xuan Zhuo wrote:
>
> On Mon, 10 Jul 2023 07:59:03 -0400, "Michael S. Tsirkin"
> wrote:
> > On Mon, Jul 10, 2023 at 06:18:30PM +0800, Xuan Zhuo wrote:
> > > On Mon, 10 Jul 2023 05:40:21 -0400, "Michael S. Tsirkin"
> > > wrote:
> > > > On Mon, Jul 10, 2023 at 11:4
On Tue, Jul 11, 2023 at 10:42 AM Xuan Zhuo wrote:
>
> On Tue, 11 Jul 2023 10:36:17 +0800, Jason Wang wrote:
> > On Mon, Jul 10, 2023 at 8:41 PM Xuan Zhuo
> > wrote:
> > >
> > > On Mon, 10 Jul 2023 07:59:03 -0400, "Michael S. Tsirkin"
> >
rs/net/virtio_net.c | 35 +++
> 1 file changed, 19 insertions(+), 16 deletions(-)
>
Acked-by: Jason Wang
Thanks
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 0db14f6b87d3..dd5fec073a27 100644
> --- a/drivers/net/virtio_net.c
&g
rs/net/virtio_net.c | 22 +-
> 1 file changed, 17 insertions(+), 5 deletions(-)
>
Acked-by: Jason Wang
Thanks
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index dd5fec073a27..802ed21453f5 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/vir
On Mon, Jul 10, 2023 at 5:21 PM Gavin Li wrote:
> Add interrupt_coalesce config in send_queue and receive_queue to cache user
> config.
>
> Send per virtqueue interrupt moderation config to underline device in order
> to have more efficient interrupt moderation and cpu utilization of guest
> VM.
On Mon, Jul 10, 2023 at 11:42 AM Xuan Zhuo
wrote:
> This helper allows the driver change the dma mode to premapped mode.
> Under the premapped mode, the virtio core do not do dma mapping
> internally.
>
> This just work when the use_dma_api is true. If the use_dma_api is false,
> the dma options
On Mon, Jul 10, 2023 at 11:42 AM Xuan Zhuo wrote:
>
> If the vq is the premapped mode, use the sg_dma_address() directly.
>
> Signed-off-by: Xuan Zhuo
> ---
> drivers/virtio/virtio_ring.c | 19 +--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio
On Mon, Jul 10, 2023 at 11:42 AM Xuan Zhuo wrote:
>
> Added virtqueue_dma_dev() to get DMA device for virtio. Then the
> caller can do dma operation in advance. The purpose is to keep memory
> mapped across multiple add/get buf operations.
>
> Signed-off-by: Xuan Zhuo
Ac
On Wed, Jul 12, 2023 at 4:33 PM Xuan Zhuo wrote:
>
> On Wed, 12 Jul 2023 15:54:58 +0800, Xuan Zhuo
> wrote:
> > On Tue, 11 Jul 2023 10:58:51 +0800, Jason Wang wrote:
> > > On Tue, Jul 11, 2023 at 10:42 AM Xuan Zhuo
> > > wrote:
> > > >
> >
On Mon, Jul 10, 2023 at 11:42 AM Xuan Zhuo wrote:
>
> Now we add a case where we skip dma unmap, the vq->premapped is true.
>
> We can't just rely on use_dma_api to determine whether to skip the dma
> operation. For convenience, I introduced the "do_unmap". By default, it
> is the same as use_dma_
On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo wrote:
>
I'd suggest to tweak the title like:
"merge dma operations when refilling mergeable buffers"
> Currently, the virtio core will perform a dma operation for each
> operation.
"for each buffer"?
> Although, the same page may be operated multipl
On Thu, Jul 13, 2023 at 12:06 PM Xuan Zhuo wrote:
>
> On Thu, 13 Jul 2023 11:50:57 +0800, Jason Wang wrote:
> > On Mon, Jul 10, 2023 at 11:42 AM Xuan Zhuo
> > wrote:
> > >
> > > Now we add a case where we skip dma unmap, the vq->premapped is true.
> &
interfaces")
> Signed-off-by: Allen Hubbe
> Signed-off-by: Shannon Nelson
Acked-by: Jason Wang
Thanks
> ---
> drivers/vdpa/pds/vdpa_dev.c | 16
> drivers/vdpa/pds/vdpa_dev.h | 1 +
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff
O_NET_F_MAC before
> finishing the feature negotiation. If the user specifies a device_features
> bitpattern in the vdpa utility without the VIRTIO_NET_F_MAC set, then
> don't set the mac.
>
> Fixes: 151cc834f3dd ("pds_vdpa: add support for vdpa and vdpamgmt interface
y: Shannon Nelson
Acked-by: Jason Wang
Thanks
> ---
> drivers/vdpa/pds/vdpa_dev.c | 24 +---
> 1 file changed, 17 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/vdpa/pds/vdpa_dev.c b/drivers/vdpa/pds/vdpa_dev.c
> index 5b566e0eef0a..04a362648b02 1006
On Tue, Jul 11, 2023 at 12:25 PM Shannon Nelson wrote:
>
> Make clearer in debugfs output the difference between the hw
> feature bits, the features supported through the driver, and
> the features that have been negotiated.
>
> Signed-off-by: Shannon Nelson
Acked-by: J
On Thu, Jul 13, 2023 at 2:54 PM Xuan Zhuo wrote:
>
> On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang wrote:
> > On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo
> > wrote:
> > >
> >
> > I'd suggest to tweak the title like:
> >
> >
On Thu, Jul 13, 2023 at 3:02 PM Xuan Zhuo wrote:
>
> On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang wrote:
> > On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo
> > wrote:
> > >
> >
> > I'd suggest to tweak the title like:
> >
> >
On Fri, Jul 14, 2023 at 12:37 PM Xuan Zhuo wrote:
>
> On Fri, 14 Jul 2023 11:57:05 +0800, Jason Wang wrote:
> > On Thu, Jul 13, 2023 at 3:02 PM Xuan Zhuo
> > wrote:
> > >
> > > On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang
> > > wrote:
>
On Sat, Jul 15, 2023 at 10:20 PM Mike Christie
wrote:
>
> I've been doing a lot of the development on vhost-scsi the last couple of
> years, so per Michael T's suggestion this adds me as co-maintainer.
>
> Signed-off-by: Mike Christie
Acked-by: Jason Wang
Thanks
> > > > On Wed, 12 Jul 2023 16:37:43 +0800, Jason Wang
> > > > wrote:
> > > > > On Wed, Jul 12, 2023 at 4:33 PM Xuan Zhuo
> > > > > wrote:
> > > > > >
> > > > > > On Wed, 12 Jul 2023 15:54:58 +0800, Xuan Z
On Wed, Jul 19, 2023 at 11:46 PM Feng Liu wrote:
>
> The 'is_legacy' flag is used to differentiate between legacy vs modern
> device. Currently, it is based on the value of vp_dev->ldev.ioaddr.
> However, due to the shared memory of the union between struct
> virtio_pci_legacy_device and struct vi
On Thu, Jul 20, 2023 at 2:23 PM Christoph Hellwig wrote:
>
> Hi Jason,
>
> can you please resend your reply with proper quoting? I had to give
> up after multiple pages of scrolling without finding anything that
> you added to the full quote.
I guess it's this part?
> > > You should also test w
buffer manually since the virtio core check more_used() instead
Jason Wang (2):
virtio-net: convert rx mode setting to use workqueue
virtio-net: add cond_resched() to the command waiting loop
drivers/net/virtio_net.c | 59 +---
1 file changed, 55 insertions(
lost after resuming. This is not the
bug of this patch as we never try to restore rx mode setting during
resume.
Signed-off-by: Jason Wang
---
drivers/net/virtio_net.c | 55 +---
1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/drivers/net
Adding cond_resched() to the command waiting loop for a better
co-operation with the scheduler. This allows to give CPU a breath to
run other task(workqueue) instead of busy looping when preemption is
not allowed on a device whose CVQ might be slow.
Signed-off-by: Jason Wang
---
drivers/net
>> On Fri, Jul 21, 2023 at 04:37:00PM +0200, Maxime Coquelin wrote:
> >>>>
> >>>>
> >>>> On 7/20/23 23:02, Michael S. Tsirkin wrote:
> >>>>> On Thu, Jul 20, 2023 at 01:26:20PM -0700, Shannon Nelson wrote:
> >>>>>> On
ng cond_resched() to the command waiting loop for a better
> > > > > > > > > co-operation with the scheduler. This allows to give CPU a
> > > > > > > > > breath to
> > > > > > > > > run other task(workqueue) instead of busy l
On Sun, Jul 23, 2023 at 6:02 PM Michael S. Tsirkin wrote:
>
> On Sun, Jul 23, 2023 at 05:48:46PM +0800, Lin Ma wrote:
> >
> > > Sure, that is another undergoing task I'm working on. If the nlattr is
> > > parsed with
> > > NL_VALIDATE_UNSPEC, any forgotten nlattr will be rejected, therefore
> >
On Mon, Jul 24, 2023 at 3:18 PM Michael S. Tsirkin wrote:
>
> On Mon, Jul 24, 2023 at 02:52:49PM +0800, Jason Wang wrote:
> > On Mon, Jul 24, 2023 at 2:46 PM Michael S. Tsirkin wrote:
> > >
> > > On Fri, Jul 21, 2023 at 10:18:03PM +0200, Maxime Coquelin wrote:
>
On Mon, Jul 24, 2023 at 3:17 PM Michael S. Tsirkin wrote:
>
> On Mon, Jul 24, 2023 at 02:52:05PM +0800, Jason Wang wrote:
> > On Sat, Jul 22, 2023 at 4:18 AM Maxime Coquelin
> > wrote:
> > >
> > >
> > >
> > > On 7/21/23 17:10, Michael S. Tsi
On Mon, Jul 24, 2023 at 9:14 PM Feng Liu wrote:
>
>
>
> On 2023-07-20 p.m.1:14, Michael S. Tsirkin wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Thu, Jul 20, 2023 at 10:27:04AM +0800, Jason Wang wrote:
> >> On
at that time.
Fixes: a220871be66f ("virtio-net: correctly enable multiqueue")
Signed-off-by: Jason Wang
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 0db14f6b87d3..1270c8d23
On Tue, Jul 25, 2023 at 3:53 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 25, 2023 at 03:20:49AM -0400, Jason Wang wrote:
> > A race were found where set_channels could be called after registering
> > but before virtnet_set_queues() in virtnet_probe(). Fixing this
On Tue, Jul 25, 2023 at 3:36 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 25, 2023 at 11:07:40AM +0800, Jason Wang wrote:
> > On Mon, Jul 24, 2023 at 3:17 PM Michael S. Tsirkin wrote:
> > >
> > > On Mon, Jul 24, 2023 at 02:52:05PM +0800, Jason Wang wrote:
> >
NAPI polling work is scheduled
> and the time it is executed.
>
> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Cc: xieyon...@bytedance.com
>
> Suggested-by: Jason Wang
> Signed-off-by: Maxime Coquelin
Acked-by: Jason Wang
Than
On Tue, Jul 18, 2023 at 6:32 PM Stefano Garzarella wrote:
>
> On Thu, Apr 20, 2023 at 6:20 AM Jason Wang wrote:
> >
> > On Wed, Apr 19, 2023 at 11:33 PM Eugenio Perez Martin
> > wrote:
> > >
> > > On Wed, Apr 19, 2023 at 12:56 AM wrote:
> > >
On Wed, Jul 26, 2023 at 7:38 PM Michael S. Tsirkin wrote:
>
> On Wed, Jul 26, 2023 at 09:55:37AM +0800, Jason Wang wrote:
> > On Tue, Jul 25, 2023 at 3:36 PM Michael S. Tsirkin wrote:
> > >
> > > On Tue, Jul 25, 2023 at 11:07:40AM +0800, Jason Wang wrote:
> >
ot;)
> Signed-off-by: Gal Pressman
> Reviewed-by: Dragos Tatulea
Acked-by: Jason Wang
Thanks
> ---
> drivers/virtio/virtio_vdpa.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 989e2d7184ce
On Thu, Jul 27, 2023 at 2:10 PM Michael S. Tsirkin wrote:
>
> On Thu, Jul 27, 2023 at 02:03:59PM +0800, Jason Wang wrote:
> > On Wed, Jul 26, 2023 at 7:38 PM Michael S. Tsirkin wrote:
> > >
> > > On Wed, Jul 26, 2023 at 09:55:37AM +0800, Jason Wang wrote:
> >
On Fri, Jul 28, 2023 at 1:25 AM Dragos Tatulea wrote:
>
> The standard specifies that the initial number of queues is the
> default, which is 1 (1 tx, 1 rx).
>
> Signed-off-by: Dragos Tatulea
> Reviewed-by: Eugenio Pérez
Acked-by: Jason Wang
Thanks
> ---
> drivers/v
On Thu, Jul 27, 2023 at 9:28 PM Paolo Abeni wrote:
>
> On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote:
> > Add interrupt_coalesce config in send_queue and receive_queue to cache user
> > config.
> >
> > Send per virtqueue interrupt moderation config to underlying device in
> > order to have mor
On Fri, Jul 28, 2023 at 11:03 PM Jakub Kicinski wrote:
>
> On Fri, 28 Jul 2023 14:02:33 +0800 Xuan Zhuo wrote:
> > Hi guys, this topic is stuck again. How should I proceed with this work?
> >
> > Let me briefly summarize:
> > 1. The problem with adding virtio_dma_{map, sync} api is that, for AF_XD
all the VQs when updating the global configuration,
as now the individual VQs configuration can diverge from the global
configuration.
Signed-off-by: Gavin Li
Reviewed-by: Dragos Tatulea
Reviewed-by: Jiri Pirko
Acked-by: Michael S. Tsirkin
Reviewed-by: Heng Qi
Acked-by: Jason Wang
Thanks
在 2023/7/25 21:07, Gavin Li 写道:
Enable per queue interrupt coalesce feature bit in driver and validate its
dependency with control queue.
Signed-off-by: Gavin Li
Reviewed-by: Dragos Tatulea
Reviewed-by: Jiri Pirko
Acked-by: Michael S. Tsirkin
Reviewed-by: Heng Qi
Acked-by: Jason Wang
在 2023/7/28 13:46, Michael S. Tsirkin 写道:
On Thu, Jul 27, 2023 at 03:28:32PM +0200, Paolo Abeni wrote:
On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote:
Add interrupt_coalesce config in send_queue and receive_queue to cache user
config.
Send per virtqueue interrupt moderation config to under
On Thu, Jul 27, 2023 at 5:46 PM Michael S. Tsirkin wrote:
>
> On Thu, Jul 27, 2023 at 04:59:33PM +0800, Jason Wang wrote:
> > > They really shouldn't - any NIC that takes forever to
> > > program will create issues in the networking stack.
> >
> > Unfor
On Mon, Jul 31, 2023 at 5:08 PM Michael S. Tsirkin wrote:
>
> On Mon, Jul 31, 2023 at 07:15:31AM +, Dragos Tatulea wrote:
> > On Thu, 2023-07-27 at 12:28 -0400, Michael S. Tsirkin wrote:
> > > On Thu, Jul 27, 2023 at 04:02:16PM +, Dragos Tatulea wrote:
> > > > On Wed, 2023-07-26 at 15:26 -
On Tue, Aug 1, 2023 at 4:17 PM Dragos Tatulea wrote:
>
> On Tue, 2023-08-01 at 11:59 +0800, Jason Wang wrote:
> > On Mon, Jul 31, 2023 at 5:08 PM Michael S. Tsirkin wrote:
> > >
> > > On Mon, Jul 31, 2023 at 07:15:31AM +, Dragos Tatulea wrote:
> > &
sses.
We create the 1:1 MR in mlx5_vdpa_dev_add() only in case firmware
supports the general capability umem_uid_0. The reason for that is that
1:1 MRs must be created with uid == 0 while virtqueue objects can be
created with uid == 0 only when the firmware capability is on.
On Mon, Aug 7, 2023 at 2:15 PM Xuan Zhuo wrote:
>
> On Wed, 2 Aug 2023 09:49:31 +0800, Xuan Zhuo
> wrote:
> > On Tue, 1 Aug 2023 12:17:47 -0400, "Michael S. Tsirkin"
> > wrote:
> > > On Fri, Jul 28, 2023 at 02:02:33PM +0800, Xuan Zhuo wrote:
> > > > On Tue, 25 Jul 2023 19:07:23 +0800, Xuan Zhu
On Mon, Jul 31, 2023 at 2:30 PM Jason Wang wrote:
>
> On Thu, Jul 27, 2023 at 5:46 PM Michael S. Tsirkin wrote:
> >
> > On Thu, Jul 27, 2023 at 04:59:33PM +0800, Jason Wang wrote:
> > > > They really shouldn't - any NIC that takes forever to
> > > &g
On Thu, Aug 3, 2023 at 7:40 PM Dragos Tatulea wrote:
>
> On Thu, 2023-08-03 at 16:03 +0800, Jason Wang wrote:
> > On Thu, Aug 3, 2023 at 1:13 AM Dragos Tatulea wrote:
> > >
> > > The mr->initialized flag is shared between the control vq and data vq
> > &
On Fri, Aug 4, 2023 at 1:58 AM Si-Wei Liu wrote:
>
>
>
> On 8/3/2023 1:03 AM, Jason Wang wrote:
> > On Thu, Aug 3, 2023 at 1:13 AM Dragos Tatulea wrote:
> >> The mr->initialized flag is shared between the control vq and data vq
> >> part of the mr init/un
On Tue, Aug 8, 2023 at 10:52 AM Xuan Zhuo wrote:
>
> On Tue, 8 Aug 2023 10:26:04 +0800, Jason Wang wrote:
> > On Mon, Aug 7, 2023 at 2:15 PM Xuan Zhuo wrote:
> > >
> > > On Wed, 2 Aug 2023 09:49:31 +0800, Xuan Zhuo
> > > wrote:
> > > > On
On Tue, Aug 8, 2023 at 11:12 AM Xuan Zhuo wrote:
>
> On Tue, 8 Aug 2023 11:08:09 +0800, Jason Wang wrote:
> > On Tue, Aug 8, 2023 at 10:52 AM Xuan Zhuo
> > wrote:
> > >
> > > On Tue, 8 Aug 2023 10:26:04 +0800, Jason Wang wrote:
> > > > On Mon,
On Tue, Aug 8, 2023 at 11:57 AM Xuan Zhuo wrote:
>
> On Tue, 8 Aug 2023 11:49:08 +0800, Jason Wang wrote:
> > On Tue, Aug 8, 2023 at 11:12 AM Xuan Zhuo
> > wrote:
> > >
> > > On Tue, 8 Aug 2023 11:08:09 +0800, Jason Wang wrote:
> > > > On Tue, A
On Tue, Aug 8, 2023 at 1:11 PM Yuan Yao wrote:
>
> In current packed virtqueue implementation, the avail_wrap_counter won't
> flip, in the case when the driver supplies a descriptor chain with a
> length equals to the queue size; total_sg == vq->packed.vring.num.
>
> Let’s assume the following sit
On Tue, Aug 8, 2023 at 1:59 PM Michael S. Tsirkin wrote:
>
> On Tue, Aug 08, 2023 at 01:43:02PM +0800, Jason Wang wrote:
> > On Tue, Aug 8, 2023 at 1:11 PM Yuan Yao wrote:
> > >
> > > In current packed virtqueue implementation, the avail_wrap_counter won't
>
nks
>
>
> Best regards
>
>
>
> On Tue, Aug 8, 2023 at 2:43 PM Jason Wang wrote:
>>
>> On Tue, Aug 8, 2023 at 1:11 PM Yuan Yao wrote:
>> >
>> > In current packed virtqueue implementation, the avail_wrap_counter won't
>> > flip, in the c
On Tue, Aug 8, 2023 at 3:24 PM Dragos Tatulea wrote:
>
> On Tue, 2023-08-08 at 10:57 +0800, Jason Wang wrote:
> > On Thu, Aug 3, 2023 at 7:40 PM Dragos Tatulea wrote:
> > >
> > > On Thu, 2023-08-03 at 16:03 +0800, Jason Wang wrote:
> > > > On
On Tue, Aug 8, 2023 at 7:35 PM Dragos Tatulea wrote:
>
> On Tue, 2023-07-25 at 03:20 -0400, Jason Wang wrote:
> > A race were found where set_channels could be called after registering
> > but before virtnet_set_queues() in virtnet_probe(). Fixing this by
> > movin
6 ("virtio-net: fix race between set queues and probe")
Reported-by: Dragos Tatulea
Signed-off-by: Jason Wang
---
The patch is needed for -stable.
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/ne
On Wed, Aug 9, 2023 at 2:23 PM Dragos Tatulea wrote:
>
> On Tue, 2023-08-08 at 23:13 -0400, Jason Wang wrote:
> > Commit 25266128fe16 ("virtio-net: fix race between set queues and
> > probe") tries to fix the race between set queues and probe by calling
> > _vir
On Wed, Aug 9, 2023 at 6:58 AM Si-Wei Liu wrote:
>
>
>
> On 8/7/2023 8:00 PM, Jason Wang wrote:
> > On Fri, Aug 4, 2023 at 1:58 AM Si-Wei Liu wrote:
> >>
> >>
> >> On 8/3/2023 1:03 AM, Jason Wang wrote:
> >>> On Thu, Aug 3, 2023 at 1:13
On Thu, Aug 3, 2023 at 10:37 PM Stefan Hajnoczi wrote:
>
> Hi,
> After running "driverctl --nosave set-override :01:00.0 vfio-pci" on
> a virtio-blk-pci device, /proc/iomem shows that BAR4 is still owned by
> virtio_pci_modern even though the vfio-pci driver is now bound to the
> PCI device.
>
On Thu, Aug 10, 2023 at 8:40 AM Si-Wei Liu wrote:
>
>
>
> On 8/8/2023 11:52 PM, Jason Wang wrote:
> > On Wed, Aug 9, 2023 at 6:58 AM Si-Wei Liu wrote:
> >>
> >>
> >> On 8/7/2023 8:00 PM, Jason Wang wrote:
> >>> On Fri, Aug 4, 2023 at 1:5
On Wed, Aug 9, 2023 at 2:51 PM Michael S. Tsirkin wrote:
>
> On Wed, Aug 09, 2023 at 02:45:17PM +0800, Jason Wang wrote:
> > On Wed, Aug 9, 2023 at 2:23 PM Dragos Tatulea wrote:
> > >
> > > On Tue, 2023-08-08 at 23:13 -0400, Jason Wang wrote:
> > > >
101 - 200 of 5822 matches
Mail list logo
