Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Jason Wang
On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo wrote: > > > Hi, Jason > > Could you skip this patch? I'm fine with either merging or dropping this. > > Let we review other patches firstly? I will be on vacation soon, and won't have time to do this until next week. But I spot two possible "issues":

Re: [PATCH RFC 2/4] vdpa/mlx5: implement .reset_map driver op

2023-08-15 Thread Dragos Tatulea via Virtualization
On Mon, 2023-08-14 at 18:43 -0700, Si-Wei Liu wrote: > This patch is based on top of the "vdpa/mlx5: Fixes > for ASID handling" series [1]. > > [1] vdpa/mlx5: Fixes for ASID handling > https://lore.kernel.org/virtualization/20230802171231.11001-1-dtatu...@nvidia.com/ > > Signed-off-by: Si-Wei Liu

[PATCH] MAINTAINERS: Add myself as mlx5_vdpa driver

2023-08-15 Thread Dragos Tatulea via Virtualization
As Eli Cohen moved to other work, I'll be the contact point for mlx5_vdpa. Signed-off-by: Dragos Tatulea --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a5863f1b016..c9a9259f4d37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13555,6 +13

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Xuan Zhuo
On Tue, 15 Aug 2023 15:50:23 +0800, Jason Wang wrote: > On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo wrote: > > > > > > Hi, Jason > > > > Could you skip this patch? > > I'm fine with either merging or dropping this. > > > > > Let we review other patches firstly? > > I will be on vacation soon, and w

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2023 at 03:50:23PM +0800, Jason Wang wrote: > On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo wrote: > > > > > > Hi, Jason > > > > Could you skip this patch? > > I'm fine with either merging or dropping this. > > > > > Let we review other patches firstly? > > I will be on vacation soo

Re: [PATCH net v1] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting

2023-08-15 Thread Feng Liu via Virtualization
On 2023-08-15 a.m.6:51, Simon Horman wrote: External email: Use caution opening links or attachments On Mon, Aug 14, 2023 at 01:18:45PM -0400, Feng Liu wrote: + "David S. Miller" Eric Dumazet Jakub Kicinski Paolo Abeni Thanks for adding David S. Miller. The virtio_net drive

Re: [PATCH net v1] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting

2023-08-15 Thread Willem de Bruijn
On Tue, Aug 15, 2023 at 12:29 PM Simon Horman wrote: > > On Tue, Aug 15, 2023 at 11:09:02AM -0400, Feng Liu wrote: > > > > > > On 2023-08-15 a.m.6:51, Simon Horman wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > On Mon, Aug 14, 2023 at 01:18:45PM -0400, Feng

Re: [PATCH RFC 1/4] vdpa: introduce .reset_map operation callback

2023-08-15 Thread Si-Wei Liu
On 8/14/2023 7:21 PM, Jason Wang wrote: On Tue, Aug 15, 2023 at 9:46 AM Si-Wei Liu wrote: Signed-off-by: Si-Wei Liu --- include/linux/vdpa.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index db1b0ea..3a3878d 100644 --- a/include/l

Re: [PATCH RFC 4/4] vhost-vdpa: introduce IOTLB_PERSIST backend feature bit

2023-08-15 Thread Si-Wei Liu
On 8/14/2023 7:25 PM, Jason Wang wrote: On Tue, Aug 15, 2023 at 9:45 AM Si-Wei Liu wrote: Signed-off-by: Si-Wei Liu --- drivers/vhost/vdpa.c | 16 +++- include/uapi/linux/vhost_types.h | 2 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH RFC 3/4] vhost-vdpa: should restore 1:1 dma mapping before detaching driver

2023-08-15 Thread Si-Wei Liu
On 8/14/2023 7:32 PM, Jason Wang wrote: On Tue, Aug 15, 2023 at 9:45 AM Si-Wei Liu wrote: Signed-off-by: Si-Wei Liu --- drivers/vhost/vdpa.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index b43e868..62b0a01 100644 ---

Re: [PATCH RFC 2/4] vdpa/mlx5: implement .reset_map driver op

2023-08-15 Thread Si-Wei Liu
On 8/15/2023 1:26 AM, Dragos Tatulea wrote: On Mon, 2023-08-14 at 18:43 -0700, Si-Wei Liu wrote: This patch is based on top of the "vdpa/mlx5: Fixes for ASID handling" series [1]. [1] vdpa/mlx5: Fixes for ASID handling https://lore.kernel.org/virtualization/20230802171231.11001-1-dtatu...@nvi

Re: [PATCH RFC 0/3] vdpa: dedicated descriptor table group

2023-08-15 Thread Si-Wei Liu
On 8/9/2023 7:49 AM, Eugenio Perez Martin wrote: On Wed, Aug 9, 2023 at 2:56 PM Si-Wei Liu wrote: Following patchset introduces dedicated group for descriptor table to reduce live migration downtime when passthrough VQ is being switched to shadow VQ. As this RFC set is to seek early feedback

Re: [PATCH RFC 2/3] vhost-vdpa: introduce descriptor group backend feature

2023-08-15 Thread Si-Wei Liu
On 8/9/2023 8:49 PM, Jason Wang wrote: On Wed, Aug 9, 2023 at 8:56 PM Si-Wei Liu wrote: Userspace knows if the device has dedicated descriptor group or not by checking this feature bit. It's only exposed if the vdpa driver backend implements the .get_vq_desc_group() operation callback. Users

Re: [PATCH RFC 0/3] vdpa: dedicated descriptor table group

2023-08-15 Thread Si-Wei Liu
On 8/9/2023 8:50 PM, Jason Wang wrote: On Wed, Aug 9, 2023 at 8:56 PM Si-Wei Liu wrote: Following patchset introduces dedicated group for descriptor table to reduce live migration downtime when passthrough VQ is being switched to shadow VQ. As this RFC set is to seek early feedback on the uAP

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Jason Wang
On Tue, Aug 15, 2023 at 5:40 PM Xuan Zhuo wrote: > > On Tue, 15 Aug 2023 15:50:23 +0800, Jason Wang wrote: > > On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo > > wrote: > > > > > > > > > Hi, Jason > > > > > > Could you skip this patch? > > > > I'm fine with either merging or dropping this. > > > > >

Re: [PATCH RFC 4/4] vhost-vdpa: introduce IOTLB_PERSIST backend feature bit

2023-08-15 Thread Jason Wang
On Wed, Aug 16, 2023 at 6:31 AM Si-Wei Liu wrote: > > > > On 8/14/2023 7:25 PM, Jason Wang wrote: > > On Tue, Aug 15, 2023 at 9:45 AM Si-Wei Liu wrote: > >> Signed-off-by: Si-Wei Liu > >> --- > >> drivers/vhost/vdpa.c | 16 +++- > >> include/uapi/linux/vhost_types.h |

Re: [PATCH RFC 0/3] vdpa: dedicated descriptor table group

2023-08-15 Thread Jason Wang
On Wed, Aug 16, 2023 at 8:02 AM Si-Wei Liu wrote: > > > > On 8/9/2023 8:50 PM, Jason Wang wrote: > > On Wed, Aug 9, 2023 at 8:56 PM Si-Wei Liu wrote: > >> Following patchset introduces dedicated group for descriptor table to > >> reduce live migration downtime when passthrough VQ is being switche

Re: [PATCH RFC 1/4] vdpa: introduce .reset_map operation callback

2023-08-15 Thread Jason Wang
On Wed, Aug 16, 2023 at 3:49 AM Si-Wei Liu wrote: > > > > On 8/14/2023 7:21 PM, Jason Wang wrote: > > On Tue, Aug 15, 2023 at 9:46 AM Si-Wei Liu wrote: > >> Signed-off-by: Si-Wei Liu > >> --- > >> include/linux/vdpa.h | 7 +++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/in

Re: [PATCH RFC 2/3] vhost-vdpa: introduce descriptor group backend feature

2023-08-15 Thread Jason Wang
On Wed, Aug 16, 2023 at 7:54 AM Si-Wei Liu wrote: > > > > On 8/9/2023 8:49 PM, Jason Wang wrote: > > On Wed, Aug 9, 2023 at 8:56 PM Si-Wei Liu wrote: > >> Userspace knows if the device has dedicated descriptor group or not > >> by checking this feature bit. > >> > >> It's only exposed if the vdpa

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Xuan Zhuo
On Wed, 16 Aug 2023 09:13:48 +0800, Jason Wang wrote: > On Tue, Aug 15, 2023 at 5:40 PM Xuan Zhuo wrote: > > > > On Tue, 15 Aug 2023 15:50:23 +0800, Jason Wang wrote: > > > On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo > > > wrote: > > > > > > > > > > > > Hi, Jason > > > > > > > > Could you skip t

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Jason Wang
On Wed, Aug 16, 2023 at 10:16 AM Xuan Zhuo wrote: > > On Wed, 16 Aug 2023 09:13:48 +0800, Jason Wang wrote: > > On Tue, Aug 15, 2023 at 5:40 PM Xuan Zhuo > > wrote: > > > > > > On Tue, 15 Aug 2023 15:50:23 +0800, Jason Wang > > > wrote: > > > > On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo > >

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Xuan Zhuo
On Wed, 16 Aug 2023 10:19:34 +0800, Jason Wang wrote: > On Wed, Aug 16, 2023 at 10:16 AM Xuan Zhuo wrote: > > > > On Wed, 16 Aug 2023 09:13:48 +0800, Jason Wang wrote: > > > On Tue, Aug 15, 2023 at 5:40 PM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 15 Aug 2023 15:50:23 +0800, Jason Wang

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Jason Wang
On Wed, Aug 16, 2023 at 10:24 AM Xuan Zhuo wrote: > > On Wed, 16 Aug 2023 10:19:34 +0800, Jason Wang wrote: > > On Wed, Aug 16, 2023 at 10:16 AM Xuan Zhuo > > wrote: > > > > > > On Wed, 16 Aug 2023 09:13:48 +0800, Jason Wang > > > wrote: > > > > On Tue, Aug 15, 2023 at 5:40 PM Xuan Zhuo > >

Re: [PATCH net v1] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting

2023-08-15 Thread Feng Liu via Virtualization
On 2023-08-15 p.m.2:13, Willem de Bruijn wrote: External email: Use caution opening links or attachments On Tue, Aug 15, 2023 at 12:29 PM Simon Horman wrote: On Tue, Aug 15, 2023 at 11:09:02AM -0400, Feng Liu wrote: To clarify: In general new Networking features go via the net-next tree

Re: [PATCH] MAINTAINERS: Add myself as mlx5_vdpa driver

2023-08-15 Thread Jason Wang
On Tue, Aug 15, 2023 at 4:33 PM Dragos Tatulea wrote: > > As Eli Cohen moved to other work, I'll be the contact point for > mlx5_vdpa. > > Signed-off-by: Dragos Tatulea Acked-by: Jason Wang Thanks > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

2023-08-15 Thread Xuan Zhuo
On Wed, 16 Aug 2023 10:33:34 +0800, Jason Wang wrote: > On Wed, Aug 16, 2023 at 10:24 AM Xuan Zhuo wrote: > > > > On Wed, 16 Aug 2023 10:19:34 +0800, Jason Wang wrote: > > > On Wed, Aug 16, 2023 at 10:16 AM Xuan Zhuo > > > wrote: > > > > > > > > On Wed, 16 Aug 2023 09:13:48 +0800, Jason Wang