Re: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

2022-05-22 Thread zhenwei pi
On 5/22/22 21:07, Christophe JAILLET wrote: Now that a private buffer is allocated (see commit in the Fixes tag), it must be released in all error handling paths. Add the missing goto to avoid a leak in the error handling path. Fixes: 42e6ac99e417 ("virtio-crypto: use private buffer for cont

RE: [PATCH v2 2/3] vdpa: Add a device object for vdpa management device

2022-05-22 Thread Parav Pandit via Virtualization
> From: Jason Wang > Sent: Wednesday, May 18, 2022 4:32 AM > > 在 2022/5/18 07:03, Parav Pandit 写道: > >>> And regarding vduse_dev_release() and existing empty release > >>> function, > >> they can be dynamically allocated. > >>> This is because they are really the struct device. > >> I do not und

Re: About restoring the state in vhost-vdpa device

2022-05-22 Thread Jason Wang
On Wed, May 18, 2022 at 8:44 PM Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Monday, May 16, 2022 11:05 PM > > >> Although it's a longer route, I'd very much prefer an in-band virtio > > >> way to perform it rather than a linux/vdpa specific. It's one of the > > >> reasons I prefer the

RE: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

2022-05-22 Thread Gonglei (Arei) via Virtualization
> -Original Message- > From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr] > Sent: Sunday, May 22, 2022 9:07 PM > To: dan.carpen...@oracle.com; Gonglei (Arei) ; > Michael S. Tsirkin ; Jason Wang ; > Herbert Xu ; David S. Miller > ; zhenwei pi > Cc: linux-ker...@vger.kernel.o

Re: [PATCH v2 2/3] vdpa: Add a device object for vdpa management device

2022-05-22 Thread Jason Wang
On Mon, May 23, 2022 at 10:00 AM Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Wednesday, May 18, 2022 4:32 AM > > > > 在 2022/5/18 07:03, Parav Pandit 写道: > > >>> And regarding vduse_dev_release() and existing empty release > > >>> function, > > >> they can be dynamically allocated. > >

Re: [BUG] vDPA/ifcvf: got a warning when removing the module

2022-05-22 Thread Jason Wang
On Sat, May 21, 2022 at 10:27 PM Zheyu Ma wrote: > > Hello, > > I found a bug in the ifcvf driver. > When removing the module, I got the following warning: > > [ 14.478123] general protection fault, probably for non-canonical > address 0xdc05: [#1] PREEMPT SMP KASAN PTI > [ 14

Re: [PATCH] vhost-vdpa: Fix some error handling path in vhost_vdpa_process_iotlb_msg()

2022-05-22 Thread Jason Wang
On Sun, May 22, 2022 at 9:59 PM Christophe JAILLET wrote: > > In the error paths introduced by the commit in the Fixes tag, a mutex may > be left locked. > Add the correct goto instead of a direct return. > > Fixes: a1468175bb17 ("vhost-vdpa: support ASID based IOTLB API") > Signed-off-by: Christo