Re: [RFC PATCH 1/3] hw_random: allow RNG devices to give early randomness after a delay

2014-07-14 Thread Jason Cooper
On Mon, Jul 14, 2014 at 10:05:19AM +0530, Amit Shah wrote: > Some RNG devices may not be ready to give early randomness at probe() > time, and hence lose out on the opportunity to contribute to system > randomness at boot- or device hotplug- time. > > This commit schedules a delayed work item for

Re: [RFC PATCH 1/3] hw_random: allow RNG devices to give early randomness after a delay

2014-07-14 Thread Amit Shah
On (Mon) 14 Jul 2014 [08:37:00], Jason Cooper wrote: > On Mon, Jul 14, 2014 at 10:05:19AM +0530, Amit Shah wrote: > > Some RNG devices may not be ready to give early randomness at probe() > > time, and hence lose out on the opportunity to contribute to system > > randomness at boot- or device hotpl

Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes

2014-07-14 Thread Herbert Xu
On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote: > v3: > - Kees Cook pointed out a weird side-effect: devices which have >->init() registered get their randomness added to the system each >time they're switched in, but devices that don't have the init >callback don't contribu

Re: [RFC PATCH] hwrng: sysfs entry rng_seed_kernel, was: "Re: [PATCH v2 1/2] hwrng: fetch randomness only after device init"

2014-07-14 Thread Kees Cook
On Fri, Jul 11, 2014 at 8:44 AM, Jason Cooper wrote: > On Fri, Jul 11, 2014 at 06:56:26PM +0530, Amit Shah wrote: >> On (Wed) 09 Jul 2014 [12:07:25], Jason Cooper wrote: >> > Amit, Kees, >> >> (snip) >> >> > I'm cooling to the idea of the init function for virtio-rng, and it >> > might be best jus

Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes

2014-07-14 Thread Amit Shah
On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote: > On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote: > > v3: > > - Kees Cook pointed out a weird side-effect: devices which have > >->init() registered get their randomness added to the system each > >time they're switched in, but

Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes

2014-07-14 Thread Herbert Xu
On Tue, Jul 15, 2014 at 10:10:28AM +0530, Amit Shah wrote: > On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote: > > On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote: > > > v3: > > > - Kees Cook pointed out a weird side-effect: devices which have > > >->init() registered get their rand

Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes

2014-07-14 Thread Amit Shah
On (Tue) 15 Jul 2014 [12:45:56], Herbert Xu wrote: > On Tue, Jul 15, 2014 at 10:10:28AM +0530, Amit Shah wrote: > > On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote: > > > On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote: > > > > v3: > > > > - Kees Cook pointed out a weird side-effect: d