Re: [PATCH V2 2/2] virtio-net: reset virtqueue affinity when doing cpu hotplug

2013-01-07 Thread Wanlong Gao
On 01/07/2013 03:55 PM, Jason Wang wrote: > On 01/07/2013 03:48 PM, Wanlong Gao wrote: >> On 01/07/2013 03:28 PM, Jason Wang wrote: >>> On 01/07/2013 03:15 PM, Wanlong Gao wrote: Add a cpu notifier to virtio-net, so that we can reset the virtqueue affinity if the cpu hotplug happens. It i

Re: [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE

2013-01-07 Thread Jan Beulich
>>> On 04.01.13 at 18:25, Daniel Kiper wrote: > Right, so where is virtual mapping of control page established? > I could not find relevant code in SLES kernel which does that. In the hypervisor (xen/arch/x86/machine_kexec.c:machine_kexec_load()). xen/arch/x86/machine_kexec.c:machine_kexec() then

Re: [Xen-devel] [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2013-01-07 Thread Ian Campbell
On Fri, 2013-01-04 at 19:11 +, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 04, 2013 at 06:07:51PM +0100, Daniel Kiper wrote: > > On Fri, Jan 04, 2013 at 02:41:17PM +, Jan Beulich wrote: > > > >>> On 04.01.13 at 15:22, Daniel Kiper wrote: > > > > On Wed, Jan 02, 2013 at 11:26:43AM +, And

Re: [Xen-devel] [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2013-01-07 Thread Andrew Cooper
On 07/01/13 10:25, Ian Campbell wrote: On Fri, 2013-01-04 at 19:11 +, Konrad Rzeszutek Wilk wrote: On Fri, Jan 04, 2013 at 06:07:51PM +0100, Daniel Kiper wrote: Because current KEXEC_CMD_kexec_load does not load kernel image and other things into Xen memory. It means that it should live som

Re: [Xen-devel] [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2013-01-07 Thread Ian Campbell
On Mon, 2013-01-07 at 10:46 +, Andrew Cooper wrote: > Given that /sbin/kexec creates a binary blob in memory, surely the most > simple thing is to get it to suitably mlock() the region and give a list > of VAs to the hypervisor. More than likely. The DOMID_KEXEC thing was just a radon musin

Re: [Xen-devel] [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2013-01-07 Thread Daniel Kiper
On Fri, Jan 04, 2013 at 02:11:46PM -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 04, 2013 at 06:07:51PM +0100, Daniel Kiper wrote: > > On Fri, Jan 04, 2013 at 02:41:17PM +, Jan Beulich wrote: > > > >>> On 04.01.13 at 15:22, Daniel Kiper wrote: > > > > On Wed, Jan 02, 2013 at 11:26:43AM +00

Re: [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE

2013-01-07 Thread Daniel Kiper
On Mon, Jan 07, 2013 at 09:48:20AM +, Jan Beulich wrote: > >>> On 04.01.13 at 18:25, Daniel Kiper wrote: > > Right, so where is virtual mapping of control page established? > > I could not find relevant code in SLES kernel which does that. > > In the hypervisor (xen/arch/x86/machine_kexec.c:ma

Re: [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE

2013-01-07 Thread Jan Beulich
>>> On 07.01.13 at 13:52, Daniel Kiper wrote: > On Mon, Jan 07, 2013 at 09:48:20AM +, Jan Beulich wrote: >> >>> On 04.01.13 at 18:25, Daniel Kiper wrote: >> > Right, so where is virtual mapping of control page established? >> > I could not find relevant code in SLES kernel which does that. >>

Re: [Xen-devel] [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2013-01-07 Thread Ian Campbell
On Mon, 2013-01-07 at 12:34 +, Daniel Kiper wrote: > I think that new kexec hypercall function should mimics kexec syscall. We want to have an interface can be used by non-Linux domains (both dom0 and domU) as well though, so please bear this in mind. Historically we've not always been good a

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2013-01-07 Thread Paolo Bonzini
Il 07/01/2013 01:02, Rusty Russell ha scritto: > Paolo Bonzini writes: >> Il 02/01/2013 06:03, Rusty Russell ha scritto: >>> Paolo Bonzini writes: The virtqueue_add_buf function has two limitations: 1) it requires the caller to provide all the buffers in a single call; 2)

Re: [PATCH V3 2/2] vhost: handle polling errors

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 12:38:17PM +0800, Jason Wang wrote: > On 01/06/2013 09:22 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 06, 2013 at 03:18:38PM +0800, Jason Wang wrote: > >> Polling errors were ignored by vhost/vhost_net, this may lead to crash when > >> trying to remove vhost from waitqueue

Re: [PATCH V3 2/2] vhost: handle polling errors

2013-01-07 Thread Jason Wang
On 01/07/2013 10:55 PM, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2013 at 12:38:17PM +0800, Jason Wang wrote: >> On 01/06/2013 09:22 PM, Michael S. Tsirkin wrote: >>> On Sun, Jan 06, 2013 at 03:18:38PM +0800, Jason Wang wrote: Polling errors were ignored by vhost/vhost_net, this may lead to

Re: [PATCH] drivers/xen: avoid out-of-range write in xen_add_device

2013-01-07 Thread Konrad Rzeszutek Wilk
On Sat, Jan 05, 2013 at 02:18:46PM -0500, Nickolai Zeldovich wrote: > xen_add_device() in drivers/xen/pci.c allocates a struct > physdev_pci_device_add on the stack and then writes to optarr[0]. > The previous declaration of struct physdev_pci_device_add contained > a zero-length optarr[] array, pr

Re: [PATCH] drivers/xen: avoid out-of-range write in xen_add_device

2013-01-07 Thread Jan Beulich
>>> On 07.01.13 at 16:08, Konrad Rzeszutek Wilk wrote: > On Sat, Jan 05, 2013 at 02:18:46PM -0500, Nickolai Zeldovich wrote: >> xen_add_device() in drivers/xen/pci.c allocates a struct >> physdev_pci_device_add on the stack and then writes to optarr[0]. >> The previous declaration of struct physde

Re: [Xen-devel] [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2013-01-07 Thread Konrad Rzeszutek Wilk
On Mon, Jan 07, 2013 at 01:34:04PM +0100, Daniel Kiper wrote: > On Fri, Jan 04, 2013 at 02:11:46PM -0500, Konrad Rzeszutek Wilk wrote: > > On Fri, Jan 04, 2013 at 06:07:51PM +0100, Daniel Kiper wrote: > > > On Fri, Jan 04, 2013 at 02:41:17PM +, Jan Beulich wrote: > > > > >>> On 04.01.13 at 15:2

Re: [Xen-devel] [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2013-01-07 Thread David Vrabel
On 04/01/13 14:22, Daniel Kiper wrote: > On Wed, Jan 02, 2013 at 11:26:43AM +, Andrew Cooper wrote: >> On 27/12/12 18:02, Eric W. Biederman wrote: >>> Andrew Cooper writes: >>> On 27/12/2012 07:53, Eric W. Biederman wrote: > The syscall ABI still has the wrong semantics. > > A

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2013-01-07 Thread Rusty Russell
Paolo Bonzini writes: > Il 07/01/2013 01:02, Rusty Russell ha scritto: >> Paolo Bonzini writes: >>> Il 02/01/2013 06:03, Rusty Russell ha scritto: Paolo Bonzini writes: > The virtqueue_add_buf function has two limitations: > > 1) it requires the caller to provide all the buffers

[no subject]

2013-01-07 Thread Michael S. Tsirkin
On Sun, Jan 06, 2013 at 02:36:13PM +0800, Asias He wrote: > This drops the cmd completion list spin lock and makes the cmd > completion queue lock-less. > > Signed-off-by: Asias He Nicholas, any feedback? > --- > drivers/vhost/tcm_vhost.c | 46 +- >