Re: [kvm-devel] [PATCH 1/1] QEMU/KVM: Support for PCI Passthrough

2008-04-18 Thread Samuel Masham
On Fri, Apr 18, 2008 at 2:39 PM, Amit Shah <[EMAIL PROTECTED]> wrote: > * On Monday 14 Apr 2008 06:01:07 Samuel Masham wrote: > > > > Please keep the userspace support alive. > > > > I am particularly interested in using the pci-passthough to qemu > > running non x86 system emulation > > (at

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 14:39:48 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > virtio introduced a ring structure ABI for guest-host communications > (currently used by lguest and kvm). Using this same ABI, we can > create a nice fd version. > > This is useful for efficiently passing packets to a

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > This patch modifies tun to allow a vringfd to specify the send > buffer. The user does a write to push out packets from the buffer. > > Again we use the 'struct virtio_net_hdr' to allow userspace to send > GSO packets.

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread pradeep singh rautela
On Fri, Apr 18, 2008 at 10:13 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > This patch modifies tun to allow a vringfd to specify the send > buffer. The user does a write to push out packets from the buffer. > > Again we use the 'struct virtio_net_hdr' to allow userspace to send > GSO packets.

Re: [6/6] [VIRTIO] net: Allow receiving SG packets

2008-04-18 Thread Rusty Russell
On Friday 18 April 2008 13:24:27 Herbert Xu wrote: > Finally this patch lets virtio_net receive GSO packets in addition > to sending them. This can definitely be optimised for the non-GSO > case. For comparison the Xen approach stores one page in each skb > and uses subsequent skb's pages to cons

Re: [6/6] [VIRTIO] net: Allow receiving SG packets

2008-04-18 Thread Herbert Xu
On Sat, Apr 19, 2008 at 12:08:04AM +1000, Rusty Russell wrote: > On Friday 18 April 2008 13:24:27 Herbert Xu wrote: > > Finally this patch lets virtio_net receive GSO packets in addition > > to sending them. This can definitely be optimised for the non-GSO > > case. For comparison the Xen approac

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Rusty Russell
On Friday 18 April 2008 21:18:46 Andrew Morton wrote: > > + /* Must be a power of two, and limit indices to a u16. */ > > + if (!num_descs || (num_descs & (num_descs-1)) || num_descs > 65536) > > We have an is_power_of_2(). Thanks, fixed. > > + * vring_get - check out a vring file descriptor

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Ray Lee
On Fri, Apr 18, 2008 at 4:46 AM, pradeep singh rautela <[EMAIL PROTECTED]> wrote: > > On Fri, Apr 18, 2008 at 10:13 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > > + /* How many pages will this take? */ > > + npages = 1 + (base + len - 1)/PAGE_SIZE - base/PAGE_SIZE;

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Rusty Russell
On Friday 18 April 2008 21:31:20 Andrew Morton wrote: > On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > + /* How many pages will this take? */ > > + npages = 1 + (base + len - 1)/PAGE_SIZE - base/PAGE_SIZE; > > Brain hurts. I hope you got that ri

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Ray Lee
On Fri, Apr 18, 2008 at 8:15 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > On Friday 18 April 2008 21:31:20 Andrew Morton wrote: > > On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > + /* How many pages will this take? */ > > > + npages = 1 +

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread pradeep singh rautela
On Fri, Apr 18, 2008 at 7:55 PM, Ray Lee <[EMAIL PROTECTED]> wrote: > On Fri, Apr 18, 2008 at 4:46 AM, pradeep singh rautela > <[EMAIL PROTECTED]> wrote: > > > > On Fri, Apr 18, 2008 at 10:13 AM, Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > + /* How many pages will this take?

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 00:32:39 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > Isn't this kinda-sorta like what a relayfs file does? The oprofile > > buffers? etc? Nothing in common at all, no hope? > > An excellent question, but I thought the modern kernel etiquette was to only > comment on

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > What is the maximum numbet of pages which an unpriviliged user can > > concurrently pin with this code? > > Since only root can open the tun device, it's currently OK. The old code > kmalloced and copied: is ther

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Michael Kerrisk
On 4/18/08, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sat, 19 Apr 2008 00:32:39 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > Isn't this kinda-sorta like what a relayfs file does? The oprofile > > > buffers? etc? Nothing in common at all, no hope? > > > > An excellent question,

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > It's not clear to me why this is in swap.c, but it exists > even without CONFIG_SWAP, so that's OK. We should have done mv mm/swap.c mm/mmlib.c years ago. ___ Virtualization m