Re: virtio-sound linux driver conformance to spec

2023-09-25 Thread Matias Ezequiel Vara Larsen
On Mon, Sep 25, 2023 at 10:04:33AM +0900, Anton Yakovlev wrote: > Hello Matias, > > On 20.09.2023 22:18, Matias Ezequiel Vara Larsen wrote: > > On Tue, Sep 19, 2023 at 11:52:27AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Sep 19, 2023 at 04:18:57PM +0200, Matias Ezequiel Vara Larsen > > > wro

Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Matias, On 20.09.2023 22:18, Matias Ezequiel Vara Larsen wrote: On Tue, Sep 19, 2023 at 11:52:27AM -0400, Michael S. Tsirkin wrote: On Tue, Sep 19, 2023 at 04:18:57PM +0200, Matias Ezequiel Vara Larsen wrote: On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote: On Wed, Se

Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Michael, On 20.09.2023 00:52, Michael S. Tsirkin wrote: On Tue, Sep 19, 2023 at 04:18:57PM +0200, Matias Ezequiel Vara Larsen wrote: On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote: On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote: Hello, T

Re: [virtio-comment] Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Stefan, On 20.09.2023 00:10, Stefan Hajnoczi wrote: As an aside, here are two other statements that have a similar issue: - 2.6.1.1.2 "the driver MAY release any resource associated with that virtqueue" (instead 2.6.1.1.1 should have something like "After a queue has been reset by the dr

Re: [virtio-comment] Re: virtio-sound linux driver conformance to spec

2023-09-24 Thread Anton Yakovlev via Virtualization
Hello Paolo, On 19.09.2023 15:58, Paolo Bonzini wrote: On 9/19/23 02:35, Anton Yakovlev wrote: If the Linux virtio sound driver violates a specification, then there must be a conformance statement that the driver does not follow. As far as I know, there is no such thing at the moment. There

Re: virtio-sound linux driver conformance to spec

2023-09-20 Thread Matias Ezequiel Vara Larsen
On Tue, Sep 19, 2023 at 11:52:27AM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 19, 2023 at 04:18:57PM +0200, Matias Ezequiel Vara Larsen wrote: > > On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote: > > > On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen > >

Re: virtio-sound linux driver conformance to spec

2023-09-19 Thread Michael S. Tsirkin
On Tue, Sep 19, 2023 at 04:18:57PM +0200, Matias Ezequiel Vara Larsen wrote: > On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote: > > > Hello, > > > > > > This email is to report a behavior of the Lin

Re: [virtio-comment] Re: virtio-sound linux driver conformance to spec

2023-09-19 Thread Stefan Hajnoczi
On Tue, Sep 19, 2023 at 08:58:32AM +0200, Paolo Bonzini wrote: > On 9/19/23 02:35, Anton Yakovlev wrote: > > > > If the Linux virtio sound driver violates a specification, then there > > must be > > a conformance statement that the driver does not follow. As far as I know, > > there is no such thi

Re: virtio-sound linux driver conformance to spec

2023-09-19 Thread Matias Ezequiel Vara Larsen
On Tue, Sep 19, 2023 at 05:43:56AM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote: > > Hello, > > > > This email is to report a behavior of the Linux virtio-sound driver that > > looks like it is not conforming to the VirtIO specifica

Re: virtio-sound linux driver conformance to spec

2023-09-19 Thread Michael S. Tsirkin
On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote: > Hello, > > This email is to report a behavior of the Linux virtio-sound driver that > looks like it is not conforming to the VirtIO specification. The kernel > driver is moving buffers from the used ring to the availabl

Re: [virtio-comment] Re: virtio-sound linux driver conformance to spec

2023-09-18 Thread Paolo Bonzini
On 9/19/23 02:35, Anton Yakovlev wrote: If the Linux virtio sound driver violates a specification, then there must be a conformance statement that the driver does not follow. As far as I know, there is no such thing at the moment. There is one in 2.7.13.3: "The device MAY access the descript

Re: virtio-sound linux driver conformance to spec

2023-09-18 Thread Anton Yakovlev via Virtualization
Hello Matias, On 14.09.2023 00:04, Matias Ezequiel Vara Larsen wrote: Hello, This email is to report a behavior of the Linux virtio-sound driver that looks like it is not conforming to the VirtIO specification. The kernel driver is moving buffers from the used ring to the available ring without

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Stefan Hajnoczi
On Mon, Sep 18, 2023 at 02:50:09PM +0200, Matias Ezequiel Vara Larsen wrote: > On Wed, Sep 13, 2023 at 06:58:30PM +0300, Manos Pitsidianakis wrote: > > Hello Matias, > > > > Please show and refer to code snippets from the kernel tree that you > > think are related to your question. It'd help us ma

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Matias Ezequiel Vara Larsen
On Wed, Sep 13, 2023 at 06:58:30PM +0300, Manos Pitsidianakis wrote: > Hello Matias, > > Please show and refer to code snippets from the kernel tree that you > think are related to your question. It'd help us make sure we all talk > about the same thing. > In this discussion, I am referring to t

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Matias Ezequiel Vara Larsen
On Mon, Sep 18, 2023 at 1:13 PM Matias Ezequiel Vara Larsen wrote: > > On Wed, Sep 13, 2023 at 05:50:48PM +0200, Paolo Bonzini wrote: > > On Wed, Sep 13, 2023 at 5:05 PM Matias Ezequiel Vara Larsen > > wrote: > > > > > > Hello, > > > > > > This email is to report a behavior of the Linux virtio-so

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Matias Ezequiel Vara Larsen
On Wed, Sep 13, 2023 at 05:50:48PM +0200, Paolo Bonzini wrote: > On Wed, Sep 13, 2023 at 5:05 PM Matias Ezequiel Vara Larsen > wrote: > > > > Hello, > > > > This email is to report a behavior of the Linux virtio-sound driver that > > looks like it is not conforming to the VirtIO specification. The

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-13 Thread Paolo Bonzini
On Wed, Sep 13, 2023 at 5:05 PM Matias Ezequiel Vara Larsen wrote: > > Hello, > > This email is to report a behavior of the Linux virtio-sound driver that > looks like it is not conforming to the VirtIO specification. The kernel > driver is moving buffers from the used ring to the available ring >

virtio-sound linux driver conformance to spec

2023-09-13 Thread Matias Ezequiel Vara Larsen
Hello, This email is to report a behavior of the Linux virtio-sound driver that looks like it is not conforming to the VirtIO specification. The kernel driver is moving buffers from the used ring to the available ring without knowing if the content has been updated from the user. If the device pic