Re: [PATCH v3 3/8] iommufd: Add fault and response message definitions

2024-03-25 Thread Baolu Lu
On 3/23/24 1:04 AM, Jason Gunthorpe wrote: +struct iommu_hwpt_pgfault { + __u32 size; + __u32 flags; + __u32 dev_id; + __u32 pasid; + __u32 grpid; + __u32 perm; + __u64 addr; +}; Do we need an addr + size here? I've seen a few things where I wonder if th

Re: [PATCH v3 3/8] iommufd: Add fault and response message definitions

2024-03-22 Thread Jason Gunthorpe
On Thu, Mar 14, 2024 at 09:41:45PM +0800, Baolu Lu wrote: > On 2024/3/9 1:50, Jason Gunthorpe wrote: > > On Mon, Jan 22, 2024 at 03:38:58PM +0800, Lu Baolu wrote: > > > > > +/** > > > + * enum iommu_hwpt_pgfault_flags - flags for struct iommu_hwpt_pgfault > > > + * @IOMMU_PGFAULT_FLAGS_PASID_VALID

Re: [PATCH v3 3/8] iommufd: Add fault and response message definitions

2024-03-14 Thread Baolu Lu
On 2024/3/9 1:50, Jason Gunthorpe wrote: On Mon, Jan 22, 2024 at 03:38:58PM +0800, Lu Baolu wrote: +/** + * enum iommu_hwpt_pgfault_flags - flags for struct iommu_hwpt_pgfault + * @IOMMU_PGFAULT_FLAGS_PASID_VALID: The pasid field of the fault data is + * valid.

Re: [PATCH v3 3/8] iommufd: Add fault and response message definitions

2024-03-08 Thread Jason Gunthorpe
On Mon, Jan 22, 2024 at 03:38:58PM +0800, Lu Baolu wrote: > +/** > + * enum iommu_hwpt_pgfault_flags - flags for struct iommu_hwpt_pgfault > + * @IOMMU_PGFAULT_FLAGS_PASID_VALID: The pasid field of the fault data is > + * valid. > + * @IOMMU_PGFAULT_FLAGS_LAST_PAG