Re: [PATCH linux-next v4 4/8] vdpa: Enable user to set mac and mtu of vdpa device

2021-10-25 Thread Jason Wang
在 2021/10/25 下午3:06, Parav Pandit 写道: From: Jason Wang Sent: Monday, October 25, 2021 12:31 PM 在 2021/10/22 上午12:35, Parav Pandit 写道: $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000 $ vdpa dev config show bar: mac 00:11:22:33:44:55 link up link_announce false mt

RE: [PATCH linux-next v4 4/8] vdpa: Enable user to set mac and mtu of vdpa device

2021-10-25 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Monday, October 25, 2021 1:38 PM > > It depends on what will the user be able to do then. > Inject packets? Affect RX routing? Use up networking resources? > NET_ADMIN is a safe choice but we didn't check any capability in the past so > it > seems reasonable

Re: [PATCH linux-next v4 4/8] vdpa: Enable user to set mac and mtu of vdpa device

2021-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2021 at 07:06:42AM +, Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Monday, October 25, 2021 12:31 PM > > > > 在 2021/10/22 上午12:35, Parav Pandit 写道: > > > $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu > > > 9000 > > > > > > $ vdpa dev config

RE: [PATCH linux-next v4 4/8] vdpa: Enable user to set mac and mtu of vdpa device

2021-10-25 Thread Parav Pandit via Virtualization
> From: Jason Wang > Sent: Monday, October 25, 2021 12:31 PM > > 在 2021/10/22 上午12:35, Parav Pandit 写道: > > $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu > > 9000 > > > > $ vdpa dev config show > > bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000 > > > >

Re: [PATCH linux-next v4 4/8] vdpa: Enable user to set mac and mtu of vdpa device

2021-10-25 Thread Jason Wang
在 2021/10/22 上午12:35, Parav Pandit 写道: $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000 $ vdpa dev config show bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000 $ vdpa dev config show -jp { "config": { "bar": { "mac": "00:11:22