Re: [V4 PATCH] virtio-net: send gratuitous packet when needed

2012-03-19 Thread Jason Wang
On 03/19/2012 04:44 PM, Michael S. Tsirkin wrote: On Mon, Mar 19, 2012 at 12:46:29PM +1030, Rusty Russell wrote: On Tue, 13 Mar 2012 16:33:31 +0200, "Michael S. Tsirkin" wrote: diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h index 970d5a2..44a38d6 100644 --- a/include/lin

Re: [V4 PATCH] virtio-net: send gratuitous packet when needed

2012-03-19 Thread Michael S. Tsirkin
On Mon, Mar 19, 2012 at 12:46:29PM +1030, Rusty Russell wrote: > On Tue, 13 Mar 2012 16:33:31 +0200, "Michael S. Tsirkin" > wrote: > > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > > > index 970d5a2..44a38d6 100644 > > > --- a/include/linux/virtio_net.h > > > +++ b/incl

Re: [V4 PATCH] virtio-net: send gratuitous packet when needed

2012-03-18 Thread Rusty Russell
On Tue, 13 Mar 2012 16:33:31 +0200, "Michael S. Tsirkin" wrote: > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > > index 970d5a2..44a38d6 100644 > > --- a/include/linux/virtio_net.h > > +++ b/include/linux/virtio_net.h > > @@ -49,8 +49,10 @@ > > #define VIRTIO_NET_F_CTR

Re: [V4 PATCH] virtio-net: send gratuitous packet when needed

2012-03-13 Thread Michael S. Tsirkin
On Tue, Mar 13, 2012 at 05:08:41PM +0800, Jason Wang wrote: > As hypervior does not have the knowledge of guest network configuration, it's > better to ask guest to send gratuitous packet when needed. packet -> packets > > Guest test VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and wh

[V4 PATCH] virtio-net: send gratuitous packet when needed

2012-03-13 Thread Jason Wang
As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packet when needed. Guest test VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it is set, a workqueue is scheduled to send gratuitous packet through NETDEV_NOTIFY_