Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread Anthony Liguori
On 06/30/2010 05:31 PM, Michael S. Tsirkin wrote: > On Wed, Jun 30, 2010 at 05:08:11PM -0500, Anthony Liguori wrote: > >> On 06/29/2010 08:04 AM, Michael S. Tsirkin wrote: >> >>> On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: >>> From: "Michael S. Tsirkin"

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread Michael S. Tsirkin
On Wed, Jun 30, 2010 at 05:08:11PM -0500, Anthony Liguori wrote: > On 06/29/2010 08:04 AM, Michael S. Tsirkin wrote: > >On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: > >>From: "Michael S. Tsirkin" > >>Date: Mon, 28 Jun 2010 13:08:07 +0300 > >> > >>>Userspace virtio server has the fo

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread Anthony Liguori
On 06/29/2010 08:04 AM, Michael S. Tsirkin wrote: > On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: > >> From: "Michael S. Tsirkin" >> Date: Mon, 28 Jun 2010 13:08:07 +0300 >> >> >>> Userspace virtio server has the following hack >>> so guests rely on it, and we have to repl

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 29 Jun 2010 16:04:39 +0300 > Since using the module involves updating the management tools > as well, if we go down this route it will be much less painful > for everyone to do push it upstream. Ok, you can make your case to Patrick McHardy and if he'll merg

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread Michael S. Tsirkin
On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Mon, 28 Jun 2010 13:08:07 +0300 > > > Userspace virtio server has the following hack > > so guests rely on it, and we have to replicate it, too: > > > > Use port number to detect incoming IPv4 DHCP

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 28 Jun 2010 13:08:07 +0300 > Userspace virtio server has the following hack > so guests rely on it, and we have to replicate it, too: > > Use port number to detect incoming IPv4 DHCP response packets, > and fill in the checksum for these. > > The issue we a

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread Michael S. Tsirkin
On Mon, Jun 28, 2010 at 03:19:41PM -0700, Sridhar Samudrala wrote: > On Mon, 2010-06-28 at 13:08 +0300, Michael S. Tsirkin wrote: > > Userspace virtio server has the following hack > > so guests rely on it, and we have to replicate it, too: > > > > Use port number to detect incoming IPv4 DHCP resp

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-28 Thread Sridhar Samudrala
On Mon, 2010-06-28 at 13:08 +0300, Michael S. Tsirkin wrote: > Userspace virtio server has the following hack > so guests rely on it, and we have to replicate it, too: > > Use port number to detect incoming IPv4 DHCP response packets, > and fill in the checksum for these. > > The issue we are sol

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-28 Thread Michael S. Tsirkin
On Mon, Jun 28, 2010 at 01:08:07PM +0300, Michael S. Tsirkin wrote: > Userspace virtio server has the following hack > so guests rely on it, and we have to replicate it, too: > > Use port number to detect incoming IPv4 DHCP response packets, > and fill in the checksum for these. > > The issue we

[PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-28 Thread Michael S. Tsirkin
Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The issue we are solving is that on linux guests, some apps that use recvmsg with AF_PACKET soc