Re: [PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped

2023-05-23 Thread Xuan Zhuo
On Tue, 23 May 2023 03:19:42 -0400, "Michael S. Tsirkin" wrote: > On Mon, May 22, 2023 at 11:03:26PM -0700, Christoph Hellwig wrote: > > On Wed, May 17, 2023 at 10:22:41AM +0800, Xuan Zhuo wrote: > > > virtuque_add() adds parameter premapped. > > > > Well, I can see that. But why? > > Assuming i

Re: [PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped

2023-05-23 Thread Michael S. Tsirkin
On Mon, May 22, 2023 at 11:03:26PM -0700, Christoph Hellwig wrote: > On Wed, May 17, 2023 at 10:22:41AM +0800, Xuan Zhuo wrote: > > virtuque_add() adds parameter premapped. > > Well, I can see that. But why? Assuming it's intentional, it should say something along the lines of "The parameter is

Re: [PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped

2023-05-22 Thread Christoph Hellwig
On Wed, May 17, 2023 at 10:22:41AM +0800, Xuan Zhuo wrote: > virtuque_add() adds parameter premapped. Well, I can see that. But why? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/lis

Re: [PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped

2023-05-17 Thread Jason Wang
On Wed, May 17, 2023 at 10:23 AM Xuan Zhuo wrote: > > virtuque_add() adds parameter premapped. I wonder if this patch is over simplified. Maybe it can be squashed with the patch that implements the premapped logic. Thanks > > Signed-off-by: Xuan Zhuo > --- > drivers/virtio/virtio_ring.c | 9

[PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped

2023-05-16 Thread Xuan Zhuo
virtuque_add() adds parameter premapped. Signed-off-by: Xuan Zhuo --- drivers/virtio/virtio_ring.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 1ffab1eb40c0..e2fc50c05bec 100644 --- a/drivers/virtio