Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-29 Thread kernel test robot
Hi Wu, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.15-rc3 next-20210922] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https

Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-27 Thread Jason Wang
On Mon, Sep 27, 2021 at 6:36 PM Michael S. Tsirkin wrote: > > On Sun, Sep 26, 2021 at 12:18:26PM +0800, Jason Wang wrote: > > > > I wonder if the following can work with ENI: > > > > > > > > -device virtio-net-pci,mrg_rxbuf=off > > > > > > > > ? > > > > > > ENI didn't work. > > > I will remove F_M

Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-27 Thread Michael S. Tsirkin
On Sun, Sep 26, 2021 at 12:18:26PM +0800, Jason Wang wrote: > > > I wonder if the following can work with ENI: > > > > > > -device virtio-net-pci,mrg_rxbuf=off > > > > > > ? > > > > ENI didn't work. > > I will remove F_MRG_RXBUF when get_features. > > I think we need to fail FEATURE_OK if F_MRG_RX

Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-25 Thread Jason Wang
On Sun, Sep 26, 2021 at 11:27 AM Wu Zongyong wrote: > > On Sun, Sep 26, 2021 at 10:26:47AM +0800, Jason Wang wrote: > > > > 在 2021/9/22 下午8:46, Wu Zongyong 写道: > > > + > > > +#ifdef __LITTLE_ENDIAN > > > > > > I think disable the device via Kconfig is better than letting user to meet > > errors li

Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-25 Thread Jason Wang
On Sun, Sep 26, 2021 at 11:24 AM Wu Zongyong wrote: > > On Sun, Sep 26, 2021 at 10:24:21AM +0800, Jason Wang wrote: > > On Wed, Sep 22, 2021 at 8:47 PM Wu Zongyong > > wrote: > > > > > > This patch adds a new vDPA driver for Alibaba ENI(Elastic Network > > > Interface) which is build upon virtio

Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-25 Thread Jason Wang
在 2021/9/22 下午8:46, Wu Zongyong 写道: + +#ifdef __LITTLE_ENDIAN I think disable the device via Kconfig is better than letting user to meet errors like this. (Or if the device is always using little endian, we don't even need to bother this). Thanks +static int eni_vdpa_probe(struct pci

Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-25 Thread Jason Wang
On Wed, Sep 22, 2021 at 8:47 PM Wu Zongyong wrote: > > This patch adds a new vDPA driver for Alibaba ENI(Elastic Network > Interface) which is build upon virtio 0.9.5 specification. > And this driver doesn't support to run on BE host. > > Signed-off-by: Wu Zongyong > --- > drivers/vdpa/Kconfig