Re: [PATCH v3] virtio_net: avoid using netif_tx_disable() for serializing tx routine

2018-10-17 Thread David Miller
From: Ake Koomsin Date: Wed, 17 Oct 2018 19:44:12 +0900 > Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") > introduces netif_tx_disable() after netif_device_detach() in order to > avoid use-after-free of tx queues. However, there are two issues. > > 1) Its operation is redu

Re: [PATCH v3] virtio_net: avoid using netif_tx_disable() for serializing tx routine

2018-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2018 at 07:44:12PM +0900, Ake Koomsin wrote: > Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") > introduces netif_tx_disable() after netif_device_detach() in order to > avoid use-after-free of tx queues. However, there are two issues. > > 1) Its operation is r

Re: [PATCH v3] virtio_net: avoid using netif_tx_disable() for serializing tx routine

2018-10-17 Thread Jason Wang
On 2018/10/17 下午6:44, Ake Koomsin wrote: Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") introduces netif_tx_disable() after netif_device_detach() in order to avoid use-after-free of tx queues. However, there are two issues. 1) Its operation is redundant with netif_device_