Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-10 Thread Amit Shah
On (Thu) 10 Jul 2014 [16:45:14], Herbert Xu wrote: > On Wed, Jul 09, 2014 at 12:18:36PM -0400, Jason Cooper wrote: > > On Sat, Jul 05, 2014 at 11:04:53AM +0530, Amit Shah wrote: > > > The hwrng core asks for random data in the hwrng_register() call itself > > > from commit d9e7972619. This doesn't

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-10 Thread Herbert Xu
On Wed, Jul 09, 2014 at 12:18:36PM -0400, Jason Cooper wrote: > On Sat, Jul 05, 2014 at 11:04:53AM +0530, Amit Shah wrote: > > The hwrng core asks for random data in the hwrng_register() call itself > > from commit d9e7972619. This doesn't play well with virtio -- the > > DRIVER_OK bit is only set

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-10 Thread Amit Shah
On (Wed) 09 Jul 2014 [12:18:36], Jason Cooper wrote: > On Sat, Jul 05, 2014 at 11:04:53AM +0530, Amit Shah wrote: > > The hwrng core asks for random data in the hwrng_register() call itself > > from commit d9e7972619. This doesn't play well with virtio -- the > > DRIVER_OK bit is only set by virti

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-09 Thread Jason Cooper
On Sat, Jul 05, 2014 at 11:04:53AM +0530, Amit Shah wrote: > The hwrng core asks for random data in the hwrng_register() call itself > from commit d9e7972619. This doesn't play well with virtio -- the > DRIVER_OK bit is only set by virtio core on a successful probe, and > we're not yet out of our

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-09 Thread Amit Shah
On (Wed) 09 Jul 2014 [08:08:23], Jason Cooper wrote: > On Mon, Jul 07, 2014 at 12:04:09PM +0530, Amit Shah wrote: > > On (Sun) 06 Jul 2014 [23:09:49], Kees Cook wrote: > > > On Sun, Jul 6, 2014 at 10:51 PM, Amit Shah wrote: > > > > On (Sun) 06 Jul 2014 [21:38:36], Kees Cook wrote: > > > >> On Fri,

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-09 Thread Jason Cooper
On Mon, Jul 07, 2014 at 12:04:09PM +0530, Amit Shah wrote: > On (Sun) 06 Jul 2014 [23:09:49], Kees Cook wrote: > > On Sun, Jul 6, 2014 at 10:51 PM, Amit Shah wrote: > > > On (Sun) 06 Jul 2014 [21:38:36], Kees Cook wrote: > > >> On Fri, Jul 4, 2014 at 10:34 PM, Amit Shah wrote: > > >> > The hwrng

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-06 Thread Amit Shah
On (Sun) 06 Jul 2014 [23:09:49], Kees Cook wrote: > On Sun, Jul 6, 2014 at 10:51 PM, Amit Shah wrote: > > On (Sun) 06 Jul 2014 [21:38:36], Kees Cook wrote: > >> On Fri, Jul 4, 2014 at 10:34 PM, Amit Shah wrote: > >> > The hwrng core asks for random data in the hwrng_register() call itself > >> >

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-06 Thread Kees Cook
On Sun, Jul 6, 2014 at 10:51 PM, Amit Shah wrote: > On (Sun) 06 Jul 2014 [21:38:36], Kees Cook wrote: >> On Fri, Jul 4, 2014 at 10:34 PM, Amit Shah wrote: >> > The hwrng core asks for random data in the hwrng_register() call itself >> > from commit d9e7972619. This doesn't play well with virtio

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-06 Thread Amit Shah
On (Sun) 06 Jul 2014 [21:38:36], Kees Cook wrote: > On Fri, Jul 4, 2014 at 10:34 PM, Amit Shah wrote: > > The hwrng core asks for random data in the hwrng_register() call itself > > from commit d9e7972619. This doesn't play well with virtio -- the > > DRIVER_OK bit is only set by virtio core on a

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-06 Thread Kees Cook
On Fri, Jul 4, 2014 at 10:34 PM, Amit Shah wrote: > The hwrng core asks for random data in the hwrng_register() call itself > from commit d9e7972619. This doesn't play well with virtio -- the > DRIVER_OK bit is only set by virtio core on a successful probe, and > we're not yet out of our probe ro

[PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-04 Thread Amit Shah
The hwrng core asks for random data in the hwrng_register() call itself from commit d9e7972619. This doesn't play well with virtio -- the DRIVER_OK bit is only set by virtio core on a successful probe, and we're not yet out of our probe routine when this call is made. This causes the host to not