Re: Re: Re: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-18 Thread zhenwei pi via Virtualization
On 5/18/23 18:09, Michael S. Tsirkin wrote: On Thu, May 18, 2023 at 08:47:22AM +0800, zhenwei pi wrote: On 5/17/23 18:39, Michael S. Tsirkin wrote: On Wed, May 17, 2023 at 04:35:55PM +0800, zhenwei pi wrote: On 5/17/23 15:46, Christoph Hellwig wrote: On Wed, May 17, 2023 at 03:43:03PM +0

Re: Re: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-18 Thread Michael S. Tsirkin
On Thu, May 18, 2023 at 08:47:22AM +0800, zhenwei pi wrote: > On 5/17/23 18:39, Michael S. Tsirkin wrote: > > On Wed, May 17, 2023 at 04:35:55PM +0800, zhenwei pi wrote: > > > > > > > > > On 5/17/23 15:46, Christoph Hellwig wrote: > > > > On Wed, May 17, 2023 at 03:43:03PM +0800, zhenwei pi wrote

Re: Re: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-17 Thread zhenwei pi via Virtualization
On 5/17/23 18:39, Michael S. Tsirkin wrote: On Wed, May 17, 2023 at 04:35:55PM +0800, zhenwei pi wrote: On 5/17/23 15:46, Christoph Hellwig wrote: On Wed, May 17, 2023 at 03:43:03PM +0800, zhenwei pi wrote: I have a plan to introduce 'Virtio Over Fabrics'(TCP&RDMA) as Virtio transport, as me

Re: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-17 Thread Michael S. Tsirkin
On Wed, May 17, 2023 at 04:35:55PM +0800, zhenwei pi wrote: > > > On 5/17/23 15:46, Christoph Hellwig wrote: > > On Wed, May 17, 2023 at 03:43:03PM +0800, zhenwei pi wrote: > > > I have a plan to introduce 'Virtio Over Fabrics'(TCP&RDMA) as Virtio > > > transport, as mentioned in cover letter of

Re: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-17 Thread zhenwei pi via Virtualization
On 5/17/23 15:46, Christoph Hellwig wrote: On Wed, May 17, 2023 at 03:43:03PM +0800, zhenwei pi wrote: I have a plan to introduce 'Virtio Over Fabrics'(TCP&RDMA) as Virtio transport, as mentioned in cover letter of this series: 3 weeks ago, I posted a proposal 'Virtio Over Fabrics': https://l

Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-17 Thread Christoph Hellwig
On Wed, May 17, 2023 at 03:43:03PM +0800, zhenwei pi wrote: > I have a plan to introduce 'Virtio Over Fabrics'(TCP&RDMA) as Virtio > transport, as mentioned in cover letter of this series: > 3 weeks ago, I posted a proposal 'Virtio Over Fabrics': > https://lists.oasis-open.org/archives/virtio-comme

Re: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-17 Thread zhenwei pi via Virtualization
On 5/17/23 15:39, Christoph Hellwig wrote: On Wed, May 17, 2023 at 10:54:23AM +0800, zhenwei pi wrote: All the vring based virtqueue methods could be abstratct in theory, MST suggested that add/get bufs and kick functions are quite perfmance sensitive, so export these functions from virtio_ri

Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-17 Thread Christoph Hellwig
On Wed, May 17, 2023 at 10:54:23AM +0800, zhenwei pi wrote: > All the vring based virtqueue methods could be abstratct in theory, > MST suggested that add/get bufs and kick functions are quite perfmance > sensitive, so export these functions from virtio_ring.ko, drivers > still call them in a fast

Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-16 Thread kernel test robot
.git linux-next patch link: https://lore.kernel.org/r/20230517025424.601141-2-pizhenwei%40bytedance.com patch subject: [PATCH v2 1/2] virtio: abstract virtqueue related methods config: alpha-randconfig-r003-20230517 compiler: alpha-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): w

[PATCH v2 1/2] virtio: abstract virtqueue related methods

2023-05-16 Thread zhenwei pi via Virtualization
There is already a virtqueue abstract structure in virtio subsystem (see struct virtqueue in include/linux/virtio.h), however the vring based virtqueue is used only in the past years, the virtqueue related methods mix much with vring(just look like the codes, virtqueue_xxx functions are implemented