Re: [PATCH net v6] virtio_net: Fix error unwinding of XDP initialization

2023-05-14 Thread Michael S. Tsirkin
On Fri, May 12, 2023 at 11:18:12AM -0400, Feng Liu wrote: > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to rol

Re: [PATCH net v6] virtio_net: Fix error unwinding of XDP initialization

2023-05-14 Thread Xuan Zhuo
On Fri, 12 May 2023 11:18:12 -0400, Feng Liu wrote: > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to roll bac

Re: [PATCH net v6] virtio_net: Fix error unwinding of XDP initialization

2023-05-14 Thread Jason Wang
On Fri, May 12, 2023 at 11:18 PM Feng Liu wrote: > > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to roll back

Re: [PATCH net v6] virtio_net: Fix error unwinding of XDP initialization

2023-05-12 Thread Michael S. Tsirkin
On Fri, May 12, 2023 at 11:18:12AM -0400, Feng Liu wrote: > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to rol

[PATCH net v6] virtio_net: Fix error unwinding of XDP initialization

2023-05-12 Thread Feng Liu via Virtualization
When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs have already initialized XDP and enabled NAPI, which is not the expected behavior. Need to roll back the previous rq initialization to avoid leaks in error unwi