Re: [PATCH 9/10] Vmi timer update.patch

Chris Wright wrote: > * Zachary Amsden ([EMAIL PROTECTED]) wrote: > +void __init vmi_time_init(void) +{ + /* Disable PIT: BIOSes start PIT CH0 with 18.2hz peridic. */ + outb_p(0x3a, PIT_MODE); /* binary, mode 5, LSB/MSB, ch 0 */ >>> That shouldn't be necessary

Re: [PATCH 9/10] Vmi timer update.patch

Chris Wright wrote: > * Zachary Amsden ([EMAIL PROTECTED]) wrote: > >> Yes, but unfortunately that is a nop: >> >> /* >> * Avoid unnecessary state transitions, as it confuses >> * Geode / Cyrix based boxen. >> */ >> case CLOCK_EVT_MODE_SHUTDOWN: >>

Re: [PATCH 9/10] Vmi timer update.patch

* Zachary Amsden ([EMAIL PROTECTED]) wrote: > Jeremy Fitzhardinge wrote: > >Why not submit a patch to do what you need here? (The Geode comment is > >a bit worrying though.) > > Why should VMI add workaround into PIT code? I'm not sure it's a workaround, seems more like a subtle diff (perhaps it

Re: [PATCH 9/10] Vmi timer update.patch

Jeremy Fitzhardinge wrote: > Why not submit a patch to do what you need here? (The Geode comment is > a bit worrying though.) > Why should VMI add workaround into PIT code? PIT code wants to know nothing about VMI. It understands PIT timers on hardware. VMI, on the other hand, is special

Re: [PATCH 9/10] Vmi timer update.patch

* Zachary Amsden ([EMAIL PROTECTED]) wrote: > Yes, but unfortunately that is a nop: > > /* > * Avoid unnecessary state transitions, as it confuses > * Geode / Cyrix based boxen. > */ > case CLOCK_EVT_MODE_SHUTDOWN: > if (evt->mode == CLOCK

Re: [PATCH 9/10] Vmi timer update.patch

Zachary Amsden wrote: >/* > * Avoid unnecessary state transitions, as it confuses > * Geode / Cyrix based boxen. > */ >case CLOCK_EVT_MODE_SHUTDOWN: >if (evt->mode == CLOCK_EVT_MODE_UNUSED) >break; >case CLOCK_E

Re: [PATCH 9/10] Vmi timer update.patch

Chris Wright wrote: > * Zachary Amsden ([EMAIL PROTECTED]) wrote: > +void __init vmi_time_init(void) +{ + /* Disable PIT: BIOSes start PIT CH0 with 18.2hz peridic. */ + outb_p(0x3a, PIT_MODE); /* binary, mode 5, LSB/MSB, ch 0 */ >>> That shouldn't be necessary

Re: [PATCH 9/10] Vmi timer update.patch

* Zachary Amsden ([EMAIL PROTECTED]) wrote: > >>+void __init vmi_time_init(void) > >>+{ > >>+ /* Disable PIT: BIOSes start PIT CH0 with 18.2hz peridic. */ > >>+ outb_p(0x3a, PIT_MODE); /* binary, mode 5, LSB/MSB, ch 0 */ > > > >That shouldn't be necessary using clockevents. > > Actually, I'm n

Re: [PATCH 9/10] Vmi timer update.patch

Chris Wright wrote: Thanks for the review! Comments inline. >> +/* paravirt_ops.get_wallclock = vmi_get_wallclock */ >> > > Style nit, these pv_ops.foo = vmi_foo style comments aren't really useful. > > Yeah, and easy to get out of sync. I'll drop them. >> +.rating = 1000

Re: [PATCH 9/10] Vmi timer update.patch

* Zachary Amsden ([EMAIL PROTECTED]) wrote: > diff -r c02ab981c99c arch/i386/kernel/vmiclock.c > --- /dev/null Thu Jan 01 00:00:00 1970 + > +++ b/arch/i386/kernel/vmiclock.c Mon Apr 09 15:47:17 2007 -0700 > @@ -0,0 +1,318 @@ > +/* > + * VMI paravirtual timer support routines. > + * > + * Co

[PATCH 9/10] Vmi timer update.patch

Convert VMI timer to use clock events, making it properly able to use the NO_HZ infrastructure. On UP systems, with no local APIC, we just continue to route these events through the PIT. On systems with a local APIC, or SMP, we provide a single source interrupt chip which creates the local timer