Re: [PATCH 4/5] virtio net: Allow receiving SG packets

2008-07-15 Thread Herbert Xu
On Tue, Jul 15, 2008 at 06:25:04PM +1000, Rusty Russell wrote: > > Oops. I grepped for LRO when I did this and found nothing. > > How's this one? Looks good. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.or

Re: [PATCH 4/5] virtio net: Allow receiving SG packets

2008-07-15 Thread Rusty Russell
On Tuesday 15 July 2008 13:52:09 Herbert Xu wrote: > On Mon, Jul 14, 2008 at 10:41:38PM -0500, Rusty Russell wrote: > > + /* If we can receive ANY GSO packets, we must allocate large ones. */ > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) > > + || virtio_has_feature(vdev, VIR

Re: [PATCH 4/5] virtio net: Allow receiving SG packets

2008-07-14 Thread Herbert Xu
On Mon, Jul 14, 2008 at 10:41:38PM -0500, Rusty Russell wrote: > > + /* If we can receive ANY GSO packets, we must allocate large ones. */ > + if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) > + || virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) > + || virtio_has_fea

[PATCH 4/5] virtio net: Allow receiving SG packets

2008-07-14 Thread Rusty Russell
From: Herbert Xu <[EMAIL PROTECTED]> Finally this patch lets virtio_net receive GSO packets in addition to sending them. This can definitely be optimised for the non-GSO case. For comparison the Xen approach stores one page in each skb and uses subsequent skb's pages to construct an SG skb inste