Re: [PATCH 1/4] Add helper functions for paravirtual clocksources.

2008-05-22 Thread Jeremy Fitzhardinge
Gerd Hoffmann wrote: > Jeremy Fitzhardinge wrote: > > >>> +static unsigned pvclock_get_time_values(struct pvclock_shadow_time *dst, >>> +struct kvm_vcpu_time_info *src) >>> >>> >> I think the kvm_* types should be renamed. xen_* would make some sense >> since the A

Re: [PATCH 1/4] Add helper functions for paravirtual clocksources.

2008-05-22 Thread Gerd Hoffmann
Jeremy Fitzhardinge wrote: >> +static unsigned pvclock_get_time_values(struct pvclock_shadow_time *dst, >> +struct kvm_vcpu_time_info *src) >> > > I think the kvm_* types should be renamed. xen_* would make some sense > since the ABI originated with Xen, but something gene

Re: [PATCH 1/4] Add helper functions for paravirtual clocksources.

2008-05-21 Thread Jeremy Fitzhardinge
Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann <[EMAIL PROTECTED]> > Looks basically OK, but some comments. > --- > arch/x86/Kconfig |4 + > arch/x86/kernel/Makefile |1 + > arch/x86/kernel/pvclock.c | 148 > + > include/asm

[PATCH 1/4] Add helper functions for paravirtual clocksources.

2008-05-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <[EMAIL PROTECTED]> --- arch/x86/Kconfig |4 + arch/x86/kernel/Makefile |1 + arch/x86/kernel/pvclock.c | 148 + include/asm-x86/pvclock.h |6 ++ 4 files changed, 159 insertions(+), 0 deletions(-) cre

[PATCH 1/4] Add helper functions for paravirtual clocksources.

2008-05-08 Thread Gerd Hoffmann
The helper functions are intended to be used by both xen and kvm paravirtual clock sources. Following patches of this series put them into use. They are based on the xen code. Cc: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Signed-off-by: Gerd Hoffmann <[EMAIL PROTECTED]> --- arch/x86/Kconfig