Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-31 Thread Michael S. Tsirkin
On Thu, Oct 28, 2021 at 02:16:03PM +0800, Xuan Zhuo wrote: > On Thu, 28 Oct 2021 10:16:10 +0800, Jason Wang wrote: > > On Thu, Oct 28, 2021 at 1:07 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Oct 27, 2021 at 02:19:11PM +0800, Xuan Zhuo wrote: > > > > In the case of using indirect, indirect d

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread Xuan Zhuo
On Thu, 28 Oct 2021 10:16:10 +0800, Jason Wang wrote: > On Thu, Oct 28, 2021 at 1:07 AM Michael S. Tsirkin wrote: > > > > On Wed, Oct 27, 2021 at 02:19:11PM +0800, Xuan Zhuo wrote: > > > In the case of using indirect, indirect desc must be allocated and > > > released each time, which increases a

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread Jason Wang
On Thu, Oct 28, 2021 at 1:07 AM Michael S. Tsirkin wrote: > > On Wed, Oct 27, 2021 at 02:19:11PM +0800, Xuan Zhuo wrote: > > In the case of using indirect, indirect desc must be allocated and > > released each time, which increases a lot of cpu overhead. > > > > Here, a cache is added for indirect

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread kernel test robot
Hi Xuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on horms-ipvs/master] [also build test WARNING on linus/master v5.15-rc7 next-20211027] [cannot apply to mst-vhost/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread kernel test robot
Hi Xuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on horms-ipvs/master] [also build test WARNING on linus/master v5.15-rc7 next-20211027] [cannot apply to mst-vhost/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread Michael S. Tsirkin
On Wed, Oct 27, 2021 at 09:33:46AM -0700, Dongli Zhang wrote: > > > On 10/26/21 11:19 PM, Xuan Zhuo wrote: > > In the case of using indirect, indirect desc must be allocated and > > released each time, which increases a lot of cpu overhead. > > > > Here, a cache is added for indirect. If the num

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread Michael S. Tsirkin
On Wed, Oct 27, 2021 at 02:19:11PM +0800, Xuan Zhuo wrote: > In the case of using indirect, indirect desc must be allocated and > released each time, which increases a lot of cpu overhead. > > Here, a cache is added for indirect. If the number of indirect desc to be > applied for is less than VIRT

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread Dongli Zhang
On 10/26/21 11:19 PM, Xuan Zhuo wrote: > In the case of using indirect, indirect desc must be allocated and > released each time, which increases a lot of cpu overhead. > > Here, a cache is added for indirect. If the number of indirect desc to be > applied for is less than VIRT_QUEUE_CACHE_DESC

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread Xuan Zhuo
On Wed, 27 Oct 2021 04:55:16 -0400, Michael S. Tsirkin wrote: > On Wed, Oct 27, 2021 at 02:19:11PM +0800, Xuan Zhuo wrote: > > In the case of using indirect, indirect desc must be allocated and > > released each time, which increases a lot of cpu overhead. > > > > Here, a cache is added for indire

Re: [PATCH 1/3] virtio: cache indirect desc for split

2021-10-27 Thread Michael S. Tsirkin
On Wed, Oct 27, 2021 at 02:19:11PM +0800, Xuan Zhuo wrote: > In the case of using indirect, indirect desc must be allocated and > released each time, which increases a lot of cpu overhead. > > Here, a cache is added for indirect. If the number of indirect desc to be > applied for is less than VIRT

[PATCH 1/3] virtio: cache indirect desc for split

2021-10-26 Thread Xuan Zhuo
In the case of using indirect, indirect desc must be allocated and released each time, which increases a lot of cpu overhead. Here, a cache is added for indirect. If the number of indirect desc to be applied for is less than VIRT_QUEUE_CACHE_DESC_NUM, the desc array with the size of VIRT_QUEUE_CAC